You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by mygityf <gi...@git.apache.org> on 2016/03/15 03:26:15 UTC

[GitHub] thrift pull request: THRIFT-3745 The precision should be 17 for do...

GitHub user mygityf opened a pull request:

    https://github.com/apache/thrift/pull/949

    THRIFT-3745 The precision should be 17 for double

    $num= 3.1415926535897931;
    $this->trans_->write(json_encode($num)); 
    The value will be '3.1415926535898' and some precision lost after format operation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gityf/thrift PHP-double-precision-17-bits

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #949
    
----
commit 77b8fb3fedeaf0cf030fd8e6afc7808fca408513
Author: Wang Yaofu <vo...@sina.cn>
Date:   2016-03-15T02:25:33Z

    THRIFT-3745 The precision should be 17 for double
    
    $num= 3.1415926535897931;
    $this->trans_->write(json_encode($num)); 
    The value will be '3.1415926535898' and some precision lost after format operation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3745 The precision should be 17 for do...

Posted by mygityf <gi...@git.apache.org>.
Github user mygityf closed the pull request at:

    https://github.com/apache/thrift/pull/949


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---