You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/09 22:59:56 UTC
[GitHub] [druid] zachjsh edited a comment on pull request #11507: option to use deep storage for storing shuffle data
zachjsh edited a comment on pull request #11507:
URL: https://github.com/apache/druid/pull/11507#issuecomment-895596626
> Travis checks passed except for test coverage issues as mentioned in above comment.
@pjain1 the second phase integration tests did not because of the coverage failure. I've manually started those just now. It looks like a lot of the missed branches are coming from equals method. Can you add tests for these, can use EqualsVerifier to make your life easier. It also looks like you have legitimate failures
```
[ERROR] Errors:
[ERROR] org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerAutoCleanupTest.testCleanup(org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerAutoCleanupTest)
[ERROR] Run 1: LocalIntermediaryDataManagerAutoCleanupTest.testCleanup:128 » ISE Can't find l...
[ERROR] Run 2: LocalIntermediaryDataManagerAutoCleanupTest.testCleanup:128 » ISE Can't find l...
[ERROR] Run 3: LocalIntermediaryDataManagerAutoCleanupTest.testCleanup:128 » ISE Can't find l...
[ERROR] Run 4: LocalIntermediaryDataManagerAutoCleanupTest.testCleanup:128 » ISE Can't find l...
[INFO]
[ERROR] org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest.deletePartitions(org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest)
[ERROR] Run 1: LocalIntermediaryDataManagerManualAddAndDeleteTest.deletePartitions:141 » ISE ...
[ERROR] Run 2: LocalIntermediaryDataManagerManualAddAndDeleteTest.deletePartitions:141 » ISE ...
[ERROR] Run 3: LocalIntermediaryDataManagerManualAddAndDeleteTest.deletePartitions:141 » ISE ...
[ERROR] Run 4: LocalIntermediaryDataManagerManualAddAndDeleteTest.deletePartitions:141 » ISE ...
[INFO]
[ERROR] org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddRemoveAdd(org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest)
[ERROR] Run 1: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddRemoveAdd:165 » ISE ...
[ERROR] Run 2: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddRemoveAdd:165 » ISE ...
[ERROR] Run 3: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddRemoveAdd:165 » ISE ...
[ERROR] Run 4: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddRemoveAdd:165 » ISE ...
[INFO]
[ERROR] org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddSegmentFailure(org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest)
[ERROR] Run 1: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddSegmentFailure:101 » ISE
[ERROR] Run 2: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddSegmentFailure:101 » ISE
[ERROR] Run 3: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddSegmentFailure:101 » ISE
[ERROR] Run 4: LocalIntermediaryDataManagerManualAddAndDeleteTest.testAddSegmentFailure:101 » ISE
[INFO]
[ERROR] org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest.testFindPartitionFiles(org.apache.druid.indexing.worker.shuffle.LocalIntermediaryDataManagerManualAddAndDeleteTest)
[ERROR] Run 1: LocalIntermediaryDataManagerManualAddAndDeleteTest.testFindPartitionFiles:119 » ISE
[ERROR] Run 2: LocalIntermediaryDataManagerManualAddAndDeleteTest.testFindPartitionFiles:119 » ISE
[ERROR] Run 3: LocalIntermediaryDataManagerManualAddAndDeleteTest.testFindPartitionFiles:119 » ISE
[ERROR] Run 4: LocalIntermediaryDataManagerManualAddAndDeleteTest.testFindPartitionFiles:119 » ISE
[INFO]
[ERROR] org.apache.druid.indexing.worker.shuffle.ShuffleResourceTest.testDeletePartitionWithValidParamsReturnOk(org.apache.druid.indexing.worker.shuffle.ShuffleResourceTest)
[ERROR] Run 1: ShuffleResourceTest.testDeletePartitionWithValidParamsReturnOk:174 » ISE Can't...
[ERROR] Run 2: ShuffleResourceTest.testDeletePartitionWithValidParamsReturnOk:174 » ISE Can't...
[ERROR] Run 3: ShuffleResourceTest.testDeletePartitionWithValidParamsReturnOk:174 » ISE Can't...
[ERROR] Run 4: ShuffleResourceTest.testDeletePartitionWithValidParamsReturnOk:174 » ISE Can't...
[INFO]
[ERROR] org.apache.druid.indexing.worker.shuffle.ShuffleResourceTest.testGetPartitionWithValidParamsReturnOk(org.apache.druid.indexing.worker.shuffle.ShuffleResourceTest)
[ERROR] Run 1: ShuffleResourceTest.testGetPartitionWithValidParamsReturnOk:144 » ISE Can't fi...
[ERROR] Run 2: ShuffleResourceTest.testGetPartitionWithValidParamsReturnOk:144 » ISE Can't fi...
[ERROR] Run 3: ShuffleResourceTest.testGetPartitionWithValidParamsReturnOk:144 » ISE Can't fi...
[ERROR] Run 4: ShuffleResourceTest.testGetPartitionWithValidParamsReturnOk:144 » ISE Can't fi...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org