You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/12/02 05:24:05 UTC

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/1716

    [ ZEPPELIN-531 ] execute and stop note in job menu

    ### What is this PR for?
    We can note start and stop in job menu.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] - add feature for run/stop
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-968
    
    ### How should this be tested?
    Click to a note start or stop button in job menu.
    
    ### Screenshots (if appropriate)
    ![executenote](https://cloud.githubusercontent.com/assets/10525473/20823821/ec8a39c8-b89a-11e6-91f2-0eddc4bcffd9.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin jobm/executeNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    @cloverhearts can you please rebase it on latest master - `git rebase master` and force push it? This will trigger CI with latest fixes and help to see if there are any relevant failures here.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1716

    [ ZEPPELIN-531 ] execute and stop note in job menu

    ### What is this PR for?
    We can note start and stop in job menu.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] - add feature for run/stop
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-968
    
    ### How should this be tested?
    Click to a note start or stop button in job menu.
    
    ### Screenshots (if appropriate)
    ![executenote](https://cloud.githubusercontent.com/assets/10525473/20823821/ec8a39c8-b89a-11e6-91f2-0eddc4bcffd9.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin jobm/executeNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----
commit 23abb3ae025ef7b6ba9339b9cd383969adb6e526
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-02T04:38:51Z

    execute and stop note in job menu

commit f40b12fe3aaf0429fc9501cc2b32cf039d83a773
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-05T07:25:49Z

    Merge branch 'master' into jobm/executeNote

commit d3bd76e6255a4c20766785ff186934cf0d601c64
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:40:02Z

    change `if` syntanx style

commit 24d7ced861dbc770b0bc182cfa4ba0aff0b67c4d
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:42:33Z

    Merge branch 'master' into jobm/executeNote
    
    # Conflicts:
    #	zeppelin-web/src/app/jobmanager/jobs/job.controller.js

commit b7f205171835ea025aed7c6f22ad189eff1042e1
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T14:13:45Z

    remove whitespace

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:

    https://github.com/apache/zeppelin/pull/1716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:

    https://github.com/apache/zeppelin/pull/1716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:

    https://github.com/apache/zeppelin/pull/1716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:

    https://github.com/apache/zeppelin/pull/1716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1716

    [ ZEPPELIN-531 ] execute and stop note in job menu

    ### What is this PR for?
    We can note start and stop in job menu.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] - add feature for run/stop
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-968
    
    ### How should this be tested?
    Click to a note start or stop button in job menu.
    
    ### Screenshots (if appropriate)
    ![executenote](https://cloud.githubusercontent.com/assets/10525473/20823821/ec8a39c8-b89a-11e6-91f2-0eddc4bcffd9.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin jobm/executeNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----
commit 23abb3ae025ef7b6ba9339b9cd383969adb6e526
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-02T04:38:51Z

    execute and stop note in job menu

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    It's working as expected. Thank you for great improvement. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1716

    [ ZEPPELIN-531 ] execute and stop note in job menu

    ### What is this PR for?
    We can note start and stop in job menu.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] - add feature for run/stop
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-968
    
    ### How should this be tested?
    Click to a note start or stop button in job menu.
    
    ### Screenshots (if appropriate)
    ![executenote](https://cloud.githubusercontent.com/assets/10525473/20823821/ec8a39c8-b89a-11e6-91f2-0eddc4bcffd9.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin jobm/executeNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----
commit 23abb3ae025ef7b6ba9339b9cd383969adb6e526
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-02T04:38:51Z

    execute and stop note in job menu

commit f40b12fe3aaf0429fc9501cc2b32cf039d83a773
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-05T07:25:49Z

    Merge branch 'master' into jobm/executeNote

commit d3bd76e6255a4c20766785ff186934cf0d601c64
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:40:02Z

    change `if` syntanx style

commit 24d7ced861dbc770b0bc182cfa4ba0aff0b67c4d
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:42:33Z

    Merge branch 'master' into jobm/executeNote
    
    # Conflicts:
    #	zeppelin-web/src/app/jobmanager/jobs/job.controller.js

commit b7f205171835ea025aed7c6f22ad189eff1042e1
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T14:13:45Z

    remove whitespace

commit e00f9ce581716b24ccb2b76095982ff9ff71d5a7
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:05:46Z

    apply code style

commit b6fb3819392c17ae911f7ffcc419d19997dbc091
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:36:36Z

    change string check style

commit f00b7388cf589ab418f3a41e723f1cbfb2503e9f
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-14T07:06:19Z

    Merge branch 'master' into jobm/executeNote

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1716

    [ ZEPPELIN-531 ] execute and stop note in job menu

    ### What is this PR for?
    We can note start and stop in job menu.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] - add feature for run/stop
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-968
    
    ### How should this be tested?
    Click to a note start or stop button in job menu.
    
    ### Screenshots (if appropriate)
    ![executenote](https://cloud.githubusercontent.com/assets/10525473/20823821/ec8a39c8-b89a-11e6-91f2-0eddc4bcffd9.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin jobm/executeNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----
commit 23abb3ae025ef7b6ba9339b9cd383969adb6e526
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-02T04:38:51Z

    execute and stop note in job menu

commit f40b12fe3aaf0429fc9501cc2b32cf039d83a773
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-05T07:25:49Z

    Merge branch 'master' into jobm/executeNote

commit d3bd76e6255a4c20766785ff186934cf0d601c64
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:40:02Z

    change `if` syntanx style

commit 24d7ced861dbc770b0bc182cfa4ba0aff0b67c4d
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:42:33Z

    Merge branch 'master' into jobm/executeNote
    
    # Conflicts:
    #	zeppelin-web/src/app/jobmanager/jobs/job.controller.js

commit b7f205171835ea025aed7c6f22ad189eff1042e1
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T14:13:45Z

    remove whitespace

commit e00f9ce581716b24ccb2b76095982ff9ff71d5a7
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:05:46Z

    apply code style

commit b6fb3819392c17ae911f7ffcc419d19997dbc091
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:36:36Z

    change string check style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:

    https://github.com/apache/zeppelin/pull/1716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:

    https://github.com/apache/zeppelin/pull/1716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    @bzz Sure!
    I will That.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    Hello @bzz ,
    could you please review?
    ci is green.
    I think ready for merge on this pr.
    Thank you :)
    Have a nice day.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1716

    [ ZEPPELIN-531 ] execute and stop note in job menu

    ### What is this PR for?
    We can note start and stop in job menu.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] - add feature for run/stop
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-968
    
    ### How should this be tested?
    Click to a note start or stop button in job menu.
    
    ### Screenshots (if appropriate)
    ![executenote](https://cloud.githubusercontent.com/assets/10525473/20823821/ec8a39c8-b89a-11e6-91f2-0eddc4bcffd9.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin jobm/executeNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----
commit 23abb3ae025ef7b6ba9339b9cd383969adb6e526
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-02T04:38:51Z

    execute and stop note in job menu

commit f40b12fe3aaf0429fc9501cc2b32cf039d83a773
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-05T07:25:49Z

    Merge branch 'master' into jobm/executeNote

commit d3bd76e6255a4c20766785ff186934cf0d601c64
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:40:02Z

    change `if` syntanx style

commit 24d7ced861dbc770b0bc182cfa4ba0aff0b67c4d
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:42:33Z

    Merge branch 'master' into jobm/executeNote
    
    # Conflicts:
    #	zeppelin-web/src/app/jobmanager/jobs/job.controller.js

commit b7f205171835ea025aed7c6f22ad189eff1042e1
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T14:13:45Z

    remove whitespace

commit e00f9ce581716b24ccb2b76095982ff9ff71d5a7
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:05:46Z

    apply code style

commit b6fb3819392c17ae911f7ffcc419d19997dbc091
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:36:36Z

    change string check style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:

    https://github.com/apache/zeppelin/pull/1716

    [ ZEPPELIN-531 ] execute and stop note in job menu

    ### What is this PR for?
    We can note start and stop in job menu.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] - add feature for run/stop
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-968
    
    ### How should this be tested?
    Click to a note start or stop button in job menu.
    
    ### Screenshots (if appropriate)
    ![executenote](https://cloud.githubusercontent.com/assets/10525473/20823821/ec8a39c8-b89a-11e6-91f2-0eddc4bcffd9.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin jobm/executeNote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----
commit 23abb3ae025ef7b6ba9339b9cd383969adb6e526
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-02T04:38:51Z

    execute and stop note in job menu

commit f40b12fe3aaf0429fc9501cc2b32cf039d83a773
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-05T07:25:49Z

    Merge branch 'master' into jobm/executeNote

commit d3bd76e6255a4c20766785ff186934cf0d601c64
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:40:02Z

    change `if` syntanx style

commit 24d7ced861dbc770b0bc182cfa4ba0aff0b67c4d
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T13:42:33Z

    Merge branch 'master' into jobm/executeNote
    
    # Conflicts:
    #	zeppelin-web/src/app/jobmanager/jobs/job.controller.js

commit b7f205171835ea025aed7c6f22ad189eff1042e1
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-07T14:13:45Z

    remove whitespace

commit e00f9ce581716b24ccb2b76095982ff9ff71d5a7
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:05:46Z

    apply code style

commit b6fb3819392c17ae911f7ffcc419d19997dbc091
Author: CloverHearts <cl...@gmail.com>
Date:   2016-12-08T03:36:36Z

    change string check style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    @cloverhearts thank you for contribution! In my experience, if PR author or one of reviewers post the reason for CI failure - that speeds up the review\merge process dramatically.
    
    CI is failing with flaky pySpark tests, not relevant to the PR
    
    ```
    Results :
    
    Failed tests: 
      ZeppelinSparkClusterTest.pySparkDepLoaderTest:430 expected:<FINISHED> but was:<ERROR>
      ZeppelinSparkClusterTest.pySparkAutoConvertOptionTest:312 expected:<FINISHED> but was:<ERROR>
    
    Tests run: 82, Failures: 2, Errors: 0, Skipped: 1
    ```
    
    It will be handled under [ZEPPELIN-1761](https://issues.apache.org/jira/browse/ZEPPELIN-1761).
    
    \cc @felizbear to review the frontend part.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1716: [ ZEPPELIN-531 ] execute and stop note in job m...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    @astroshim 
    Thank you, have a good day!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1716
  
    Tested and LGTM.
    Merge to master if there're no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---