You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/23 08:18:15 UTC

[GitHub] [airflow] potiuk opened a new pull request, #32087: Remove casting of forward_credentials for shell and start-airflow breeze

potiuk opened a new pull request, #32087:
URL: https://github.com/apache/airflow/pull/32087

   The forward-credentials flag was supposed to be disabled when you run start-airflow and shell commands. However the flag boolean value has been casted to str so False became "False" and forward-credentials for these two commaands have been enabled by default no matter if the flag was used. In effect for example .docker configuration and credentials have been forwarded to inside the docker container via `.docker` folder mapped, and in case you had some credentials helper or plugin configured there, it was also set for docker configuration.
   
   Using the boolean value fixes the problem. Now you shoudl specify the --forward-credentials flag explicitly to forward credentials.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #32087: Remove casting of forward_credentials for shell and start-airflow breeze

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32087:
URL: https://github.com/apache/airflow/pull/32087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #32087: Remove casting of forward_credentials for shell and start-airflow breeze

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32087:
URL: https://github.com/apache/airflow/pull/32087#issuecomment-1603910093

   cc: @vandonr-amz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org