You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/04/28 05:29:00 UTC
[jira] [Commented] (IMPALA-6885) test_recover_partitions.py
test_support_all_types fails
[ https://issues.apache.org/jira/browse/IMPALA-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457363#comment-16457363 ]
ASF subversion and git services commented on IMPALA-6885:
---------------------------------------------------------
Commit 9537dee2267e5292440568442f4c4e744c982c6e in impala's branch refs/heads/2.x from [~vercego]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=9537dee ]
IMPALA-6885: handle empty s3 dirs in recover_partitions test
Two tests (test_duplicate_partitions, test_support_all_types)
added only directories, which is a no-op on s3. This results
in s3 test failures.
Another test (test_recover_partitions) falsely passed for s3
since its test for a malformed partition name is ambiguous
(did it pass because recovering correctly excluded or because
the directory does not exist, as in the case of s3?).
A recent change fixed the asserts in this test, so these tests
likely were falsely reporting success.
This change bundles directory creation with adding to it a new
file, which is the common case in this test. As a result, the
peculiarity with s3 is not handled via a special case each time
the filesystem is modified for new partitions.
This change also adds an explicit test for empty partition
directories, since the first change leaves this case untested.
Testing:
- tested against a local minicluster and s3
Change-Id: Ic6c74f4f2466b5870322bdf373e8a6a4d1d679f4
Reviewed-on: http://gerrit.cloudera.org:8080/10210
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> test_recover_partitions.py test_support_all_types fails
> -------------------------------------------------------
>
> Key: IMPALA-6885
> URL: https://issues.apache.org/jira/browse/IMPALA-6885
> Project: IMPALA
> Issue Type: Bug
> Components: Frontend
> Affects Versions: Impala 2.12.0
> Reporter: Vuk Ercegovac
> Assignee: Vuk Ercegovac
> Priority: Blocker
> Fix For: Impala 2.13.0
>
>
> {noformat}
> metadata/test_recover_partitions.py:332: in test_support_all_types
> assert len(result.data) == (old_length + 1),\
> E AssertionError: ALTER TABLE test_support_all_types_bc3b11e9.test_recover_partitions RECOVER PARTITIONS failed to handle some data types.
> E assert 2 == (2 + 1)
> E + where 2 = len(['1\t2\t3\t4\t55.55\t6.599999904632568\t7.7\tj \tk\ts\t-1\t1\t2B\tNOT CACHED\tNOT CACHED\tTEXT\tfalse\ts3a://impala...s/a=1/b=2/c=3/d=4/e=55.55/f=6.599999904632568/g=7.7/j=j /k=k/s=s', 'Total\t\t\t\t\t\t\t\t\t\t-1\t1\t2B\t0B\t\t\t\t'])
> E + where ['1\t2\t3\t4\t55.55\t6.599999904632568\t7.7\tj \tk\ts\t-1\t1\t2B\tNOT CACHED\tNOT CACHED\tTEXT\tfalse\ts3a://impala...s/a=1/b=2/c=3/d=4/e=55.55/f=6.599999904632568/g=7.7/j=j /k=k/s=s', 'Total\t\t\t\t\t\t\t\t\t\t-1\t1\t2B\t0B\t\t\t\t'] = <tests.beeswax.impala_beeswax.ImpalaBeeswaxResult object at 0x722d150>.data{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org