You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/11 15:20:46 UTC

[GitHub] [beam] riteshghorse commented on a diff in pull request #17613: [BEAM-14347] Add some benchmarks for generic registration

riteshghorse commented on code in PR #17613:
URL: https://github.com/apache/beam/pull/17613#discussion_r870454048


##########
sdks/go/pkg/beam/register/register_test.go:
##########
@@ -672,3 +675,133 @@ func (fn *PartialCombiner2) AddInput(i int, c CustomType) int {
 func (fn *PartialCombiner2) MergeAccumulators(i1 int, i2 int) int {
 	return i1 + i2
 }
+
+// Foo is a struct with a method for measuring method invocation
+// overhead for StructuralDoFns.
+type Foo struct {
+	A int
+}
+
+// ProcessElement is a method for measuring a baseline of structural dofn overhead.
+func (f *Foo) ProcessElement(b CustomType) int {
+	return f.A + b.val
+}
+
+func MakeMultiEdge(f *graph.DoFn) graph.MultiEdge {
+	return graph.MultiEdge{
+		DoFn: f,
+	}
+}
+
+type callerCustomTypeГint struct {

Review Comment:
   ```suggestion
   type callerCustomTypeГint struct {
   ```
   is this character intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org