You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/05/23 16:40:16 UTC

[GitHub] [pinot] somandal commented on pull request #8758: Improve accuracy of aggregate group-by without order-by queries by adding a query rewriter to convert aggregate group-by only queries to add order-by

somandal commented on PR #8758:
URL: https://github.com/apache/pinot/pull/8758#issuecomment-1134900187

   > do we have some numbers on the impact on performance?
   
   @kishoreg just to clarify, the purpose of this PR is to do the following:
   - Improve the accuracy of group-by only queries by adding a new query rewriter. This query rewriter just converts group-by queries to include order-by.
   - The new query rewriter is disabled by default because of the potential performance penalty. Only customers who need the improved accuracy and are willing to take the performance hit should enable this feature.
   - The query performance for group-by only will be no worse than running the same query with order-by added in.
   
   We can get perf numbers that compare a given query with group-by only and with group-by + order-by and get back to you on the difference. 
   
   Hope this clarifies this change better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org