You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Elek, Marton (JIRA)" <ji...@apache.org> on 2017/11/01 19:05:00 UTC
[jira] [Commented] (RATIS-102) Clean generated sources as part of
the default clean lifecycle
[ https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234584#comment-16234584 ]
Elek, Marton commented on RATIS-102:
------------------------------------
Thx the point. Fair enough: I didn't know about this use case. I will modify the patch just to activate the clean-shade by default. In that case it could be disabled with -P!clean-shade, but yetus could work in RATIS-4, as yetus use 'mvn clean' without specific profiles....
> Clean generated sources as part of the default clean lifecycle
> --------------------------------------------------------------
>
> Key: RATIS-102
> URL: https://issues.apache.org/jira/browse/RATIS-102
> Project: Ratis
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: build
> Attachments: RATIS-102.000.patch
>
>
> RATIS-49 introduced new profiles to cleanup the generated sources/proto files in the shaded artifacts.
> I suggest to make it more easier by binding the additional {clean:clean} plugin calls to the clean phase of the default clean lifecycle instead of trigger them from a separated profile.
> In RATIS-4 I experimenting with build scripts and yetus test-patch script. As the simple {{mvn clean}} command is more common, it would be easier to switch to the simple clean without the profile.
> The cleanup could be done with triggering additional clean plugin execution.
> To test:
> {code}
> git checkout 52c4b64
> mvn clean package -DskipTests
> git checkout master
> mvn clean package -DskipTests
> {code}
> Without the patch the second only works with -Pclean-shade, with the proposed patch it works without activating any additional profile
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)