[GitHub] [kafka] chia7712 commented on a change in pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #8981:
URL: https://github.com/apache/kafka/pull/8981#discussion_r450601160



##########
File path: tests/kafkatest/tests/core/transactions_test.py
##########
@@ -53,7 +53,11 @@ def __init__(self, test_context):
         self.zk = ZookeeperService(test_context, num_nodes=1)
         self.kafka = KafkaService(test_context,
                                   num_nodes=self.num_brokers,
-                                  zk=self.zk)
+                                  zk=self.zk,
+                                  # Reducing timeout of transaction can quickly cleanup the unstable offsets.
+                                  # IN hard_bounce mode, transaction is broke ungracefully. Hence, it produces unstable
+                                  # offsets which obstructs TransactionalMessageCopier from receiving position of group.
+                                  transaction_timeout=2000)

Review comment:
       @junrao thanks for your great reviews!!! This approach is not correct. The "number" which should be reduced is "transaction timeout" rather than "cleanup interval".
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org