You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/02/26 13:05:07 UTC

[GitHub] [maven] rfscholte commented on a change in pull request #451: [MNG-7107] relax profile id validation, different from coordinate id

rfscholte commented on a change in pull request #451:
URL: https://github.com/apache/maven/pull/451#discussion_r583624081



##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -916,7 +958,7 @@ private boolean isValidIdWithWildCards( String id )
 
     private boolean isValidIdWithWildCardCharacter( char c )

Review comment:
       This methodname is now weird: we're going from an general `isValidIdWithWildCardCharacter` to a more explicit `isValidCoordinateIdCharacter`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org