You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/28 02:18:41 UTC
[GitHub] [incubator-celeborn] boneanxs commented on a diff in pull request #1119: [CELEBORN-61][CELEBORN-62][FOLLOW_UP] Fix some issues for slow start
boneanxs commented on code in PR #1119:
URL: https://github.com/apache/incubator-celeborn/pull/1119#discussion_r1058017054
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -1268,29 +1276,37 @@ public void setupMetaServiceRef(RpcEndpointRef endpointRef) {
}
private void slowStart() {
- synchronized (currentMaxReqsInFlight) {
- if (currentMaxReqsInFlight > maxInFlight) {
- // Congestion avoidance
- congestionAvoidanceFlag++;
- if (congestionAvoidanceFlag >= currentMaxReqsInFlight) {
- currentMaxReqsInFlight++;
- congestionAvoidanceFlag = 0;
+ if (conf.pushDataSlowStart()) {
Review Comment:
As currentMaxReqsInFlight is already atomicInteger, maybe use atomic to update its value is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org