You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/25 19:43:25 UTC
[kudu-CR] [test] Deflake TestKuduScanner.testDiffScan
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13123
Change subject: [test] Deflake TestKuduScanner.testDiffScan
......................................................................
[test] Deflake TestKuduScanner.testDiffScan
In the case there were 0 operations the applyOperations
method would fail. This fixes that by returning early.
Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/13123/1
--
To view, visit http://gerrit.cloudera.org:8080/13123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [test] Deflake TestKuduScanner.testDiffScan
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13123 )
Change subject: [test] Deflake TestKuduScanner.testDiffScan
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Apr 2019 20:38:15 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Deflake TestKuduScanner.testDiffScan
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13123
to look at the new patch set (#2).
Change subject: [test] Deflake TestKuduScanner.testDiffScan
......................................................................
[test] Deflake TestKuduScanner.testDiffScan
In the case there were 0 operations the applyOperations
method would fail. This fixes that by returning early.
Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/13123/2
--
To view, visit http://gerrit.cloudera.org:8080/13123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Deflake TestKuduScanner.testDiffScan
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13123 )
Change subject: [test] Deflake TestKuduScanner.testDiffScan
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13123/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/13123/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@290
PS1, Line 290: if(operations.isEmpty()) {
if (
http://gerrit.cloudera.org:8080/#/c/13123/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@295
PS1, Line 295: if (random.nextBoolean()) {
: LOG.info("Waiting for a flush at the start of applyOperations");
: Thread.sleep(DIFF_FLUSH_SEC + 1);
: }
Do we still want to do this if there are no operations?
--
To view, visit http://gerrit.cloudera.org:8080/13123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Apr 2019 19:49:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Deflake TestKuduScanner.testDiffScan
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13123 )
Change subject: [test] Deflake TestKuduScanner.testDiffScan
......................................................................
[test] Deflake TestKuduScanner.testDiffScan
In the case there were 0 operations the applyOperations
method would fail. This fixes that by returning early.
Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
Reviewed-on: http://gerrit.cloudera.org:8080/13123
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icde518875e568545ffab4652e510802a5ebcecb7
Gerrit-Change-Number: 13123
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)