You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org> on 2024/02/05 10:37:43 UTC

[PR] Fixed Ratis query not retrying when DataNode restarts [iotdb]

OneSizeFitsQuorum opened a new pull request, #12029:
URL: https://github.com/apache/iotdb/pull/12029

   ![img_v3_027m_4aefc1d2-8b82-464c-aaf9-20fb04a502cg](https://github.com/apache/iotdb/assets/32640567/e7eb09b1-4ef9-4834-9b4f-29b96be54840)
   
   Retry the request for ServerNotReadyException


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed Ratis query not retrying when DataNode restarts [iotdb]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12029:
URL: https://github.com/apache/iotdb/pull/12029#issuecomment-1926855451

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12029) **Quality Gate failed**  
   Failed conditions
   
   [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12029&metric=new_coverage&view=list) (required ≥ 80%)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12029)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed Ratis query not retrying when DataNode restarts [iotdb]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12029:
URL: https://github.com/apache/iotdb/pull/12029#issuecomment-1926709297

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12029) **Quality Gate failed**  
   Failed conditions
   
   [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12029&metric=new_coverage&view=list) (required ≥ 80%)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12029)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed Ratis query not retrying when DataNode restarts [iotdb]

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #12029:
URL: https://github.com/apache/iotdb/pull/12029


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed Ratis query not retrying when DataNode restarts [iotdb]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12029:
URL: https://github.com/apache/iotdb/pull/12029#issuecomment-1926934550

   ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `33 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`6943524`)](https://app.codecov.io/gh/apache/iotdb/commit/6943524b000217bf6d4678b51097f93cfedad8f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.15% compared to head [(`b6e18e7`)](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.15%.
   > Report is 3 commits behind head on master.
   
   | [Files](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...a/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L2pkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2pkYmMvSW9UREJEYXRhYmFzZU1ldGFkYXRhLmphdmE=) | 11.11% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L2pkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2pkYmMvSW9UREJKREJDUmVzdWx0U2V0LmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...tatemachine/dataregion/DataRegionStateMachine.java](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvY29uc2Vuc3VzL3N0YXRlbWFjaGluZS9kYXRhcmVnaW9uL0RhdGFSZWdpb25TdGF0ZU1hY2hpbmUuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...gine/execution/executor/RegionExecutionResult.java](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL2V4ZWN1dG9yL1JlZ2lvbkV4ZWN1dGlvblJlc3VsdC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...plan/scheduler/FragmentInstanceDispatcherImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9zY2hlZHVsZXIvRnJhZ21lbnRJbnN0YW5jZURpc3BhdGNoZXJJbXBsLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ol/thrift/impl/DataNodeInternalRPCServiceImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcHJvdG9jb2wvdGhyaWZ0L2ltcGwvRGF0YU5vZGVJbnRlcm5hbFJQQ1NlcnZpY2VJbXBsLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...yengine/execution/executor/RegionReadExecutor.java](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL2V4ZWN1dG9yL1JlZ2lvblJlYWRFeGVjdXRvci5qYXZh) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12029      +/-   ##
   ============================================
   - Coverage     49.15%   49.15%   -0.01%     
   - Complexity    26156    26160       +4     
   ============================================
     Files          2943     2943              
     Lines        184519   184552      +33     
     Branches      22142    22152      +10     
   ============================================
   + Hits          90708    90721      +13     
   - Misses        93811    93831      +20     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12029?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org