You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by r7raul1984 <gi...@git.apache.org> on 2017/01/19 05:25:21 UTC
[GitHub] eagle pull request #783: [EAGLE-872] Transform counter metric to rate metric
GitHub user r7raul1984 opened a pull request:
https://github.com/apache/eagle/pull/783
[EAGLE-872] Transform counter metric to rate metric
- Add transform bolt using counterToRateFunction in HadoopMetricMonitorApp's storm topology.
https://issues.apache.org/jira/browse/EAGLE-872
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1haodian/eagle EAGLE-872
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #783
----
commit d886628fced8fa352a3032613349bbda6c74fd90
Author: r7raul1984 <ta...@yhd.com>
Date: 2017-01-19T05:23:41Z
[EAGLE-872] Transform counter metric to rate metric
- Add transform bolt using counterToRateFunction in HadoopMetricMonitorApp's storm topology.
https://issues.apache.org/jira/browse/EAGLE-872
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #783: [EAGLE-872] Transform counter metric to rate metric
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/eagle/pull/783
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/783
@r7raul1984 how do you think expose `CountMetricFilter` as a parameter to choose which metric to convert as `count`, and the current hard-code behavior should only be some kind of default implementation?
@FunctionInterface
interface CountMetricFilter extends Function<Map, Boolean>
DefaultCountMetricFilter = (metric) -> metric["metric"].endsWith("*.count")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 commented on the issue:
https://github.com/apache/eagle/pull/783
@haoch Thanks. I will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/783
@r7raul1984 would you convert *all* counter metric to rate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/783
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 commented on the issue:
https://github.com/apache/eagle/pull/783
@haoch If metric name endswith "count" , it will be converted to rate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---