You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2008/07/29 20:15:31 UTC
[jira] Resolved: (SOLR-256) Stats via JMX
[ https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-256.
----------------------------------------
Resolution: Fixed
Committed revision 680795.
> Stats via JMX
> -------------
>
> Key: SOLR-256
> URL: https://issues.apache.org/jira/browse/SOLR-256
> Project: Solr
> Issue Type: New Feature
> Components: search, update
> Reporter: Sharad Agarwal
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: jmx.patch, jmx.patch, jmx.patch, jmx.patch, jmx.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch
>
>
> This patch adds JMX capability to get statistics from all the SolrInfoMBean.
> The implementation is done such a way to minimize code changes.
> In SolrInfoRegistry, I have overloaded Map's put and remove methods to register and unregister SolrInfoMBean in MBeanServer.
> Later on, I am planning to use register and unregister methods in SolrInfoRegistry and removing getRegistry() method (Hiding the map instance to other classes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (SOLR-256) Stats via JMX
Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
On Tue, Aug 5, 2008 at 11:24 PM, Chris Hostetter
<ho...@fucit.org>wrote:
>
> : On the topic of Jmx, is there anybody for whom the TestJmxIntegration
> fails
> : on their local box? It doesn't fail for me but it does fail on the hudson
> : box. I've been flying blind trying to fix it but haven't had much luck
> yet.
>
> If i'm reading the Hudson output correctly, the tests started passing in
> #517 -- i thought one of your commits was to fix it :) -- but then there
> wa a problem building the javadocs...
>
> http://hudson.zones.apache.org/hudson/job/Solr-trunk/517/console
>
> ...although, i'm really not sure why it hasn't tried to rebuild again yet
> ... that was over 24 hours ago. I just kicked off one manually, let's see
> what happens.
>
>
Hmm...yeah it passes now but I swear I didn't do anything :)
However, the JettyWebappTest has failed. Probably a random error, should get
fixed in the next build.
--
Regards,
Shalin Shekhar Mangar.
Re: [jira] Resolved: (SOLR-256) Stats via JMX
Posted by Chris Hostetter <ho...@fucit.org>.
: On the topic of Jmx, is there anybody for whom the TestJmxIntegration fails
: on their local box? It doesn't fail for me but it does fail on the hudson
: box. I've been flying blind trying to fix it but haven't had much luck yet.
If i'm reading the Hudson output correctly, the tests started passing in
#517 -- i thought one of your commits was to fix it :) -- but then there
wa a problem building the javadocs...
http://hudson.zones.apache.org/hudson/job/Solr-trunk/517/console
...although, i'm really not sure why it hasn't tried to rebuild again yet
... that was over 24 hours ago. I just kicked off one manually, let's see
what happens.
-Hoss
Re: [jira] Resolved: (SOLR-256) Stats via JMX
Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
To avoid confusion, I had added a searcherName field in the exposed
statistics which should be the same name as the other searcher you are
seeing.
On the topic of Jmx, is there anybody for whom the TestJmxIntegration fails
on their local box? It doesn't fail for me but it does fail on the hudson
box. I've been flying blind trying to fix it but haven't had much luck yet.
On Tue, Aug 5, 2008 at 8:34 AM, Chris Hostetter <ho...@fucit.org>wrote:
>
> : Yes it is a feature :)
>
> : Refer to Hoss's comment quoted below:
>
> It's not something I'd really given a lot of thought to, if people find it
> confusing then by all means we can remove it.
>
> : > After this committed, I can see two searchers registered at admin GUI,
> : > due to the following lines on SolrIndexSearcher:
>
> : > Is this intentional?
>
>
>
> -Hoss
>
>
--
Regards,
Shalin Shekhar Mangar.
Re: [jira] Resolved: (SOLR-256) Stats via JMX
Posted by Chris Hostetter <ho...@fucit.org>.
: Yes it is a feature :)
: Refer to Hoss's comment quoted below:
It's not something I'd really given a lot of thought to, if people find it
confusing then by all means we can remove it.
: > After this committed, I can see two searchers registered at admin GUI,
: > due to the following lines on SolrIndexSearcher:
: > Is this intentional?
-Hoss
Re: [jira] Resolved: (SOLR-256) Stats via JMX
Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
Yes it is a feature :)
Refer to Hoss's comment quoted below:
"is there any reason not to have the searcher's add/remove themselves using
their true name on register()/close() *and* have register() call
put("searcher", this) like you have it now? ... that way you'd get the
benefits you mentioned before (continuous monitoring of the current
searcher) but you could also get information about how many "live" searchers
there currently are, and what their stats look like (so you could, for
example, notice when there is a really old Searcher hanging around for some
inexplicable reason, probably a bug.)"
https://issues.apache.org/jira/browse/SOLR-256?focusedCommentId=12617632#action_12617632
On Sat, Aug 2, 2008 at 3:31 PM, Koji Sekiguchi <ko...@r.email.ne.jp> wrote:
> After this committed, I can see two searchers registered at admin GUI,
> due to the following lines on SolrIndexSearcher:
>
> @@ -171,6 +169,9 @@
> /** Register sub-objects such as caches
> */
> public void register() {
> + // register self
> + core.getInfoRegistry().put("searcher", this);
> + core.getInfoRegistry().put(name, this);
> for (SolrCache cache : cacheList) {
> cache.setState(SolrCache.State.LIVE);
> core.getInfoRegistry().put(cache.name(), cache);
>
> Is this intentional?
>
> Koji
>
>
>
> Shalin Shekhar Mangar (JIRA) wrote:
>
>> [
>> https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> Shalin Shekhar Mangar resolved SOLR-256.
>> ----------------------------------------
>>
>> Resolution: Fixed
>>
>> Committed revision 680795.
>>
>>
>>
>>> Stats via JMX
>>> -------------
>>>
>>> Key: SOLR-256
>>> URL: https://issues.apache.org/jira/browse/SOLR-256
>>> Project: Solr
>>> Issue Type: New Feature
>>> Components: search, update
>>> Reporter: Sharad Agarwal
>>> Assignee: Shalin Shekhar Mangar
>>> Priority: Minor
>>> Fix For: 1.3
>>>
>>> Attachments: jmx.patch, jmx.patch, jmx.patch, jmx.patch,
>>> jmx.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch,
>>> SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch,
>>> SOLR-256.patch, SOLR-256.patch
>>>
>>>
>>> This patch adds JMX capability to get statistics from all the
>>> SolrInfoMBean.
>>> The implementation is done such a way to minimize code changes. In
>>> SolrInfoRegistry, I have overloaded Map's put and remove methods to
>>> register and unregister SolrInfoMBean in MBeanServer. Later on, I am
>>> planning to use register and unregister methods in SolrInfoRegistry and
>>> removing getRegistry() method (Hiding the map instance to other classes)
>>>
>>>
>>
>>
>>
>
>
--
Regards,
Shalin Shekhar Mangar.
Re: [jira] Resolved: (SOLR-256) Stats via JMX
Posted by Koji Sekiguchi <ko...@r.email.ne.jp>.
After this committed, I can see two searchers registered at admin GUI,
due to the following lines on SolrIndexSearcher:
@@ -171,6 +169,9 @@
/** Register sub-objects such as caches
*/
public void register() {
+ // register self
+ core.getInfoRegistry().put("searcher", this);
+ core.getInfoRegistry().put(name, this);
for (SolrCache cache : cacheList) {
cache.setState(SolrCache.State.LIVE);
core.getInfoRegistry().put(cache.name(), cache);
Is this intentional?
Koji
Shalin Shekhar Mangar (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Shalin Shekhar Mangar resolved SOLR-256.
> ----------------------------------------
>
> Resolution: Fixed
>
> Committed revision 680795.
>
>
>> Stats via JMX
>> -------------
>>
>> Key: SOLR-256
>> URL: https://issues.apache.org/jira/browse/SOLR-256
>> Project: Solr
>> Issue Type: New Feature
>> Components: search, update
>> Reporter: Sharad Agarwal
>> Assignee: Shalin Shekhar Mangar
>> Priority: Minor
>> Fix For: 1.3
>>
>> Attachments: jmx.patch, jmx.patch, jmx.patch, jmx.patch, jmx.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch
>>
>>
>> This patch adds JMX capability to get statistics from all the SolrInfoMBean.
>> The implementation is done such a way to minimize code changes.
>> In SolrInfoRegistry, I have overloaded Map's put and remove methods to register and unregister SolrInfoMBean in MBeanServer.
>> Later on, I am planning to use register and unregister methods in SolrInfoRegistry and removing getRegistry() method (Hiding the map instance to other classes)
>>
>
>