You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by phymbert <gi...@git.apache.org> on 2017/06/22 15:35:41 UTC

[GitHub] logging-log4j2 pull request #84: [LOG4J2-1950] Fix docker build with jdk9 re...

GitHub user phymbert opened a pull request:

    https://github.com/apache/logging-log4j2/pull/84

    [LOG4J2-1950] Fix docker build with jdk9 requirements

    Revert docker image base from openjdk:7-alpine to openjdk:7-jdk (debian) since yet alpine does not include jdk9.
    Install jdk9 and specify toolchains file in the mvn build
    
    Signed-off-by: phymbert <pi...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phymbert/logging-log4j2 LOG4J2-1950

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit 516e2ab45ec01021098bfef8f55d7748f16c018b
Author: phymbert <pi...@gmail.com>
Date:   2017-06-22T15:33:32Z

    [LOG4J2-1950] Fix docker build with jdk9 requirements
    
    Signed-off-by: phymbert <pi...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 issue #84: [LOG4J2-1950] Fix docker build with jdk9 requireme...

Posted by phymbert <gi...@git.apache.org>.
Github user phymbert commented on the issue:

    https://github.com/apache/logging-log4j2/pull/84
  
    I tried to minimise changes, I would prefer to install mvn as a package rather to freeze the version. I may do it tom if you are fine with it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 issue #84: [LOG4J2-1950] Fix docker build with jdk9 requireme...

Posted by phymbert <gi...@git.apache.org>.
Github user phymbert commented on the issue:

    https://github.com/apache/logging-log4j2/pull/84
  
    Updated to 3.5.0, please check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 issue #84: [LOG4J2-1950] Fix docker build with jdk9 requireme...

Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:

    https://github.com/apache/logging-log4j2/pull/84
  
    Can certainly be updated for that since it's not installed via apt-get.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 issue #84: [LOG4J2-1950] Fix docker build with jdk9 requireme...

Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:

    https://github.com/apache/logging-log4j2/pull/84
  
    Curious, why not Maven 3.5.0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #84: [LOG4J2-1950] Fix docker build with jdk9 re...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/logging-log4j2/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---