You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2025/07/26 15:05:05 UTC
[PR] fix: patch futures buffer_by_ordered [opendal]
tisonkun opened a new pull request, #6442:
URL: https://github.com/apache/opendal/pull/6442
See https://github.com/rust-lang/futures-rs/pull/2962
I'm afraid that futures-rs won't release recently, so try to bring the patch here.
What do you think? @Xuanwo @andylokandy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: patch futures buffer_by_ordered [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6442:
URL: https://github.com/apache/opendal/pull/6442#issuecomment-3122099944
The usage example could be found at: https://github.com/apache/opendal/blob/8de30cc764c3724db33907ca17e02648530061ed/core/src/raw/oio/write/multipart_write.rs#L229-L237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: patch futures buffer concurrent [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6442:
URL: https://github.com/apache/opendal/pull/6442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: patch futures buffer_by_ordered [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #6442:
URL: https://github.com/apache/opendal/pull/6442#issuecomment-3122094010
@Xuanwo do you mean `opendal::types::execute::Executor`? Let me see ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: patch futures buffer_by_ordered [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #6442:
URL: https://github.com/apache/opendal/pull/6442#discussion_r2233027932
##########
core/src/types/read/reader.rs:
##########
@@ -147,8 +147,8 @@ impl Reader {
let merged_ranges = self.merge_ranges(ranges.clone());
let merged_bufs: Vec<_> =
- stream::iter(merged_ranges.clone().into_iter().map(|v| self.read(v)))
- .buffered(self.ctx.options().concurrent())
+ stream::iter(merged_ranges.clone().into_iter().map(|v| (self.read(v), 1)))
Review Comment:
The second value is `size`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org