You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/16 11:16:01 UTC

[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #5752: arch: cxd56xx: Fix critical section in serial transmission

Ouss4 edited a comment on pull request #5752:
URL: https://github.com/apache/incubator-nuttx/pull/5752#issuecomment-1069012395


   Yes, I remember the deadlock, this is why we unlock the spinlock before calling `uart_xmitchars`:
   https://github.com/apache/incubator-nuttx/blob/bbf12f3b1b2a8ba272a21db20c351ad7e41d3ecd/arch/xtensa/src/esp32/esp32_serial.c#L1801-L1802
   `uart_xmitchars` will end up calling `up_txint` recursively, so without that it will deadlock.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org