You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by brian Foster <ho...@juno.com> on 2014/05/18 21:37:11 UTC

Review Request 21615: Multi-Thread CAS-Crawler

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21615/
-----------------------------------------------------------

Review request for oodt, Chris Mattmann and Paul Ramirez.


Bugs: OODT-684
    https://issues.apache.org/jira/browse/OODT-684


Repository: oodt


Description
-------

Multi-Thread CAS-Crawler


Diffs
-----

  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 1590893 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawlerWorkerPool.java PRE-CREATION 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/config/ProductCrawlerBean.java 1590893 
  trunk/crawler/src/main/resources/cmd-line-options.xml 1590893 

Diff: https://reviews.apache.org/r/21615/diff/


Testing
-------


Thanks,

brian Foster

Re: Review Request 21615: Multi-Thread CAS-Crawler

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21615/#review43329
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Mattmann


On May 18, 2014, 7:37 p.m., brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21615/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 7:37 p.m.)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Bugs: OODT-684
>     https://issues.apache.org/jira/browse/OODT-684
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> Multi-Thread CAS-Crawler
> 
> 
> Diffs
> -----
> 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 1590893 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawlerWorkerPool.java PRE-CREATION 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/config/ProductCrawlerBean.java 1590893 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1590893 
> 
> Diff: https://reviews.apache.org/r/21615/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> brian Foster
> 
>

Re: Review Request 21615: Multi-Thread CAS-Crawler

Posted by brian Foster <ho...@juno.com>.

> On May 18, 2014, 8:08 p.m., Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java, line 26
> > <https://reviews.apache.org/r/21615/diff/1/?file=584008#file584008line26>
> >
> >     Hey buddy was this not used? Why this removal?

ya not used... ProductCrawler is of type CrawlerBean which is of type CoreMetKeys so it already has access to CoreMetKeys values.


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21615/#review43328
-----------------------------------------------------------


On May 18, 2014, 7:37 p.m., brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21615/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 7:37 p.m.)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Bugs: OODT-684
>     https://issues.apache.org/jira/browse/OODT-684
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> Multi-Thread CAS-Crawler
> 
> 
> Diffs
> -----
> 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 1590893 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawlerWorkerPool.java PRE-CREATION 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/config/ProductCrawlerBean.java 1590893 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1590893 
> 
> Diff: https://reviews.apache.org/r/21615/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> brian Foster
> 
>

Re: Review Request 21615: Multi-Thread CAS-Crawler

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21615/#review43328
-----------------------------------------------------------



trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java
<https://reviews.apache.org/r/21615/#comment77428>

    Hey buddy was this not used? Why this removal?


- Chris Mattmann


On May 18, 2014, 7:37 p.m., brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21615/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 7:37 p.m.)
> 
> 
> Review request for oodt, Chris Mattmann and Paul Ramirez.
> 
> 
> Bugs: OODT-684
>     https://issues.apache.org/jira/browse/OODT-684
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> Multi-Thread CAS-Crawler
> 
> 
> Diffs
> -----
> 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 1590893 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawlerWorkerPool.java PRE-CREATION 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/config/ProductCrawlerBean.java 1590893 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1590893 
> 
> Diff: https://reviews.apache.org/r/21615/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> brian Foster
> 
>