[GitHub] [hbase] saintstack commented on a change in pull request #3105: HBASE-25713 Make an hbase-wal module

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #3105:
URL: https://github.com/apache/hbase/pull/3105#discussion_r605012266



##########
File path: hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContextImpl.java
##########
@@ -87,19 +89,5 @@ public boolean shouldBypass() {
     return Optional.ofNullable(caller);
   }
 
-  /**
-   * Instantiates a new ObserverContext instance if the passed reference is <code>null</code> and
-   * sets the environment in the new or existing instance. This allows deferring the instantiation
-   * of a ObserverContext until it is actually needed.
-   * @param <E> The environment type for the context
-   * @param env The coprocessor environment to set
-   * @return An instance of <code>ObserverContext</code> with the environment set
-   */
-  @Deprecated

Review comment:
       Sorry for confusion @virajjasani ... This exploratory work is against branch-2 but target is master branch. We cannot remove these methods as you suggest in branch-2 but we could in master. Odd is that these methods are deprecated but without an alternative.... I need to provide something.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org