You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/01/14 10:30:31 UTC

[GitHub] [incubator-iotdb] sunjincheng121 opened a new pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format().

sunjincheng121 opened a new pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format().
URL: https://github.com/apache/incubator-iotdb/pull/739
 
 
   I would like to make the change simple which I mentioned here: https://github.com/apache/incubator-iotdb/pull/726#discussion_r365042005
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-iotdb] JulianFeinauer merged pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format().

Posted by GitBox <gi...@apache.org>.
JulianFeinauer merged pull request #739: [hotfix] Simplify the setting of Locale defaults for String.format().
URL: https://github.com/apache/incubator-iotdb/pull/739
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-iotdb] sunjincheng121 commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().

Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().
URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574533265
 
 
   Thanks for your review @JulianFeinauer !
   
   At the beginning I really wanted to restore the locale in the tearDown () method,  but in that way, we should keep the original `Locale` info which is make the change a little bit complex, furthermore, currently, we always need `Locale.ENGLISH` in all of testCase, so, I think the change is fine. 
   
   But I am fine, if you really want to do it, which make the code looks pretty complete.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-iotdb] JulianFeinauer commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().

Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().
URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574533653
 
 
   @sunjincheng121 I agree with your arguments and do not insist on em and as your change is, as you say "somewhat" idempotent we can leave it like that. 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-iotdb] sunjincheng121 edited a comment on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().

Posted by GitBox <gi...@apache.org>.
sunjincheng121 edited a comment on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().
URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574455347
 
 
   @jixuan1989 @JulianFeinauer Does this PR make sense to you? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-iotdb] sunjincheng121 commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().

Posted by GitBox <gi...@apache.org>.
sunjincheng121 commented on issue #739: [hotfix] Simplify the setting of Locale defaults for String.format().
URL: https://github.com/apache/incubator-iotdb/pull/739#issuecomment-574455347
 
 
   @jixuan1989 @JulianFeinauer It's this PR make sense to you? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services