You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/13 02:49:47 UTC

[GitHub] [pulsar] labuladong opened a new pull request, #17601: [improve][doc] improve pulsar I/O document

labuladong opened a new pull request, #17601:
URL: https://github.com/apache/pulsar/pull/17601

   
   
   <!-- Either this PR fixes an issue, -->
   
   Fixes #17555
   
   
   ### Motivation
   
   <!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
   
   At first, I'd like to fix the broken links in `Pulsar I/O` chapter. But I found that not only this chapter has this problem, so I open #17599 for further discussion.
   
   In this PR, I replace the docker introduction with a reference link and improve some code snippets.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] labuladong commented on a diff in pull request #17601: [improve][doc] improve pulsar I/O document

Posted by GitBox <gi...@apache.org>.
labuladong commented on code in PR #17601:
URL: https://github.com/apache/pulsar/pull/17601#discussion_r970196267


##########
site2/docs/io-quickstart.md:
##########
@@ -473,18 +460,22 @@ This example uses the PostgreSQL 12 docker image to start a single-node PostgreS
    2020-05-11 20:09:24.533 UTC [1] LOG:  database system is ready to accept connections
    ```
 
-4. Access to PostgreSQL.
+4. Access to PostgreSQL container.
 
    ```bash
    docker exec -it pulsar-postgres /bin/bash
    ```
 
-5. Create a PostgreSQL table _pulsar_postgres_jdbc_sink_.
+5. Login PostgreSQL with default username and password:
 
    ```bash
    psql -U postgres postgres
+   ```
+
+6. Input following commands to create `pulsar_postgres_jdbc_sink` table:

Review Comment:
   Got it, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun merged pull request #17601: [improve][doc] improve pulsar I/O document

Posted by GitBox <gi...@apache.org>.
momo-jun merged PR #17601:
URL: https://github.com/apache/pulsar/pull/17601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #17601: [improve][doc] improve pulsar I/O document

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17601:
URL: https://github.com/apache/pulsar/pull/17601#discussion_r969595681


##########
site2/docs/io-quickstart.md:
##########
@@ -473,18 +460,22 @@ This example uses the PostgreSQL 12 docker image to start a single-node PostgreS
    2020-05-11 20:09:24.533 UTC [1] LOG:  database system is ready to accept connections
    ```
 
-4. Access to PostgreSQL.
+4. Access to PostgreSQL container.
 
    ```bash
    docker exec -it pulsar-postgres /bin/bash
    ```
 
-5. Create a PostgreSQL table _pulsar_postgres_jdbc_sink_.
+5. Login PostgreSQL with default username and password:

Review Comment:
   ```suggestion
   5. Log in to PostgreSQL with the default username and password:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] labuladong commented on pull request #17601: [improve][doc] improve pulsar I/O document

Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #17601:
URL: https://github.com/apache/pulsar/pull/17601#issuecomment-1245045403

   cc @Anonymitaet @momo-jun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] labuladong commented on pull request #17601: [improve][doc] improve pulsar I/O document

Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #17601:
URL: https://github.com/apache/pulsar/pull/17601#issuecomment-1246098979

   Thanks for your review, changes were addressed. @Anonymitaet @momo-jun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17601: [improve][doc] improve pulsar I/O document

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17601:
URL: https://github.com/apache/pulsar/pull/17601#discussion_r969348002


##########
site2/docs/io-quickstart.md:
##########
@@ -473,18 +460,22 @@ This example uses the PostgreSQL 12 docker image to start a single-node PostgreS
    2020-05-11 20:09:24.533 UTC [1] LOG:  database system is ready to accept connections
    ```
 
-4. Access to PostgreSQL.
+4. Access to PostgreSQL container.
 
    ```bash
    docker exec -it pulsar-postgres /bin/bash
    ```
 
-5. Create a PostgreSQL table _pulsar_postgres_jdbc_sink_.
+5. Login PostgreSQL with default username and password:
 
    ```bash
    psql -U postgres postgres
+   ```
+
+6. Input following commands to create `pulsar_postgres_jdbc_sink` table:

Review Comment:
   ```suggestion
   6. Create a `pulsar_postgres_jdbc_sink` table using the following command:
   ```
   
   1. Show "action / purpose" first.
   2. Below is one command, so remove "s" for "command". 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org