You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2018/08/10 21:50:22 UTC
[Impala-ASF-CR] IMPALA-3825: Distribute Runtime Filtering Aggregation
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11055 )
Change subject: IMPALA-3825: Distribute Runtime Filtering Aggregation
......................................................................
Patch Set 4:
(1 comment)
May help to add a unit test to exercise retrying logic when sending a filter to the aggregator.
http://gerrit.cloudera.org:8080/#/c/11055/4/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:
http://gerrit.cloudera.org:8080/#/c/11055/4/common/thrift/ImpalaInternalService.thrift@878
PS4, Line 878: optional map<Types.TNetworkAddress, set<i32>> backend_list
May help to add a comment on what this is for.
--
To view, visit http://gerrit.cloudera.org:8080/11055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94e183a0353fc46f8d3eccae029d2d52c5cdc40c
Gerrit-Change-Number: 11055
Gerrit-PatchSet: 4
Gerrit-Owner: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Aug 2018 21:50:22 +0000
Gerrit-HasComments: Yes