You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mingyen066 (via GitHub)" <gi...@apache.org> on 2025/11/21 16:17:21 UTC

[PR] KAFKA-12392 Deprecate '--max-partition-memory-bytes' option in ConsoleProducer [kafka]

mingyen066 opened a new pull request, #20952:
URL: https://github.com/apache/kafka/pull/20952

   This patch implements [KIP-1231](https://cwiki.apache.org/confluence/x/xQl3Fw) where we replace --max-partition-memory-bytes
   with existing --batch-size. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-12392: Deprecate '--max-partition-memory-bytes' option in ConsoleProducer [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #20952:
URL: https://github.com/apache/kafka/pull/20952#discussion_r2550562379


##########
tools/src/main/java/org/apache/kafka/tools/ConsoleProducer.java:
##########
@@ -335,6 +341,10 @@ void checkArgs() {
                 readerPropertyOpt = propertyOpt;
             }
 
+            if (options.has(maxPartitionMemoryBytesOpt)) {
+                System.out.println("Warning: --max-partition-memory-bytes is deprecated and will be removed in a future version. Use --batch-size instead.");

Review Comment:
   Could you use `5.0` instead of `major`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-12392: Deprecate '--max-partition-memory-bytes' option in ConsoleProducer [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #20952:
URL: https://github.com/apache/kafka/pull/20952


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-12392: Deprecate '--max-partition-memory-bytes' option in ConsoleProducer [kafka]

Posted by "mingyen066 (via GitHub)" <gi...@apache.org>.
mingyen066 commented on code in PR #20952:
URL: https://github.com/apache/kafka/pull/20952#discussion_r2551593799


##########
tools/src/main/java/org/apache/kafka/tools/ConsoleProducer.java:
##########
@@ -335,6 +341,10 @@ void checkArgs() {
                 readerPropertyOpt = propertyOpt;
             }
 
+            if (options.has(maxPartitionMemoryBytesOpt)) {
+                System.out.println("Warning: --max-partition-memory-bytes is deprecated and will be removed in a future version. Use --batch-size instead.");

Review Comment:
   Sure, also refine description to indicate removal in Apache Kafka 5.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org