You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ponymail.apache.org by GitBox <gi...@apache.org> on 2021/06/06 10:07:26 UTC

[GitHub] [incubator-ponymail-foal] sebbASF opened a new issue #40: Is domain required here?

sebbASF opened a new issue #40:
URL: https://github.com/apache/incubator-ponymail-foal/issues/40


   https://github.com/apache/incubator-ponymail-foal/blob/52fdd4b6f373c22a43932b81e46e6b84aabecdb1/server/openapi.yaml#L69
   
   Is the domain required?
   
   AFAICT, if it is not provided, then list is assumed to contain listname@fqdn [1]
   
   Not sure if is a good idea, but if it is to be kept, it needs to be fully documented.
   
   [1] https://github.com/apache/incubator-ponymail-foal/blob/52fdd4b6f373c22a43932b81e46e6b84aabecdb1/server/plugins/defuzzer.py#L83


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] Humbedooh closed issue #40: Is domain required here?

Posted by GitBox <gi...@apache.org>.
Humbedooh closed issue #40:
URL: https://github.com/apache/incubator-ponymail-foal/issues/40


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] Humbedooh commented on issue #40: Is domain required here?

Posted by GitBox <gi...@apache.org>.
Humbedooh commented on issue #40:
URL: https://github.com/apache/incubator-ponymail-foal/issues/40#issuecomment-855440748


   I think we might have to reintroduce it, as atom.lua (atom.py still needs to be made) also expects it in that format.
   I think it's easier to handle in the defuzzer plugin instead of introducing a workaround in all three endpoints.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #40: Is domain required here?

Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #40:
URL: https://github.com/apache/incubator-ponymail-foal/issues/40#issuecomment-855374179


   All the instances of 'list=' that I can find are accompanied by 'domain=', so I suspect not.
   
   +1 to insist on domain


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] Humbedooh commented on issue #40: Is domain required here?

Posted by GitBox <gi...@apache.org>.
Humbedooh commented on issue #40:
URL: https://github.com/apache/incubator-ponymail-foal/issues/40#issuecomment-855373547


   the `elif` following it is prone to break if list does not contain  a `@fqdn` element...I wonder if that behavior is at all used, or if we should just remove it and always require the `domain` keyword, as the API suggests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #40: Is domain required here?

Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #40:
URL: https://github.com/apache/incubator-ponymail-foal/issues/40#issuecomment-855457362


   I am suggesting adding it back to defuzzer as a separate option to treat list as a lid (ignoring domain). Otherwise proceed as now.
   
   Then mbox and atom will need to specify the option when calling defuzzer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] sebbASF commented on issue #40: Is domain required here?

Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #40:
URL: https://github.com/apache/incubator-ponymail-foal/issues/40#issuecomment-855426791


   I think I now know why this was done: mbox.lua needs the list parameter to contain a list-id (name@fqdn or name.fqdn)
   
   So although the code is not needed for Foal, it is needed for backwards compatibility.
   Maybe add a parsing option to use list instead of list+domain, and get mbox.py to provide this when calling defuzzer.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org