[GitHub] [kafka] jolshan commented on a diff in pull request #13501: MINOR: Use `exists` instead of return in DelayedFetch

["jolshan (via GitHub)" <gi...@apache.org>]

jolshan commented on code in PR #13501:
URL: https://github.com/apache/kafka/pull/13501#discussion_r1158802468


##########
core/src/main/scala/kafka/server/DelayedFetch.scala:
##########
@@ -93,14 +93,14 @@ class DelayedFetch(
               if (endOffset.onOlderSegment(fetchOffset)) {
                 // Case F, this can happen when the new fetch operation is on a truncated leader
                 debug(s"Satisfying fetch $this since it is fetching later segments of partition $topicIdPartition.")
-                return forceComplete()
+                forceComplete()

Review Comment:
   Does this have the same semantics if forceComplete returns false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org