You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2015/08/10 10:47:57 UTC

Review Request 37279: Hive View: Visual Explain does not work

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37279/
-----------------------------------------------------------

Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.


Bugs: https://issues.apache.org/jira/browse/AMBARI-12673
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-12673


Repository: ambari


Description
-------

Hive View - Visual Explain does not work :: Visual explain is generated only for the those query which has multiple stages involved(basically aggregation query). And It breaks on UI for the queries whose JSON response does not have "STAGE 1" parameter. To handle this gracefully I set an emply JSON in case of query which does not support multiple stages and show messege "Visual explain is not available." on UI.


Diffs
-----


Diff: https://reviews.apache.org/r/37279/diff/


Testing
-------

Manually tested. Executed the ui test scripts.(ember test)


Thanks,

Pallav Kulshreshtha


Re: Review Request 37279: Hive View: Visual Explain does not work

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37279/#review105777
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Aug. 10, 2015, 8:47 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37279/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 8:47 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/AMBARI-12673
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-12673
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Hive View - Visual Explain does not work :: Visual explain is generated only for the those query which has multiple stages involved(basically aggregation query). And It breaks on UI for the queries whose JSON response does not have "STAGE 1" parameter. To handle this gracefully I set an emply JSON in case of query which does not support multiple stages and show messege "Visual explain is not available." on UI.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/37279/diff/
> 
> 
> Testing
> -------
> 
> Manually tested. Executed the ui test scripts.(ember test)
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 37279: Hive View: Visual Explain does not work

Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37279/#review94951
-----------------------------------------------------------

Ship it!


Ship It!

- Srimanth Gunturi


On Aug. 10, 2015, 8:47 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37279/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 8:47 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/AMBARI-12673
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-12673
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Hive View - Visual Explain does not work :: Visual explain is generated only for the those query which has multiple stages involved(basically aggregation query). And It breaks on UI for the queries whose JSON response does not have "STAGE 1" parameter. To handle this gracefully I set an emply JSON in case of query which does not support multiple stages and show messege "Visual explain is not available." on UI.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/37279/diff/
> 
> 
> Testing
> -------
> 
> Manually tested. Executed the ui test scripts.(ember test)
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>