You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2023/01/18 08:14:29 UTC
[GitHub] [dolphinscheduler] jackfanwan commented on a diff in pull request #13422: fix when the task details are not modified, the predecessor node cannot be modified
jackfanwan commented on code in PR #13422:
URL: https://github.com/apache/dolphinscheduler/pull/13422#discussion_r1073212745
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -820,9 +820,6 @@ public Map<String, Object> updateTaskWithUpstream(User loginUser, long projectCo
Map<String, Object> result = new HashMap<>();
TaskDefinitionLog taskDefinitionToUpdate =
updateTask(loginUser, projectCode, taskCode, taskDefinitionJsonObj, result);
- if (result.get(Constants.STATUS) != Status.SUCCESS && taskDefinitionToUpdate == null) {
- return result;
- }
Review Comment:
here have judgment predecessor node and task info, so i deleted first judgement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org