You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rc...@apache.org on 2019/12/09 03:09:37 UTC

[james-project] 12/42: [Refactoring] Move FlagsFilterTest to JUnit 5

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit deec3a01fee1c30b31fb9ce01ab696d554bd7962
Author: Rene Cordier <rc...@linagora.com>
AuthorDate: Thu Dec 5 16:18:26 2019 +0700

    [Refactoring] Move FlagsFilterTest to JUnit 5
---
 .../mailbox/store/mail/model/FlagsFilterTest.java      | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFilterTest.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFilterTest.java
index d9feb62..963984c 100644
--- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFilterTest.java
+++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFilterTest.java
@@ -24,29 +24,29 @@ import java.util.List;
 
 import javax.mail.Flags;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import com.google.common.collect.ImmutableList;
 
-public class FlagsFilterTest {
+class FlagsFilterTest {
 
-    private List<Flags.Flag> listOfFlags = ImmutableList.of(Flags.Flag.SEEN, Flags.Flag.RECENT, Flags.Flag.FLAGGED);
-    private List<String> listOfUserFlags = ImmutableList.of("VeryImportant", "Bof");
+    List<Flags.Flag> listOfFlags = ImmutableList.of(Flags.Flag.SEEN, Flags.Flag.RECENT, Flags.Flag.FLAGGED);
+    List<String> listOfUserFlags = ImmutableList.of("VeryImportant", "Bof");
 
     @Test
-    public void buildShouldNotRequireAnyProperty() {
+    void buildShouldNotRequireAnyProperty() {
         assertThat(FlagsFilter.builder().build()).isNotNull();
     }
 
     @Test
-    public void buildWithoutPropertyShouldReturnNoFilter() {
+    void buildWithoutPropertyShouldReturnNoFilter() {
         FlagsFilter filter = FlagsFilter.builder().build();
         assertThat(listOfFlags.stream().filter(filter.getSystemFlagFilter())).isEqualTo(listOfFlags);
         assertThat(listOfUserFlags.stream().filter(filter.getUserFlagFilter())).isEqualTo(listOfUserFlags);
     }
 
     @Test
-    public void buildWithSystemFlagFilterShouldNotFilterUserFlags() {
+    void buildWithSystemFlagFilterShouldNotFilterUserFlags() {
         FlagsFilter filter = FlagsFilter.builder()
             .systemFlagFilter(flag -> false)
             .build();
@@ -54,7 +54,7 @@ public class FlagsFilterTest {
     }
 
     @Test
-    public void buildWithUSerFlagFilterShouldNotFilterSystemFlags() {
+    void buildWithUSerFlagFilterShouldNotFilterSystemFlags() {
         FlagsFilter filter = FlagsFilter.builder()
             .userFlagFilter(flag -> false)
             .build();
@@ -63,7 +63,7 @@ public class FlagsFilterTest {
 
 
     @Test
-    public void buildWithBothFiltersShouldApplyFilterOnBothFlagTypes() {
+    void buildWithBothFiltersShouldApplyFilterOnBothFlagTypes() {
         FlagsFilter filter = FlagsFilter.builder()
             .userFlagFilter(flag -> false)
             .systemFlagFilter(flag -> false)


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org