You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/04/05 01:12:45 UTC
[GitHub] [trafficserver] masaori335 opened a new pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
masaori335 opened a new pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676
IIUC, the `sni.yaml` works for both inbound and outbound TLS connections. But almost all of the configs work on inbound *or* outbound. This change clarifies which config works in which direction of TLS connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#issuecomment-893829475
[approve ci clang-analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#discussion_r607202039
##########
File path: doc/admin-guide/files/sni.yaml.en.rst
##########
@@ -46,102 +46,102 @@ the user needs to enter the fqdn in the configuration with a ``*.`` followed by
.. _override-verify-server-properties:
.. _override-host-sni-policy:
-========================= ========================================================================================
-Key Meaning
-========================= ========================================================================================
-fqdn Fully Qualified Domain Name. This item is used if the SNI value matches this.
+========================= ========= ========================================================================================
+Key Direction Meaning
+========================= ========= ========================================================================================
+fqdn Both Fully Qualified Domain Name. This item is used if the SNI value matches this.
-ip_allow Specify a list of client IP address, subnets, or ranges what are allowed to complete
- the connection. This list is comma separated. IPv4 and IPv6 addresses can be specified.
- Here is an example list: 192.168.1.0/24,192.168.10.1-4. This would allow connections
- from clients in the 19.168.1.0 network or in the range from 192.168.10.1 to 192.168.1.4.
+ip_allow Inbound Specify a list of client IP address, subnets, or ranges what are allowed to complete
+ the connection. This list is comma separated. IPv4 and IPv6 addresses can be specified.
+ Here is an example list: 192.168.1.0/24,192.168.10.1-4. This would allow connections
+ from clients in the 19.168.1.0 network or in the range from 192.168.10.1 to 192.168.1.4.
-verify_server_policy One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
+verify_server_policy Outbound One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
- By default this is :ts:cv:`proxy.config.ssl.client.verify.server.policy`.
- This controls how Traffic Server evaluated the origin certificate.
+ By default this is :ts:cv:`proxy.config.ssl.client.verify.server.policy`.
+ This controls how Traffic Server evaluated the origin certificate.
-verify_server_properties One of the values :code:`NONE`, :code:`SIGNATURE`, :code:`NAME`, and :code:`ALL`
+verify_server_properties Outbound One of the values :code:`NONE`, :code:`SIGNATURE`, :code:`NAME`, and :code:`ALL`
- By default this is :ts:cv:`proxy.config.ssl.client.verify.server.properties`.
- This controls what Traffic Server checks when evaluating the origin certificate.
+ By default this is :ts:cv:`proxy.config.ssl.client.verify.server.properties`.
+ This controls what Traffic Server checks when evaluating the origin certificate.
-verify_client One of the values :code:`NONE`, :code:`MODERATE`, or :code:`STRICT`.
- If ``NONE`` is specified, |TS| requests no certificate. If ``MODERATE`` is specified
- |TS| will verify a certificate that is presented by the client, but it will not
- fail the TLS handshake if no certificate is presented. If ``STRICT`` is specified
- the client must resent a certificate during the TLS handshake.
+verify_client Outbound One of the values :code:`NONE`, :code:`MODERATE`, or :code:`STRICT`.
+ If ``NONE`` is specified, |TS| requests no certificate. If ``MODERATE`` is specified
+ |TS| will verify a certificate that is presented by the client, but it will not
+ fail the TLS handshake if no certificate is presented. If ``STRICT`` is specified
+ the client must resent a certificate during the TLS handshake.
- By default this is :ts:cv:`proxy.config.ssl.client.certification_level`.
+ By default this is :ts:cv:`proxy.config.ssl.client.certification_level`.
-verify_client_ca_certs Specifies an alternate set of certificate authority certs to use to verify the
- client cert. The value must be either a file path, or a nested set of key /
- value pairs. If the value is a file path, it must specify a file containing the
- CA certs. Otherwise, there should be up to two nested pairs. The possible keys
- are ``file`` and ``dir``. The value for ``file`` must be a file path for a file
- containing CA certs. The value for ``dir`` must be a file path for an OpenSSL
- X509 hashed directory containing CA certs. If a given file path does not being
- with ``/`` , it must be relative to the |TS| configuration directory.
- ``verify_client_ca_certs`` can only be used with capbilities provided by
- OpenSSL 1.0.2 or later.
+verify_client_ca_certs Outbound Specifies an alternate set of certificate authority certs to use to verify the
Review comment:
It applies to check that the inbound policy is properly enforced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 merged pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 merged pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 merged pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 merged pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#issuecomment-868701138
@masaori335 can you fix the conflict and make appropriate updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#issuecomment-893016933
[approve ci clang-analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#issuecomment-893016933
[approve ci clang-analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#issuecomment-869240545
@shinrich Rebased on the latest master and followed your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#issuecomment-891468248
Rebased on the latest master to resolve new conflicts. @shinrich please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#discussion_r607141606
##########
File path: doc/admin-guide/files/sni.yaml.en.rst
##########
@@ -46,102 +46,102 @@ the user needs to enter the fqdn in the configuration with a ``*.`` followed by
.. _override-verify-server-properties:
.. _override-host-sni-policy:
-========================= ========================================================================================
-Key Meaning
-========================= ========================================================================================
-fqdn Fully Qualified Domain Name. This item is used if the SNI value matches this.
+========================= ========= ========================================================================================
+Key Direction Meaning
+========================= ========= ========================================================================================
+fqdn Both Fully Qualified Domain Name. This item is used if the SNI value matches this.
-ip_allow Specify a list of client IP address, subnets, or ranges what are allowed to complete
- the connection. This list is comma separated. IPv4 and IPv6 addresses can be specified.
- Here is an example list: 192.168.1.0/24,192.168.10.1-4. This would allow connections
- from clients in the 19.168.1.0 network or in the range from 192.168.10.1 to 192.168.1.4.
+ip_allow Inbound Specify a list of client IP address, subnets, or ranges what are allowed to complete
+ the connection. This list is comma separated. IPv4 and IPv6 addresses can be specified.
+ Here is an example list: 192.168.1.0/24,192.168.10.1-4. This would allow connections
+ from clients in the 19.168.1.0 network or in the range from 192.168.10.1 to 192.168.1.4.
-verify_server_policy One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
+verify_server_policy Outbound One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
- By default this is :ts:cv:`proxy.config.ssl.client.verify.server.policy`.
- This controls how Traffic Server evaluated the origin certificate.
+ By default this is :ts:cv:`proxy.config.ssl.client.verify.server.policy`.
+ This controls how Traffic Server evaluated the origin certificate.
-verify_server_properties One of the values :code:`NONE`, :code:`SIGNATURE`, :code:`NAME`, and :code:`ALL`
+verify_server_properties Outbound One of the values :code:`NONE`, :code:`SIGNATURE`, :code:`NAME`, and :code:`ALL`
- By default this is :ts:cv:`proxy.config.ssl.client.verify.server.properties`.
- This controls what Traffic Server checks when evaluating the origin certificate.
+ By default this is :ts:cv:`proxy.config.ssl.client.verify.server.properties`.
+ This controls what Traffic Server checks when evaluating the origin certificate.
-verify_client One of the values :code:`NONE`, :code:`MODERATE`, or :code:`STRICT`.
- If ``NONE`` is specified, |TS| requests no certificate. If ``MODERATE`` is specified
- |TS| will verify a certificate that is presented by the client, but it will not
- fail the TLS handshake if no certificate is presented. If ``STRICT`` is specified
- the client must resent a certificate during the TLS handshake.
+verify_client Outbound One of the values :code:`NONE`, :code:`MODERATE`, or :code:`STRICT`.
+ If ``NONE`` is specified, |TS| requests no certificate. If ``MODERATE`` is specified
+ |TS| will verify a certificate that is presented by the client, but it will not
+ fail the TLS handshake if no certificate is presented. If ``STRICT`` is specified
+ the client must resent a certificate during the TLS handshake.
- By default this is :ts:cv:`proxy.config.ssl.client.certification_level`.
+ By default this is :ts:cv:`proxy.config.ssl.client.certification_level`.
-verify_client_ca_certs Specifies an alternate set of certificate authority certs to use to verify the
- client cert. The value must be either a file path, or a nested set of key /
- value pairs. If the value is a file path, it must specify a file containing the
- CA certs. Otherwise, there should be up to two nested pairs. The possible keys
- are ``file`` and ``dir``. The value for ``file`` must be a file path for a file
- containing CA certs. The value for ``dir`` must be a file path for an OpenSSL
- X509 hashed directory containing CA certs. If a given file path does not being
- with ``/`` , it must be relative to the |TS| configuration directory.
- ``verify_client_ca_certs`` can only be used with capbilities provided by
- OpenSSL 1.0.2 or later.
+verify_client_ca_certs Outbound Specifies an alternate set of certificate authority certs to use to verify the
+ client cert. The value must be either a file path, or a nested set of key /
+ value pairs. If the value is a file path, it must specify a file containing the
+ CA certs. Otherwise, there should be up to two nested pairs. The possible keys
+ are ``file`` and ``dir``. The value for ``file`` must be a file path for a file
+ containing CA certs. The value for ``dir`` must be a file path for an OpenSSL
+ X509 hashed directory containing CA certs. If a given file path does not being
+ with ``/`` , it must be relative to the |TS| configuration directory.
+ ``verify_client_ca_certs`` can only be used with capbilities provided by
+ OpenSSL 1.0.2 or later.
-host_sni_policy One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
+host_sni_policy Outbound One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
Review comment:
This affects enforcement of inbound policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #7676: Doc: Clarify connection direction of configs in sni.yaml
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #7676:
URL: https://github.com/apache/trafficserver/pull/7676#discussion_r607142137
##########
File path: doc/admin-guide/files/sni.yaml.en.rst
##########
@@ -46,102 +46,102 @@ the user needs to enter the fqdn in the configuration with a ``*.`` followed by
.. _override-verify-server-properties:
.. _override-host-sni-policy:
-========================= ========================================================================================
-Key Meaning
-========================= ========================================================================================
-fqdn Fully Qualified Domain Name. This item is used if the SNI value matches this.
+========================= ========= ========================================================================================
+Key Direction Meaning
+========================= ========= ========================================================================================
+fqdn Both Fully Qualified Domain Name. This item is used if the SNI value matches this.
-ip_allow Specify a list of client IP address, subnets, or ranges what are allowed to complete
- the connection. This list is comma separated. IPv4 and IPv6 addresses can be specified.
- Here is an example list: 192.168.1.0/24,192.168.10.1-4. This would allow connections
- from clients in the 19.168.1.0 network or in the range from 192.168.10.1 to 192.168.1.4.
+ip_allow Inbound Specify a list of client IP address, subnets, or ranges what are allowed to complete
+ the connection. This list is comma separated. IPv4 and IPv6 addresses can be specified.
+ Here is an example list: 192.168.1.0/24,192.168.10.1-4. This would allow connections
+ from clients in the 19.168.1.0 network or in the range from 192.168.10.1 to 192.168.1.4.
-verify_server_policy One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
+verify_server_policy Outbound One of the values :code:`DISABLED`, :code:`PERMISSIVE`, or :code:`ENFORCED`.
- By default this is :ts:cv:`proxy.config.ssl.client.verify.server.policy`.
- This controls how Traffic Server evaluated the origin certificate.
+ By default this is :ts:cv:`proxy.config.ssl.client.verify.server.policy`.
+ This controls how Traffic Server evaluated the origin certificate.
-verify_server_properties One of the values :code:`NONE`, :code:`SIGNATURE`, :code:`NAME`, and :code:`ALL`
+verify_server_properties Outbound One of the values :code:`NONE`, :code:`SIGNATURE`, :code:`NAME`, and :code:`ALL`
- By default this is :ts:cv:`proxy.config.ssl.client.verify.server.properties`.
- This controls what Traffic Server checks when evaluating the origin certificate.
+ By default this is :ts:cv:`proxy.config.ssl.client.verify.server.properties`.
+ This controls what Traffic Server checks when evaluating the origin certificate.
-verify_client One of the values :code:`NONE`, :code:`MODERATE`, or :code:`STRICT`.
- If ``NONE`` is specified, |TS| requests no certificate. If ``MODERATE`` is specified
- |TS| will verify a certificate that is presented by the client, but it will not
- fail the TLS handshake if no certificate is presented. If ``STRICT`` is specified
- the client must resent a certificate during the TLS handshake.
+verify_client Outbound One of the values :code:`NONE`, :code:`MODERATE`, or :code:`STRICT`.
+ If ``NONE`` is specified, |TS| requests no certificate. If ``MODERATE`` is specified
+ |TS| will verify a certificate that is presented by the client, but it will not
+ fail the TLS handshake if no certificate is presented. If ``STRICT`` is specified
+ the client must resent a certificate during the TLS handshake.
- By default this is :ts:cv:`proxy.config.ssl.client.certification_level`.
+ By default this is :ts:cv:`proxy.config.ssl.client.certification_level`.
-verify_client_ca_certs Specifies an alternate set of certificate authority certs to use to verify the
- client cert. The value must be either a file path, or a nested set of key /
- value pairs. If the value is a file path, it must specify a file containing the
- CA certs. Otherwise, there should be up to two nested pairs. The possible keys
- are ``file`` and ``dir``. The value for ``file`` must be a file path for a file
- containing CA certs. The value for ``dir`` must be a file path for an OpenSSL
- X509 hashed directory containing CA certs. If a given file path does not being
- with ``/`` , it must be relative to the |TS| configuration directory.
- ``verify_client_ca_certs`` can only be used with capbilities provided by
- OpenSSL 1.0.2 or later.
+verify_client_ca_certs Outbound Specifies an alternate set of certificate authority certs to use to verify the
Review comment:
This is also inbound policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org