You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/10 10:38:56 UTC

[GitHub] [maven-wrapper] bmarwell commented on pull request #82: [BUILD] add code style check for shell scripts

bmarwell commented on PR #82:
URL: https://github.com/apache/maven-wrapper/pull/82#issuecomment-1377054543

   > one issue I see, we need a tool to fix code style locally like for java we can simply execute `mvn spotless:apply`
   > 
   > Will be not comfortable to check result on GH and apply fix manually
   
   As shfmt produces a diff, we should be able to apply it. If spotless can do shell formatting, I can investigate using spotless instead.
   E.g. using prettier: https://github.com/diffplug/spotless/tree/main/plugin-maven#prettier
   
   WDYT? Can close this one in favour of spotless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org