You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by marekchen <gi...@git.apache.org> on 2018/03/07 11:52:47 UTC

[GitHub] incubator-weex pull request #1053: [android]fix input bug

GitHub user marekchen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1053

    [android]fix input bug

    英文不好就用中文描述了:
    1.当在created中设置input的value值为“1”,然后删除“1”,这时不会触发input事件
    2.当输入“1”后,还是不能触发input事件,因为value值和输入值相同时,不触发input事件
    重现代码如下:
    ``` html
    <template>
      <div>
        <div>
          <text style="font-size: 40px">oninput: {{idCard}}</text>
          <text style="font-size: 40px">onchange: {{idCard}}</text>
    
        </div>
        <scroller>
          <div>
            <div style="background-color: #286090">
              <text class="title" style="height: 80 ;padding: 20;color: #FFFFFF">input type = text</text>
            </div>
            <input type="text" :value="idCard" @input="oninput" @change="onchange" class="input" maxlength="18" ref="name2"/>
          </div>
          <button class="button" @click="clickbutton">click</button>
        </scroller>
      </div>
    </template>
    
    <style scoped>
      .input {
        font-size: 60px;
        height: 80px;
        width: 750px;
      }
      .button {
        font-size: 36;
        width: 200px;
        height: 200px;
        color: #41B883;
        text-align: center;
        padding-top: 10;
        padding-bottom: 10;
        border-width: 2;
        border-style: solid;
        margin-right: 20;
        border-color: rgb(162, 217, 192);
        background-color: rgba(162, 217, 192, 0.2);
      }
    </style>
    
    <script>
      module.exports = {
        data: function () {
          return {
            idCard:'',
          };
        },
        methods: {
          clickbutton: function () {
            var that=this;
            var modal = weex.requireModule('modal')
            modal.toast({
                message:"text:"+that.idCard,
                duration: 0.3
            })
          },
          oninput: function(event){
            this.idCard = event.value;
            console.log('oninput', event.value);
          },
          onchange: function (event) {
            this.idCard = event.value;
            console.log('onchange', event.value);
          },
        },
        created(){
          this.idCard = "1"
        }
      };
    </script>
    ```
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [x] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marekchen/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1053
    
----
commit ef9584f7c0a6246f75cd4fb6aef624537b0c038a
Author: marekchen <c4...@...>
Date:   2018-03-07T11:41:12Z

    Update AbstractEditComponent.java

----


---

[GitHub] incubator-weex issue #1053: [android]fix input bug

Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:

    https://github.com/apache/incubator-weex/pull/1053
  
    hi  @marekchen  there are some conflicts in this patch , you can rebase your branch to update its head


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

Posted by marekchen <gi...@git.apache.org>.
Github user marekchen closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1053


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

Posted by marekchen <gi...@git.apache.org>.
GitHub user marekchen reopened a pull request:

    https://github.com/apache/incubator-weex/pull/1053

    [android]fix input bug

    英文不好就用中文描述了:
    1.当在created中设置input的value值为“1”,然后删除“1”,这时不会触发input事件
    2.当输入“1”后,还是不能触发input事件,因为value值和输入值相同时,不触发input事件
    重现代码如下:
    ``` html
    <template>
      <div>
        <div>
          <text style="font-size: 40px">oninput: {{idCard}}</text>
          <text style="font-size: 40px">onchange: {{idCard}}</text>
    
        </div>
        <scroller>
          <div>
            <div style="background-color: #286090">
              <text class="title" style="height: 80 ;padding: 20;color: #FFFFFF">input type = text</text>
            </div>
            <input type="text" :value="idCard" @input="oninput" @change="onchange" class="input" maxlength="18" ref="name2"/>
          </div>
          <button class="button" @click="clickbutton">click</button>
        </scroller>
      </div>
    </template>
    
    <style scoped>
      .input {
        font-size: 60px;
        height: 80px;
        width: 750px;
      }
      .button {
        font-size: 36;
        width: 200px;
        height: 200px;
        color: #41B883;
        text-align: center;
        padding-top: 10;
        padding-bottom: 10;
        border-width: 2;
        border-style: solid;
        margin-right: 20;
        border-color: rgb(162, 217, 192);
        background-color: rgba(162, 217, 192, 0.2);
      }
    </style>
    
    <script>
      module.exports = {
        data: function () {
          return {
            idCard:'',
          };
        },
        methods: {
          clickbutton: function () {
            var that=this;
            var modal = weex.requireModule('modal')
            modal.toast({
                message:"text:"+that.idCard,
                duration: 0.3
            })
          },
          oninput: function(event){
            this.idCard = event.value;
            console.log('oninput', event.value);
          },
          onchange: function (event) {
            this.idCard = event.value;
            console.log('onchange', event.value);
          },
        },
        created(){
          this.idCard = "1"
        }
      };
    </script>
    ```
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [x] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marekchen/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1053
    
----
commit ef9584f7c0a6246f75cd4fb6aef624537b0c038a
Author: marekchen <c4...@...>
Date:   2018-03-07T11:41:12Z

    Update AbstractEditComponent.java

----


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

Posted by marekchen <gi...@git.apache.org>.
Github user marekchen closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1053


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

Posted by marekchen <gi...@git.apache.org>.
Github user marekchen closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1053


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

Posted by marekchen <gi...@git.apache.org>.
GitHub user marekchen reopened a pull request:

    https://github.com/apache/incubator-weex/pull/1053

    [android]fix input bug

    英文不好就用中文描述了:
    1.当在created中设置input的value值为“1”,然后删除“1”,这时不会触发input事件
    2.当输入“1”后,还是不能触发input事件,因为value值和输入值相同时,不触发input事件
    重现代码如下:
    ``` html
    <template>
      <div>
        <div>
          <text style="font-size: 40px">oninput: {{idCard}}</text>
          <text style="font-size: 40px">onchange: {{idCard}}</text>
    
        </div>
        <scroller>
          <div>
            <div style="background-color: #286090">
              <text class="title" style="height: 80 ;padding: 20;color: #FFFFFF">input type = text</text>
            </div>
            <input type="text" :value="idCard" @input="oninput" @change="onchange" class="input" maxlength="18" ref="name2"/>
          </div>
          <button class="button" @click="clickbutton">click</button>
        </scroller>
      </div>
    </template>
    
    <style scoped>
      .input {
        font-size: 60px;
        height: 80px;
        width: 750px;
      }
      .button {
        font-size: 36;
        width: 200px;
        height: 200px;
        color: #41B883;
        text-align: center;
        padding-top: 10;
        padding-bottom: 10;
        border-width: 2;
        border-style: solid;
        margin-right: 20;
        border-color: rgb(162, 217, 192);
        background-color: rgba(162, 217, 192, 0.2);
      }
    </style>
    
    <script>
      module.exports = {
        data: function () {
          return {
            idCard:'',
          };
        },
        methods: {
          clickbutton: function () {
            var that=this;
            var modal = weex.requireModule('modal')
            modal.toast({
                message:"text:"+that.idCard,
                duration: 0.3
            })
          },
          oninput: function(event){
            this.idCard = event.value;
            console.log('oninput', event.value);
          },
          onchange: function (event) {
            this.idCard = event.value;
            console.log('onchange', event.value);
          },
        },
        created(){
          this.idCard = "1"
        }
      };
    </script>
    ```
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [x] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marekchen/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1053
    
----
commit ef9584f7c0a6246f75cd4fb6aef624537b0c038a
Author: marekchen <c4...@...>
Date:   2018-03-07T11:41:12Z

    Update AbstractEditComponent.java

----


---

[GitHub] incubator-weex issue #1053: [android]fix input bug

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1053
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

Posted by marekchen <gi...@git.apache.org>.
Github user marekchen closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1053


---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

Posted by marekchen <gi...@git.apache.org>.
GitHub user marekchen reopened a pull request:

    https://github.com/apache/incubator-weex/pull/1053

    [android]fix input bug

    英文不好就用中文描述了:
    1.当在created中设置input的value值为“1”,然后删除“1”,这时不会触发input事件
    2.当输入“1”后,还是不能触发input事件,因为value值和输入值相同时,不触发input事件
    重现代码如下:
    ``` html
    <template>
      <div>
        <div>
          <text style="font-size: 40px">oninput: {{idCard}}</text>
          <text style="font-size: 40px">onchange: {{idCard}}</text>
    
        </div>
        <scroller>
          <div>
            <div style="background-color: #286090">
              <text class="title" style="height: 80 ;padding: 20;color: #FFFFFF">input type = text</text>
            </div>
            <input type="text" :value="idCard" @input="oninput" @change="onchange" class="input" maxlength="18" ref="name2"/>
          </div>
          <button class="button" @click="clickbutton">click</button>
        </scroller>
      </div>
    </template>
    
    <style scoped>
      .input {
        font-size: 60px;
        height: 80px;
        width: 750px;
      }
      .button {
        font-size: 36;
        width: 200px;
        height: 200px;
        color: #41B883;
        text-align: center;
        padding-top: 10;
        padding-bottom: 10;
        border-width: 2;
        border-style: solid;
        margin-right: 20;
        border-color: rgb(162, 217, 192);
        background-color: rgba(162, 217, 192, 0.2);
      }
    </style>
    
    <script>
      module.exports = {
        data: function () {
          return {
            idCard:'',
          };
        },
        methods: {
          clickbutton: function () {
            var that=this;
            var modal = weex.requireModule('modal')
            modal.toast({
                message:"text:"+that.idCard,
                duration: 0.3
            })
          },
          oninput: function(event){
            this.idCard = event.value;
            console.log('oninput', event.value);
          },
          onchange: function (event) {
            this.idCard = event.value;
            console.log('onchange', event.value);
          },
        },
        created(){
          this.idCard = "1"
        }
      };
    </script>
    ```
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [x] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marekchen/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1053
    
----
commit 7c5ef1c68f7c71f9179af7693ae20a691a02c971
Author: yuhun-alibaba <to...@...>
Date:   2018-03-01T14:11:16Z

     * [WEEX-240] [android] feature update for weexsandbox and size off so
     1. every page will has a runtime context independent of other page
     2. At the beginning of js, will use // {"framework" : "Rax"} or // {"framework" : "Vue"} to distinguish type
     3. if page type is neither Rax nor Vue, will use global context runtime
     4. delete some usless code and opt build tools, trim so

commit ef9584f7c0a6246f75cd4fb6aef624537b0c038a
Author: marekchen <c4...@...>
Date:   2018-03-07T11:41:12Z

    Update AbstractEditComponent.java

commit 8d9420223296e13023039f34ef31006e2a0166b6
Author: marekchen <ma...@...>
Date:   2018-03-12T06:33:26Z

    Merge branch 'master' of https://github.com/apache/incubator-weex into apache-master

commit 6b17dd61ee147a969a2ae3b69123ad1c1efe6604
Author: marekchen <ma...@...>
Date:   2018-03-12T06:36:03Z

    Merge branch 'apache-master'

----


---