You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/21 23:14:08 UTC
[GitHub] [camel-karavan] mgubaidullin opened a new issue, #577: Each DSL node should have generated ID
mgubaidullin opened a new issue, #577:
URL: https://github.com/apache/camel-karavan/issues/577
DSL Node IDs are required for debugging
1. Route should have unique ID
2. First added routeConfiguration might have empty ID
3. Node IDs should be unique in each route route
4. User should be able to change generated IDs (System should check uniqueness for user defined IDs)
5. If open manually created YAML without IDs, system should generate IDs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #577: Each DSL node should have generated ID
Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on issue #577:
URL: https://github.com/apache/camel-karavan/issues/577#issuecomment-1362209060
@davsclaus could you please confirm ^^^ node IDs requirements for debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] davsclaus commented on issue #577: Each DSL node should have generated ID
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #577:
URL: https://github.com/apache/camel-karavan/issues/577#issuecomment-1362496829
yes the BacklogDebugger uses nodeIDs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin closed issue #577: Each DSL node should have generated ID
Posted by GitBox <gi...@apache.org>.
mgubaidullin closed issue #577: Each DSL node should have generated ID
URL: https://github.com/apache/camel-karavan/issues/577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] cristph commented on issue #577: Each DSL node should have generated ID
Posted by GitBox <gi...@apache.org>.
cristph commented on issue #577:
URL: https://github.com/apache/camel-karavan/issues/577#issuecomment-1373281315
about this change https://github.com/apache/camel-karavan/commit/2c1c1f6e58d8f3e11214852d94b71171904231e9
I'm wondering that it makes developer cannot change the already assigned id, it always keeps the old assigned value
if there's any concern?
```
karavan-designer/src/designer/route/property/DslPropertyField.tsx
propertyChanged = (fieldId: string, value: string | number | boolean | any, newRoute?: RouteToCreate) => {
if (fieldId === 'id' && CamelDefinitionApiExt.hasElementWithId(this.props.integration, value)) {
value = this.props.value;
}
this.props.onChange?.call(this, fieldId, value, newRoute);
this.setState({selectStatus: new Map<string, boolean>([[fieldId, false]])});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-karavan] mgubaidullin commented on issue #577: Each DSL node should have generated ID
Posted by GitBox <gi...@apache.org>.
mgubaidullin commented on issue #577:
URL: https://github.com/apache/camel-karavan/issues/577#issuecomment-1373687445
Karavan automatically sets node IDs.
User can change node ID manually, however Karavan checks node ID uniqueness, because node ID should be unique in the route
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org