You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/07/14 04:57:29 UTC

Review Request 36472: Update submitting-a-patch.md

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36472/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

When developer is using git to clone the mesos source code and
want to build & submit a patch, s/he needs to run ./bootstrap
first to generate some files such as configure, .gitignore etc.
But the document do not including such instructions.

This patch is adding bootstrap to the guidelines.


Diffs
-----

  docs/submitting-a-patch.md 0221fe36f3f061b2f4ffe0fc4684420608f853b2 

Diff: https://reviews.apache.org/r/36472/diff/


Testing
-------


Thanks,

Guangya Liu


Re: Review Request 36472: Update submitting-a-patch.md

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36472/#review91584
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36472]

All tests passed.

- Mesos ReviewBot


On July 14, 2015, 3 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36472/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 3 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When developer is using git to clone the mesos source code and
> want to build & submit a patch, s/he needs to run ./bootstrap
> first to generate some files such as configure, .gitignore etc.
> But the document do not including such instructions.
> 
> This patch is adding bootstrap to the guidelines.
> 
> 
> Diffs
> -----
> 
>   docs/submitting-a-patch.md 0221fe36f3f061b2f4ffe0fc4684420608f853b2 
> 
> Diff: https://reviews.apache.org/r/36472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 36472: Update submitting-a-patch.md

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36472/
-----------------------------------------------------------

(Updated July 14, 2015, 3 a.m.)


Review request for mesos.


Repository: mesos


Description
-------

When developer is using git to clone the mesos source code and
want to build & submit a patch, s/he needs to run ./bootstrap
first to generate some files such as configure, .gitignore etc.
But the document do not including such instructions.

This patch is adding bootstrap to the guidelines.


Diffs (updated)
-----

  docs/submitting-a-patch.md 0221fe36f3f061b2f4ffe0fc4684420608f853b2 

Diff: https://reviews.apache.org/r/36472/diff/


Testing
-------


Thanks,

Guangya Liu