You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Héctor A <ne...@gmail.com> on 2015/01/07 16:43:07 UTC
Wrong event metadata tags in FlexUnit
It has come to my attention that FlexUnit has some metadata tags wrongly
defined, in org.flexunit.runner.FlexUnitCore there are:
[Event(type="testsComplete", type="flash.events.Event")]
[Event(type="runnerStart", type="flash.events.Event")]
[Event(type="testsStopped", type="flash.events.Event")]
Where it should be:
[Event(name="testsComplete", type="flash.events.Event")]
[Event(name="runnerStart", type="flash.events.Event")]
[Event(name="testsStopped", type="flash.events.Event")]
I don't know if there are more tags using wrong properties, a quick search
showed only those ones.
Best regards
Re: Wrong event metadata tags in FlexUnit
Posted by piotrz <pi...@gmail.com>.
You are welcome! It's building right now - Will be ready in 20 minutes. :)
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Wrong-event-metadata-tags-in-FlexUnit-tp44209p44235.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: Wrong event metadata tags in FlexUnit
Posted by Héctor A <ne...@gmail.com>.
Thank you!
2015年1月8日木曜日、piotrz<pi...@gmail.com>さんは書きました:
> Hi Neverbirth,
>
> I've just changed it. Let's see what will happened. If you will have time
> try to test it.
>
> I think artefacts will be available after the build here:
> http://apacheflexbuild.cloudapp.net:8080/job/flex-flexunit/
>
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com <javascript:;>
> --
> View this message in context:
> http://apache-flex-development.2333347.n4.nabble.com/Wrong-event-metadata-tags-in-FlexUnit-tp44209p44221.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
Re: Wrong event metadata tags in FlexUnit
Posted by piotrz <pi...@gmail.com>.
Hi Neverbirth,
I've just changed it. Let's see what will happened. If you will have time
try to test it.
I think artefacts will be available after the build here:
http://apacheflexbuild.cloudapp.net:8080/job/flex-flexunit/
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Wrong-event-metadata-tags-in-FlexUnit-tp44209p44221.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: Wrong event metadata tags in FlexUnit
Posted by Héctor A <ne...@gmail.com>.
Interestingly, the meta tags have been wrong since they were first added
nearly 5 years ago:
https://github.com/apache/flex-flexunit/commit/d594ab33d62bc5ba6f70888bfbe23a1bb2280d0b
On Wed, Jan 7, 2015 at 4:43 PM, Héctor A <ne...@gmail.com> wrote:
> It has come to my attention that FlexUnit has some metadata tags wrongly
> defined, in org.flexunit.runner.FlexUnitCore there are:
>
> [Event(type="testsComplete", type="flash.events.Event")]
> [Event(type="runnerStart", type="flash.events.Event")]
> [Event(type="testsStopped", type="flash.events.Event")]
>
> Where it should be:
>
> [Event(name="testsComplete", type="flash.events.Event")]
> [Event(name="runnerStart", type="flash.events.Event")]
> [Event(name="testsStopped", type="flash.events.Event")]
>
> I don't know if there are more tags using wrong properties, a quick search
> showed only those ones.
>
> Best regards
>