You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/04 12:17:55 UTC

[GitHub] [spark] yaooqinn opened a new pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

yaooqinn opened a new pull request #31012:
URL: https://github.com/apache/spark/pull/31012


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763836658


   **[Test build #134290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134290/testReport)** for PR 31012 at commit [`7502623`](https://github.com/apache/spark/commit/750262351920e1bdb82ef91a6b3c9624a8bbcba0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-755158520


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38310/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764671368


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134330/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767334644


   **[Test build #134486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134486/testReport)** for PR 31012 at commit [`77d2397`](https://github.com/apache/spark/commit/77d23973207b24679b4891e1f2b423e57757f34b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-757985408


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38515/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-761160841


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38704/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-761235955


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134121/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31012:
URL: https://github.com/apache/spark/pull/31012


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-762739599


   **[Test build #134222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134222/testReport)** for PR 31012 at commit [`5817a66`](https://github.com/apache/spark/commit/5817a66ddeb979b27fda0ac1176885bfe3c4f655).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764556533


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38916/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560052173



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/explain.txt
##########
@@ -200,87 +207,115 @@ Left keys [1]: [c_customer_sk#1]
 Right keys [1]: [customer_sk#18]
 Join condition: None
 
-(35) Project [codegen id : 12]
+(35) Project [codegen id : 11]
 Output [2]: [c_current_cdemo_sk#2, c_current_addr_sk#3]
 Input [3]: [c_customer_sk#1, c_current_cdemo_sk#2, c_current_addr_sk#3]
 
-(36) Scan parquet default.customer_address
-Output [2]: [ca_address_sk#20, ca_county#21]
+(36) Exchange
+Input [2]: [c_current_cdemo_sk#2, c_current_addr_sk#3]
+Arguments: hashpartitioning(c_current_addr_sk#3, 5), ENSURE_REQUIREMENTS, [id=#20]
+
+(37) Sort [codegen id : 12]
+Input [2]: [c_current_cdemo_sk#2, c_current_addr_sk#3]
+Arguments: [c_current_addr_sk#3 ASC NULLS FIRST], false, 0
+
+(38) Scan parquet default.customer_address
+Output [2]: [ca_address_sk#21, ca_county#22]
 Batched: true
 Location [not included in comparison]/{warehouse_dir}/customer_address]
-PushedFilters: [In(ca_county, [Walker County,Richland County,Gaines County,Douglas County,Dona Ana County]), IsNotNull(ca_address_sk)]

Review comment:
       unexpected change




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767480669


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134486/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-755105355


   **[Test build #133722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133722/testReport)** for PR 31012 at commit [`021d3bb`](https://github.com/apache/spark/commit/021d3bb27fda67bc2962fcf84ad27c48c3a84143).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763856247


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38876/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754357493


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38199/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758596464


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133964/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r599448368



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` CHAR(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` VARCHAR(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` CHAR(20),
+        |`s_manager` VARCHAR(40),
+        |`s_market_id` INT,
+        |`s_geography_class` VARCHAR(100),
+        |`s_market_desc` VARCHAR(100),
+        |`s_market_manager` VARCHAR(40),
+        |`s_division_id` INT,
+        |`s_division_name` VARCHAR(50),
+        |`s_company_id` INT,
+        |`s_company_name` VARCHAR(50),
+        |`s_street_number` VARCHAR(10),
+        |`s_street_name` VARCHAR(60),
+        |`s_street_type` CHAR(15),
+        |`s_suite_number` CHAR(10),
+        |`s_city` VARCHAR(60),
+        |`s_county` VARCHAR(30),
+        |`s_state` CHAR(2),
+        |`s_zip` CHAR(10),
+        |`s_country` VARCHAR(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` CHAR(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` VARCHAR(50),
+        |`cc_class` VARCHAR(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` CHAR(20),
+        |`cc_manager` VARCHAR(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` CHAR(50),
+        |`cc_mkt_desc` VARCHAR(100),
+        |`cc_market_manager` VARCHAR(40),
+        |`cc_division` INT,
+        |`cc_division_name` VARCHAR(50),
+        |`cc_company` INT,
+        |`cc_company_name` CHAR(50),
+        |`cc_street_number` CHAR(10),
+        |`cc_street_name` VARCHAR(60),
+        |`cc_street_type` CHAR(15),
+        |`cc_suite_number` CHAR(10),
+        |`cc_city` VARCHAR(60),
+        |`cc_county` VARCHAR(30),
+        |`cc_state` CHAR(2),
+        |`cc_zip` CHAR(10),
+        |`cc_country` VARCHAR(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` CHAR(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` VARCHAR(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` VARCHAR(100),
+        |`cp_type` VARCHAR(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` CHAR(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` VARCHAR(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` VARCHAR(50),
+        |`web_manager` VARCHAR(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` VARCHAR(50),
+        |`web_mkt_desc` VARCHAR(100),
+        |`web_market_manager` VARCHAR(40),
+        |`web_company_id` INT,
+        |`web_company_name` CHAR(50),
+        |`web_street_number` CHAR(10),
+        |`web_street_name` VARCHAR(60),
+        |`web_street_type` CHAR(15),
+        |`web_suite_number` CHAR(10),
+        |`web_city` VARCHAR(60),
+        |`web_county` VARCHAR(30),
+        |`web_state` CHAR(2),
+        |`web_zip` CHAR(10),
+        |`web_country` VARCHAR(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` CHAR(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` CHAR(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` VARCHAR(100),
+        |`wp_type` CHAR(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` CHAR(16),
+        |`w_warehouse_name` VARCHAR(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` CHAR(10),
+        |`w_street_name` VARCHAR(20),
+        |`w_street_type` CHAR(15),
+        |`w_suite_number` CHAR(10),
+        |`w_city` VARCHAR(60),
+        |`w_county` VARCHAR(30),
+        |`w_state` CHAR(2),
+        |`w_zip` CHAR(10),
+        |`w_country` VARCHAR(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` CHAR(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` CHAR(10),
+        |`c_first_name` CHAR(20),
+        |`c_last_name` CHAR(30),
+        |`c_preferred_cust_flag` CHAR(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` VARCHAR(20),
+        |`c_login` CHAR(13),
+        |`c_email_address` CHAR(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` CHAR(16),
+        |`ca_street_number` CHAR(10),
+        |`ca_street_name` VARCHAR(60),
+        |`ca_street_type` CHAR(15),
+        |`ca_suite_number` CHAR(10),
+        |`ca_city` VARCHAR(60),
+        |`ca_county` VARCHAR(30),
+        |`ca_state` CHAR(2),
+        |`ca_zip` CHAR(10),
+        |`ca_country` VARCHAR(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` CHAR(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` CHAR(1),
+        |`cd_marital_status` CHAR(1),
+        |`cd_education_status` CHAR(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` CHAR(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` CHAR(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` CHAR(9),
+        |`d_quarter_name` CHAR(1),

Review comment:
       https://github.com/apache/spark/pull/31886/files#r599317278




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-761160841


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38704/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754357493


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38199/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767700136


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39092/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754394214


   **[Test build #133610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133610/testReport)** for PR 31012 at commit [`4affca9`](https://github.com/apache/spark/commit/4affca9252f4298fe96fa873ff10234ba0e79bc3).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763281771


   > Could you check the other DDL definition for ssb (`SSBQuerySuite`) and tpc-h (`TPCHQuerySuite`)? We need the same change there, too?
   
   yes we can check that later


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767383025


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767773607


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134506/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764598629






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560620658



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/simplified.txt
##########
@@ -1,81 +1,100 @@
 TakeOrderedAndProject [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,cnt1,cnt2,cnt3,cnt4,cnt5,cnt6]
-  WholeStageCodegen (14)
+  WholeStageCodegen (20)
     HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,count] [count(1),cnt1,cnt2,cnt3,cnt4,cnt5,cnt6,count]
       InputAdapter
         Exchange [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] #1
-          WholeStageCodegen (13)
+          WholeStageCodegen (19)
             HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] [count,count]
               Project [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
-                BroadcastHashJoin [c_current_cdemo_sk,cd_demo_sk]
+                SortMergeJoin [c_current_cdemo_sk,cd_demo_sk]

Review comment:
       Looks interesting. Why did the plan change here? The plan cannot correctly get stats from a table with char/varchar?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r599505405



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` CHAR(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` VARCHAR(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` CHAR(20),
+        |`s_manager` VARCHAR(40),
+        |`s_market_id` INT,
+        |`s_geography_class` VARCHAR(100),
+        |`s_market_desc` VARCHAR(100),
+        |`s_market_manager` VARCHAR(40),
+        |`s_division_id` INT,
+        |`s_division_name` VARCHAR(50),
+        |`s_company_id` INT,
+        |`s_company_name` VARCHAR(50),
+        |`s_street_number` VARCHAR(10),
+        |`s_street_name` VARCHAR(60),
+        |`s_street_type` CHAR(15),
+        |`s_suite_number` CHAR(10),
+        |`s_city` VARCHAR(60),
+        |`s_county` VARCHAR(30),
+        |`s_state` CHAR(2),
+        |`s_zip` CHAR(10),
+        |`s_country` VARCHAR(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` CHAR(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` VARCHAR(50),
+        |`cc_class` VARCHAR(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` CHAR(20),
+        |`cc_manager` VARCHAR(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` CHAR(50),
+        |`cc_mkt_desc` VARCHAR(100),
+        |`cc_market_manager` VARCHAR(40),
+        |`cc_division` INT,
+        |`cc_division_name` VARCHAR(50),
+        |`cc_company` INT,
+        |`cc_company_name` CHAR(50),
+        |`cc_street_number` CHAR(10),
+        |`cc_street_name` VARCHAR(60),
+        |`cc_street_type` CHAR(15),
+        |`cc_suite_number` CHAR(10),
+        |`cc_city` VARCHAR(60),
+        |`cc_county` VARCHAR(30),
+        |`cc_state` CHAR(2),
+        |`cc_zip` CHAR(10),
+        |`cc_country` VARCHAR(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` CHAR(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` VARCHAR(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` VARCHAR(100),
+        |`cp_type` VARCHAR(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` CHAR(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` VARCHAR(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` VARCHAR(50),
+        |`web_manager` VARCHAR(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` VARCHAR(50),
+        |`web_mkt_desc` VARCHAR(100),
+        |`web_market_manager` VARCHAR(40),
+        |`web_company_id` INT,
+        |`web_company_name` CHAR(50),
+        |`web_street_number` CHAR(10),
+        |`web_street_name` VARCHAR(60),
+        |`web_street_type` CHAR(15),
+        |`web_suite_number` CHAR(10),
+        |`web_city` VARCHAR(60),
+        |`web_county` VARCHAR(30),
+        |`web_state` CHAR(2),
+        |`web_zip` CHAR(10),
+        |`web_country` VARCHAR(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` CHAR(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` CHAR(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` VARCHAR(100),
+        |`wp_type` CHAR(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` CHAR(16),
+        |`w_warehouse_name` VARCHAR(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` CHAR(10),
+        |`w_street_name` VARCHAR(20),
+        |`w_street_type` CHAR(15),
+        |`w_suite_number` CHAR(10),
+        |`w_city` VARCHAR(60),
+        |`w_county` VARCHAR(30),
+        |`w_state` CHAR(2),
+        |`w_zip` CHAR(10),
+        |`w_country` VARCHAR(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` CHAR(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` CHAR(10),
+        |`c_first_name` CHAR(20),
+        |`c_last_name` CHAR(30),
+        |`c_preferred_cust_flag` CHAR(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` VARCHAR(20),
+        |`c_login` CHAR(13),
+        |`c_email_address` CHAR(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` CHAR(16),
+        |`ca_street_number` CHAR(10),
+        |`ca_street_name` VARCHAR(60),
+        |`ca_street_type` CHAR(15),
+        |`ca_suite_number` CHAR(10),
+        |`ca_city` VARCHAR(60),
+        |`ca_county` VARCHAR(30),
+        |`ca_state` CHAR(2),
+        |`ca_zip` CHAR(10),
+        |`ca_country` VARCHAR(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` CHAR(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` CHAR(1),
+        |`cd_marital_status` CHAR(1),
+        |`cd_education_status` CHAR(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` CHAR(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` CHAR(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` CHAR(9),
+        |`d_quarter_name` CHAR(1),

Review comment:
       Yea, sure, @dongjoon-hyun ~




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754319648


   **[Test build #133610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133610/testReport)** for PR 31012 at commit [`4affca9`](https://github.com/apache/spark/commit/4affca9252f4298fe96fa873ff10234ba0e79bc3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-762796524


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38807/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763894253






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-757945452


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38515/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754397811


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133610/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560624505



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/simplified.txt
##########
@@ -1,81 +1,100 @@
 TakeOrderedAndProject [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,cnt1,cnt2,cnt3,cnt4,cnt5,cnt6]
-  WholeStageCodegen (14)
+  WholeStageCodegen (20)
     HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,count] [count(1),cnt1,cnt2,cnt3,cnt4,cnt5,cnt6,count]
       InputAdapter
         Exchange [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] #1
-          WholeStageCodegen (13)
+          WholeStageCodegen (19)
             HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] [count,count]
               Project [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
-                BroadcastHashJoin [c_current_cdemo_sk,cd_demo_sk]
+                SortMergeJoin [c_current_cdemo_sk,cd_demo_sk]

Review comment:
       I guess so. The padding expression stops stats propagation in CBO and we need to fix that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r564603020



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q27.sf100/explain.txt
##########
@@ -128,15 +128,15 @@ Input [9]: [ss_item_sk#1, ss_cdemo_sk#2, ss_store_sk#3, ss_quantity#4, ss_list_p
 Output [4]: [cd_demo_sk#13, cd_gender#14, cd_marital_status#15, cd_education_status#16]
 Batched: true
 Location [not included in comparison]/{warehouse_dir}/customer_demographics]
-PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary), IsNotNull(cd_demo_sk)]
+PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary             ), IsNotNull(cd_demo_sk)]

Review comment:
       No big deal at all, just wondering why this now has whitespace? is it because these are now fixed-length strings?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r564988567



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q27.sf100/explain.txt
##########
@@ -128,15 +128,15 @@ Input [9]: [ss_item_sk#1, ss_cdemo_sk#2, ss_store_sk#3, ss_quantity#4, ss_list_p
 Output [4]: [cd_demo_sk#13, cd_gender#14, cd_marital_status#15, cd_education_status#16]
 Batched: true
 Location [not included in comparison]/{warehouse_dir}/customer_demographics]
-PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary), IsNotNull(cd_demo_sk)]
+PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary             ), IsNotNull(cd_demo_sk)]

Review comment:
       the `dsdgen` tool would produce fixed-length strings for char values in the original data, so we should pad accordingly to match correctlly




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763894253


   **[Test build #134290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134290/testReport)** for PR 31012 at commit [`7502623`](https://github.com/apache/spark/commit/750262351920e1bdb82ef91a6b3c9624a8bbcba0).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754355404


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38199/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754397811


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133610/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767579479


   **[Test build #134506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134506/testReport)** for PR 31012 at commit [`1aa22f0`](https://github.com/apache/spark/commit/1aa22f055db370e77e506403666000e8e1e19f9c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r558798965



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.util;

Review comment:
       thanks for reviewing.
   
   And yes, it conflicts with that PR, because I want to verify those changes here and ensure that all tpdcs tests pass. 
   I will resolve the conflicts after that PR merged and then ping admins.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767383025


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r599449624



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` CHAR(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` VARCHAR(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` CHAR(20),
+        |`s_manager` VARCHAR(40),
+        |`s_market_id` INT,
+        |`s_geography_class` VARCHAR(100),
+        |`s_market_desc` VARCHAR(100),
+        |`s_market_manager` VARCHAR(40),
+        |`s_division_id` INT,
+        |`s_division_name` VARCHAR(50),
+        |`s_company_id` INT,
+        |`s_company_name` VARCHAR(50),
+        |`s_street_number` VARCHAR(10),
+        |`s_street_name` VARCHAR(60),
+        |`s_street_type` CHAR(15),
+        |`s_suite_number` CHAR(10),
+        |`s_city` VARCHAR(60),
+        |`s_county` VARCHAR(30),
+        |`s_state` CHAR(2),
+        |`s_zip` CHAR(10),
+        |`s_country` VARCHAR(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` CHAR(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` VARCHAR(50),
+        |`cc_class` VARCHAR(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` CHAR(20),
+        |`cc_manager` VARCHAR(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` CHAR(50),
+        |`cc_mkt_desc` VARCHAR(100),
+        |`cc_market_manager` VARCHAR(40),
+        |`cc_division` INT,
+        |`cc_division_name` VARCHAR(50),
+        |`cc_company` INT,
+        |`cc_company_name` CHAR(50),
+        |`cc_street_number` CHAR(10),
+        |`cc_street_name` VARCHAR(60),
+        |`cc_street_type` CHAR(15),
+        |`cc_suite_number` CHAR(10),
+        |`cc_city` VARCHAR(60),
+        |`cc_county` VARCHAR(30),
+        |`cc_state` CHAR(2),
+        |`cc_zip` CHAR(10),
+        |`cc_country` VARCHAR(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` CHAR(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` VARCHAR(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` VARCHAR(100),
+        |`cp_type` VARCHAR(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` CHAR(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` VARCHAR(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` VARCHAR(50),
+        |`web_manager` VARCHAR(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` VARCHAR(50),
+        |`web_mkt_desc` VARCHAR(100),
+        |`web_market_manager` VARCHAR(40),
+        |`web_company_id` INT,
+        |`web_company_name` CHAR(50),
+        |`web_street_number` CHAR(10),
+        |`web_street_name` VARCHAR(60),
+        |`web_street_type` CHAR(15),
+        |`web_suite_number` CHAR(10),
+        |`web_city` VARCHAR(60),
+        |`web_county` VARCHAR(30),
+        |`web_state` CHAR(2),
+        |`web_zip` CHAR(10),
+        |`web_country` VARCHAR(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` CHAR(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` CHAR(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` VARCHAR(100),
+        |`wp_type` CHAR(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` CHAR(16),
+        |`w_warehouse_name` VARCHAR(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` CHAR(10),
+        |`w_street_name` VARCHAR(20),
+        |`w_street_type` CHAR(15),
+        |`w_suite_number` CHAR(10),
+        |`w_city` VARCHAR(60),
+        |`w_county` VARCHAR(30),
+        |`w_state` CHAR(2),
+        |`w_zip` CHAR(10),
+        |`w_country` VARCHAR(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` CHAR(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` CHAR(10),
+        |`c_first_name` CHAR(20),
+        |`c_last_name` CHAR(30),
+        |`c_preferred_cust_flag` CHAR(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` VARCHAR(20),
+        |`c_login` CHAR(13),
+        |`c_email_address` CHAR(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` CHAR(16),
+        |`ca_street_number` CHAR(10),
+        |`ca_street_name` VARCHAR(60),
+        |`ca_street_type` CHAR(15),
+        |`ca_suite_number` CHAR(10),
+        |`ca_city` VARCHAR(60),
+        |`ca_county` VARCHAR(30),
+        |`ca_state` CHAR(2),
+        |`ca_zip` CHAR(10),
+        |`ca_country` VARCHAR(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` CHAR(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` CHAR(1),
+        |`cd_marital_status` CHAR(1),
+        |`cd_education_status` CHAR(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` CHAR(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` CHAR(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` CHAR(9),
+        |`d_quarter_name` CHAR(1),

Review comment:
       nice catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758595351


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38551/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763898648






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767466479


   **[Test build #134486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134486/testReport)** for PR 31012 at commit [`77d2397`](https://github.com/apache/spark/commit/77d23973207b24679b4891e1f2b423e57757f34b).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-768169164


   it has conflicts with 3.1, @yaooqinn can you create a backport PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758556705


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38551/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767334644


   **[Test build #134486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134486/testReport)** for PR 31012 at commit [`77d2397`](https://github.com/apache/spark/commit/77d23973207b24679b4891e1f2b423e57757f34b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r564588100



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -418,7 +418,7 @@ object RemoveRedundantAliases extends Rule[LogicalPlan] {
     // If the alias name is different from attribute name, we can't strip it either, or we
     // may accidentally change the output schema name of the root plan.
     case a @ Alias(attr: Attribute, name)
-      if a.metadata == Metadata.empty &&
+      if (a.metadata == Metadata.empty || a.metadata == attr.metadata) &&

Review comment:
       This is the only non-testing change in this PR, but it's very minor and obvious.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r599447123



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` CHAR(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` VARCHAR(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` CHAR(20),
+        |`s_manager` VARCHAR(40),
+        |`s_market_id` INT,
+        |`s_geography_class` VARCHAR(100),
+        |`s_market_desc` VARCHAR(100),
+        |`s_market_manager` VARCHAR(40),
+        |`s_division_id` INT,
+        |`s_division_name` VARCHAR(50),
+        |`s_company_id` INT,
+        |`s_company_name` VARCHAR(50),
+        |`s_street_number` VARCHAR(10),
+        |`s_street_name` VARCHAR(60),
+        |`s_street_type` CHAR(15),
+        |`s_suite_number` CHAR(10),
+        |`s_city` VARCHAR(60),
+        |`s_county` VARCHAR(30),
+        |`s_state` CHAR(2),
+        |`s_zip` CHAR(10),
+        |`s_country` VARCHAR(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` CHAR(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` VARCHAR(50),
+        |`cc_class` VARCHAR(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` CHAR(20),
+        |`cc_manager` VARCHAR(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` CHAR(50),
+        |`cc_mkt_desc` VARCHAR(100),
+        |`cc_market_manager` VARCHAR(40),
+        |`cc_division` INT,
+        |`cc_division_name` VARCHAR(50),
+        |`cc_company` INT,
+        |`cc_company_name` CHAR(50),
+        |`cc_street_number` CHAR(10),
+        |`cc_street_name` VARCHAR(60),
+        |`cc_street_type` CHAR(15),
+        |`cc_suite_number` CHAR(10),
+        |`cc_city` VARCHAR(60),
+        |`cc_county` VARCHAR(30),
+        |`cc_state` CHAR(2),
+        |`cc_zip` CHAR(10),
+        |`cc_country` VARCHAR(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` CHAR(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` VARCHAR(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` VARCHAR(100),
+        |`cp_type` VARCHAR(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` CHAR(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` VARCHAR(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` VARCHAR(50),
+        |`web_manager` VARCHAR(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` VARCHAR(50),
+        |`web_mkt_desc` VARCHAR(100),
+        |`web_market_manager` VARCHAR(40),
+        |`web_company_id` INT,
+        |`web_company_name` CHAR(50),
+        |`web_street_number` CHAR(10),
+        |`web_street_name` VARCHAR(60),
+        |`web_street_type` CHAR(15),
+        |`web_suite_number` CHAR(10),
+        |`web_city` VARCHAR(60),
+        |`web_county` VARCHAR(30),
+        |`web_state` CHAR(2),
+        |`web_zip` CHAR(10),
+        |`web_country` VARCHAR(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` CHAR(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` CHAR(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` VARCHAR(100),
+        |`wp_type` CHAR(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` CHAR(16),
+        |`w_warehouse_name` VARCHAR(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` CHAR(10),
+        |`w_street_name` VARCHAR(20),
+        |`w_street_type` CHAR(15),
+        |`w_suite_number` CHAR(10),
+        |`w_city` VARCHAR(60),
+        |`w_county` VARCHAR(30),
+        |`w_state` CHAR(2),
+        |`w_zip` CHAR(10),
+        |`w_country` VARCHAR(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` CHAR(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` CHAR(10),
+        |`c_first_name` CHAR(20),
+        |`c_last_name` CHAR(30),
+        |`c_preferred_cust_flag` CHAR(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` VARCHAR(20),
+        |`c_login` CHAR(13),
+        |`c_email_address` CHAR(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` CHAR(16),
+        |`ca_street_number` CHAR(10),
+        |`ca_street_name` VARCHAR(60),
+        |`ca_street_type` CHAR(15),
+        |`ca_suite_number` CHAR(10),
+        |`ca_city` VARCHAR(60),
+        |`ca_county` VARCHAR(30),
+        |`ca_state` CHAR(2),
+        |`ca_zip` CHAR(10),
+        |`ca_country` VARCHAR(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` CHAR(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` CHAR(1),
+        |`cd_marital_status` CHAR(1),
+        |`cd_education_status` CHAR(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` CHAR(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` CHAR(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` CHAR(9),
+        |`d_quarter_name` CHAR(1),

Review comment:
       This should be `char(6)` (see p28 in http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v2.9.0.pdf)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r558583690



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.util;

Review comment:
       Looks like you have changes from another PR here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-757923004


   **[Test build #133928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133928/testReport)** for PR 31012 at commit [`7078573`](https://github.com/apache/spark/commit/70785738a12b2b713fe11b63ba79a5680e3aa6ab).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-762796524


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38807/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764204457


   ```
   == Optimized Logical Plan ==
   GlobalLimit 100, Statistics(sizeInBytes=14.8 KiB, rowCount=100)
   +- LocalLimit 100, Statistics(sizeInBytes=254.6 MiB, rowCount=1.92E+6)
      +- Sort [cd_gender#305 ASC NULLS FIRST, cd_marital_status#306 ASC NULLS FIRST, cd_education_status#307 ASC NULLS FIRST, cd_purchase_estimate#50 ASC NULLS FIRST, cd_credit_rating#308 ASC NULLS FIRST, cd_dep_count#52 ASC NULLS FIRST, cd_dep_employed_count#53 ASC NULLS FIRST, cd_dep_college_count#54 ASC NULLS FIRST], true, Statistics(sizeInBytes=254.6 MiB, rowCount=1.92E+6)
         +- Aggregate [cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], [cd_gender#305, cd_marital_status#306, cd_education_status#307, count(1) AS cnt1#0L, cd_purchase_estimate#50, count(1) AS cnt2#1L, cd_credit_rating#308, count(1) AS cnt3#2L, cd_dep_count#52, count(1) AS cnt4#3L, cd_dep_employed_count#53, count(1) AS cnt5#4L, cd_dep_college_count#54, count(1) AS cnt6#5L], Statistics(sizeInBytes=254.6 MiB, rowCount=1.92E+6)
            +- Project [cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], Statistics(sizeInBytes=184.7 MiB, rowCount=2.13E+6)
               +- Join Inner, (cd_demo_sk#46 = c_current_cdemo_sk#17), Statistics(sizeInBytes=200.9 MiB, rowCount=2.13E+6)
                  :- Project [c_current_cdemo_sk#17], Statistics(sizeInBytes=23.4 MiB, rowCount=2.05E+6)
                  :  +- Join Inner, (c_current_addr_sk#19 = ca_address_sk#33), Statistics(sizeInBytes=39.0 MiB, rowCount=2.05E+6)
                  :     :- Project [c_current_cdemo_sk#17, c_current_addr_sk#19], Statistics(sizeInBytes=29.5 MiB, rowCount=1.93E+6)
                  :     :  +- Join LeftSemi, (customer_sk#8 = c_customer_sk#15), Statistics(sizeInBytes=36.8 MiB, rowCount=1.93E+6)
                  :     :     :- Join LeftSemi, (customer_sk#6 = c_customer_sk#15), Statistics(sizeInBytes=36.8 MiB, rowCount=1.93E+6)
                  :     :     :  :- Project [c_customer_sk#15, c_current_cdemo_sk#17, c_current_addr_sk#19], Statistics(sizeInBytes=36.8 MiB, rowCount=1.93E+6)
                  :     :     :  :  +- Filter ((isnotnull(c_customer_sk#15) AND isnotnull(c_current_addr_sk#19)) AND isnotnull(c_current_cdemo_sk#17)), Statistics(sizeInBytes=438.1 MiB, rowCount=1.93E+6)
                  :     :     :  :     +- Relation[c_customer_sk#15,c_customer_id#16,c_current_cdemo_sk#17,c_current_hdemo_sk#18,c_current_addr_sk#19,c_first_shipto_date_sk#20,c_first_sales_date_sk#21,c_salutation#22,c_first_name#23,c_last_name#24,c_preferred_cust_flag#25,c_birth_day#26,c_birth_month#27,c_birth_year#28,c_birth_country#29,c_login#30,c_email_address#31,c_last_review_date#32] parquet, Statistics(sizeInBytes=453.9 MiB, rowCount=2.00E+6)
                  :     :     :  +- Union false, false, Statistics(sizeInBytes=137.8 MiB, rowCount=1.20E+7)
                  :     :     :     :- Project [ws_bill_customer_sk#59 AS customer_sk#6], Statistics(sizeInBytes=45.8 MiB, rowCount=4.00E+6)
                  :     :     :     :  +- Join Inner, (ws_sold_date_sk#55 = d_date_sk#89), Statistics(sizeInBytes=76.3 MiB, rowCount=4.00E+6)
                  :     :     :     :     :- Project [ws_sold_date_sk#55, ws_bill_customer_sk#59], Statistics(sizeInBytes=1098.1 MiB, rowCount=7.20E+7)
                  :     :     :     :     :  +- Filter (isnotnull(ws_sold_date_sk#55) AND isnotnull(ws_bill_customer_sk#59)), Statistics(sizeInBytes=13.7 GiB, rowCount=7.20E+7)
                  :     :     :     :     :     +- Relation[ws_sold_date_sk#55,ws_sold_time_sk#56,ws_ship_date_sk#57,ws_item_sk#58,ws_bill_customer_sk#59,ws_bill_cdemo_sk#60,ws_bill_hdemo_sk#61,ws_bill_addr_sk#62,ws_ship_customer_sk#63,ws_ship_cdemo_sk#64,ws_ship_hdemo_sk#65,ws_ship_addr_sk#66,ws_web_page_sk#67,ws_web_site_sk#68,ws_ship_mode_sk#69,ws_warehouse_sk#70,ws_promo_sk#71,ws_order_number#72,ws_quantity#73,ws_wholesale_cost#74,ws_list_price#75,ws_sales_price#76,ws_ext_discount_amt#77,ws_ext_sales_price#78,... 10 more fields] parquet, Statistics(sizeInBytes=13.7 GiB, rowCount=7.20E+7)
                  :     :     :     :     +- Project [d_date_sk#89], Statistics(sizeInBytes=1188.0 B, rowCount=99)
                  :     :     :     :        +- Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89)), Statistics(sizeInBytes=24.4 KiB, rowCount=99)
                  :     :     :     :           +- Relation[d_date_sk#89,d_date_id#90,d_date#91,d_month_seq#92,d_week_seq#93,d_quarter_seq#94,d_year#95,d_dow#96,d_moy#97,d_dom#98,d_qoy#99,d_fy_year#100,d_fy_quarter_seq#101,d_fy_week_seq#102,d_day_name#103,d_quarter_name#104,d_holiday#105,d_weekend#106,d_following_holiday#107,d_first_dom#108,d_last_dom#109,d_same_day_ly#110,d_same_day_lq#111,d_current_day#112,... 4 more fields] parquet, Statistics(sizeInBytes=17.6 MiB, rowCount=7.30E+4)
                  :     :     :     +- Project [cs_ship_customer_sk#124 AS customer_sk#7], Statistics(sizeInBytes=92.0 MiB, rowCount=8.04E+6)
                  :     :     :        +- Join Inner, (cs_sold_date_sk#117 = d_date_sk#89), Statistics(sizeInBytes=153.4 MiB, rowCount=8.04E+6)
                  :     :     :           :- Project [cs_sold_date_sk#117, cs_ship_customer_sk#124], Statistics(sizeInBytes=2.1 GiB, rowCount=1.43E+8)
                  :     :     :           :  +- Filter (isnotnull(cs_sold_date_sk#117) AND isnotnull(cs_ship_customer_sk#124)), Statistics(sizeInBytes=27.1 GiB, rowCount=1.43E+8)
                  :     :     :           :     +- Relation[cs_sold_date_sk#117,cs_sold_time_sk#118,cs_ship_date_sk#119,cs_bill_customer_sk#120,cs_bill_cdemo_sk#121,cs_bill_hdemo_sk#122,cs_bill_addr_sk#123,cs_ship_customer_sk#124,cs_ship_cdemo_sk#125,cs_ship_hdemo_sk#126,cs_ship_addr_sk#127,cs_call_center_sk#128,cs_catalog_page_sk#129,cs_ship_mode_sk#130,cs_warehouse_sk#131,cs_item_sk#132,cs_promo_sk#133,cs_order_number#134,cs_quantity#135,cs_wholesale_cost#136,cs_list_price#137,cs_sales_price#138,cs_ext_discount_amt#139,cs_ext_sales_price#140,... 10 more fields] parquet, Statistics(sizeInBytes=27.4 GiB, rowCount=1.44E+8)
                  :     :     :           +- Project [d_date_sk#89], Statistics(sizeInBytes=1188.0 B, rowCount=99)
                  :     :     :              +- Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89)), Statistics(sizeInBytes=24.4 KiB, rowCount=99)
                  :     :     :                 +- Relation[d_date_sk#89,d_date_id#90,d_date#91,d_month_seq#92,d_week_seq#93,d_quarter_seq#94,d_year#95,d_dow#96,d_moy#97,d_dom#98,d_qoy#99,d_fy_year#100,d_fy_quarter_seq#101,d_fy_week_seq#102,d_day_name#103,d_quarter_name#104,d_holiday#105,d_weekend#106,d_following_holiday#107,d_first_dom#108,d_last_dom#109,d_same_day_ly#110,d_same_day_lq#111,d_current_day#112,... 4 more fields] parquet, Statistics(sizeInBytes=17.6 MiB, rowCount=7.30E+4)
                  :     :     +- Project [ss_customer_sk#154 AS customer_sk#8], Statistics(sizeInBytes=183.1 MiB, rowCount=1.60E+7)
                  :     :        +- Join Inner, (ss_sold_date_sk#151 = d_date_sk#89), Statistics(sizeInBytes=305.2 MiB, rowCount=1.60E+7)
                  :     :           :- Project [ss_sold_date_sk#151, ss_customer_sk#154], Statistics(sizeInBytes=3.9 GiB, rowCount=2.63E+8)
                  :     :           :  +- Filter (isnotnull(ss_sold_date_sk#151) AND isnotnull(ss_customer_sk#154)), Statistics(sizeInBytes=36.2 GiB, rowCount=2.63E+8)
                  :     :           :     +- Relation[ss_sold_date_sk#151,ss_sold_time_sk#152,ss_item_sk#153,ss_customer_sk#154,ss_cdemo_sk#155,ss_hdemo_sk#156,ss_addr_sk#157,ss_store_sk#158,ss_promo_sk#159,ss_ticket_number#160,ss_quantity#161,ss_wholesale_cost#162,ss_list_price#163,ss_sales_price#164,ss_ext_discount_amt#165,ss_ext_sales_price#166,ss_ext_wholesale_cost#167,ss_ext_list_price#168,ss_ext_tax#169,ss_coupon_amt#170,ss_net_paid#171,ss_net_paid_inc_tax#172,ss_net_profit#173] parquet, Statistics(sizeInBytes=39.7 GiB, rowCount=2.88E+8)
                  :     :           +- Project [d_date_sk#89], Statistics(sizeInBytes=1188.0 B, rowCount=99)
                  :     :              +- Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89)), Statistics(sizeInBytes=24.4 KiB, rowCount=99)
                  :     :                 +- Relation[d_date_sk#89,d_date_id#90,d_date#91,d_month_seq#92,d_week_seq#93,d_quarter_seq#94,d_year#95,d_dow#96,d_moy#97,d_dom#98,d_qoy#99,d_fy_year#100,d_fy_quarter_seq#101,d_fy_week_seq#102,d_day_name#103,d_quarter_name#104,d_holiday#105,d_weekend#106,d_following_holiday#107,d_first_dom#108,d_last_dom#109,d_same_day_ly#110,d_same_day_lq#111,d_current_day#112,... 4 more fields] parquet, Statistics(sizeInBytes=17.6 MiB, rowCount=7.30E+4)
                  :     +- Project [ca_address_sk#33], Statistics(sizeInBytes=11.4 MiB, rowCount=1.00E+6)
                  :        +- Filter (staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, varcharTypeReadSideCheck, ca_county#40, 30, false, true) IN (Walker County,Richland County,Gaines County,Douglas County,Dona Ana County) AND isnotnull(ca_address_sk#33)), Statistics(sizeInBytes=233.7 MiB, rowCount=1.00E+6)
                  :           +- Relation[ca_address_sk#33,ca_address_id#34,ca_street_number#35,ca_street_name#36,ca_street_type#37,ca_suite_number#38,ca_city#39,ca_county#40,ca_state#41,ca_zip#42,ca_country#43,ca_gmt_offset#44,ca_location_type#45] parquet, Statistics(sizeInBytes=233.7 MiB, rowCount=1.00E+6)
                  +- Project [cd_demo_sk#46, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_gender#47, 1, false, true) AS cd_gender#305, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_marital_status#48, 1, false, true) AS cd_marital_status#306, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_education_status#49, 20, false, true) AS cd_education_status#307, cd_purchase_estimate#50, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_credit_rating#51, 10, false, true) AS cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], Statistics(sizeInBytes=174.0 MiB, rowCount=1.92E+6)
                     +- Filter isnotnull(cd_demo_sk#46), Statistics(sizeInBytes=174.0 MiB, rowCount=1.92E+6)
                        +- Relation[cd_demo_sk#46,cd_gender#47,cd_marital_status#48,cd_education_status#49,cd_purchase_estimate#50,cd_credit_rating#51,cd_dep_count#52,cd_dep_employed_count#53,cd_dep_college_count#54] parquet, Statistics(sizeInBytes=174.0 MiB, rowCount=1.92E+6)
   
   == Physical Plan ==
   TakeOrderedAndProject(limit=100, orderBy=[cd_gender#305 ASC NULLS FIRST,cd_marital_status#306 ASC NULLS FIRST,cd_education_status#307 ASC NULLS FIRST,cd_purchase_estimate#50 ASC NULLS FIRST,cd_credit_rating#308 ASC NULLS FIRST,cd_dep_count#52 ASC NULLS FIRST,cd_dep_employed_count#53 ASC NULLS FIRST,cd_dep_college_count#54 ASC NULLS FIRST], output=[cd_gender#305,cd_marital_status#306,cd_education_status#307,cnt1#0L,cd_purchase_estimate#50,cnt2#1L,cd_credit_rating#308,cnt3#2L,cd_dep_count#52,cnt4#3L,cd_dep_employed_count#53,cnt5#4L,cd_dep_college_count#54,cnt6#5L])
   +- *(20) HashAggregate(keys=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], functions=[count(1)], output=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cnt1#0L, cd_purchase_estimate#50, cnt2#1L, cd_credit_rating#308, cnt3#2L, cd_dep_count#52, cnt4#3L, cd_dep_employed_count#53, cnt5#4L, cd_dep_college_count#54, cnt6#5L])
      +- Exchange hashpartitioning(cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54, 5), ENSURE_REQUIREMENTS, [id=#537]
         +- *(19) HashAggregate(keys=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], functions=[partial_count(1)], output=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54, count#357L])
            +- *(19) Project [cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54]
               +- *(19) SortMergeJoin [c_current_cdemo_sk#17], [cd_demo_sk#46], Inner
                  :- *(16) Sort [c_current_cdemo_sk#17 ASC NULLS FIRST], false, 0
                  :  +- Exchange hashpartitioning(c_current_cdemo_sk#17, 5), ENSURE_REQUIREMENTS, [id=#528]
                  :     +- *(15) Project [c_current_cdemo_sk#17]
                  :        +- *(15) SortMergeJoin [c_current_addr_sk#19], [ca_address_sk#33], Inner
                  :           :- *(12) Sort [c_current_addr_sk#19 ASC NULLS FIRST], false, 0
                  :           :  +- Exchange hashpartitioning(c_current_addr_sk#19, 5), ENSURE_REQUIREMENTS, [id=#520]
                  :           :     +- *(11) Project [c_current_cdemo_sk#17, c_current_addr_sk#19]
                  :           :        +- SortMergeJoin [c_customer_sk#15], [customer_sk#8], LeftSemi
                  :           :           :- SortMergeJoin [c_customer_sk#15], [customer_sk#6], LeftSemi
                  :           :           :  :- *(2) Sort [c_customer_sk#15 ASC NULLS FIRST], false, 0
                  :           :           :  :  +- Exchange hashpartitioning(c_customer_sk#15, 5), ENSURE_REQUIREMENTS, [id=#332]
                  :           :           :  :     +- *(1) Filter ((isnotnull(c_customer_sk#15) AND isnotnull(c_current_addr_sk#19)) AND isnotnull(c_current_cdemo_sk#17))
                  :           :           :  :        +- *(1) ColumnarToRow
                  :           :           :  :           +- FileScan parquet default.customer[c_customer_sk#15,c_current_cdemo_sk#17,c_current_addr_sk#19] Batched: true, DataFilters: [isnotnull(c_customer_sk#15), isnotnull(c_current_addr_sk#19), isnotnull(c_current_cdemo_sk#17)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(c_customer_sk), IsNotNull(c_current_addr_sk), IsNotNull(c_current_cdemo_sk)], ReadSchema: struct<c_customer_sk:int,c_current_cdemo_sk:int,c_current_addr_sk:int>
                  :           :           :  +- *(7) Sort [customer_sk#6 ASC NULLS FIRST], false, 0
                  :           :           :     +- Exchange hashpartitioning(customer_sk#6, 5), ENSURE_REQUIREMENTS, [id=#455]
                  :           :           :        +- Union
                  :           :           :           :- *(4) Project [ws_bill_customer_sk#59 AS customer_sk#6]
                  :           :           :           :  +- *(4) BroadcastHashJoin [ws_sold_date_sk#55], [d_date_sk#89], Inner, BuildRight, false
                  :           :           :           :     :- *(4) Filter (isnotnull(ws_sold_date_sk#55) AND isnotnull(ws_bill_customer_sk#59))
                  :           :           :           :     :  +- *(4) ColumnarToRow
                  :           :           :           :     :     +- FileScan parquet default.web_sales[ws_sold_date_sk#55,ws_bill_customer_sk#59] Batched: true, DataFilters: [isnotnull(ws_sold_date_sk#55), isnotnull(ws_bill_customer_sk#59)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(ws_sold_date_sk), IsNotNull(ws_bill_customer_sk)], ReadSchema: struct<ws_sold_date_sk:int,ws_bill_customer_sk:int>
                  :           :           :           :     +- BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [id=#344]
                  :           :           :           :        +- *(3) Project [d_date_sk#89]
                  :           :           :           :           +- *(3) Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89))
                  :           :           :           :              +- *(3) ColumnarToRow
                  :           :           :           :                 +- FileScan parquet default.date_dim[d_date_sk#89,d_year#95,d_moy#97] Batched: true, DataFilters: [isnotnull(d_year#95), isnotnull(d_moy#97), (d_year#95 = 2002), (d_moy#97 >= 4), (d_moy#97 <= 7),..., Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(d_year), IsNotNull(d_moy), EqualTo(d_year,2002), GreaterThanOrEqual(d_moy,4), LessThan..., ReadSchema: struct<d_date_sk:int,d_year:int,d_moy:int>
                  :           :           :           +- *(6) Project [cs_ship_customer_sk#124 AS customer_sk#7]
                  :           :           :              +- *(6) BroadcastHashJoin [cs_sold_date_sk#117], [d_date_sk#89], Inner, BuildRight, false
                  :           :           :                 :- *(6) Filter (isnotnull(cs_sold_date_sk#117) AND isnotnull(cs_ship_customer_sk#124))
                  :           :           :                 :  +- *(6) ColumnarToRow
                  :           :           :                 :     +- FileScan parquet default.catalog_sales[cs_sold_date_sk#117,cs_ship_customer_sk#124] Batched: true, DataFilters: [isnotnull(cs_sold_date_sk#117), isnotnull(cs_ship_customer_sk#124)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(cs_sold_date_sk), IsNotNull(cs_ship_customer_sk)], ReadSchema: struct<cs_sold_date_sk:int,cs_ship_customer_sk:int>
                  :           :           :                 +- ReusedExchange [d_date_sk#89], BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [id=#344]
                  :           :           +- *(10) Sort [customer_sk#8 ASC NULLS FIRST], false, 0
                  :           :              +- Exchange hashpartitioning(customer_sk#8, 5), ENSURE_REQUIREMENTS, [id=#474]
                  :           :                 +- *(9) Project [ss_customer_sk#154 AS customer_sk#8]
                  :           :                    +- *(9) BroadcastHashJoin [ss_sold_date_sk#151], [d_date_sk#89], Inner, BuildRight, false
                  :           :                       :- *(9) Filter (isnotnull(ss_sold_date_sk#151) AND isnotnull(ss_customer_sk#154))
                  :           :                       :  +- *(9) ColumnarToRow
                  :           :                       :     +- FileScan parquet default.store_sales[ss_sold_date_sk#151,ss_customer_sk#154] Batched: true, DataFilters: [isnotnull(ss_sold_date_sk#151), isnotnull(ss_customer_sk#154)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(ss_sold_date_sk), IsNotNull(ss_customer_sk)], ReadSchema: struct<ss_sold_date_sk:int,ss_customer_sk:int>
                  :           :                       +- ReusedExchange [d_date_sk#89], BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [id=#344]
                  :           +- *(14) Sort [ca_address_sk#33 ASC NULLS FIRST], false, 0
                  :              +- Exchange hashpartitioning(ca_address_sk#33, 5), ENSURE_REQUIREMENTS, [id=#399]
                  :                 +- *(13) Project [ca_address_sk#33]
                  :                    +- *(13) Filter (staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, varcharTypeReadSideCheck, ca_county#40, 30, false, true) IN (Walker County,Richland County,Gaines County,Douglas County,Dona Ana County) AND isnotnull(ca_address_sk#33))
                  :                       +- *(13) ColumnarToRow
                  :                          +- FileScan parquet default.customer_address[ca_address_sk#33,ca_county#40] Batched: true, DataFilters: [staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, varch..., Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(ca_address_sk)], ReadSchema: struct<ca_address_sk:int,ca_county:string>
                  +- *(18) Sort [cd_demo_sk#46 ASC NULLS FIRST], false, 0
                     +- Exchange hashpartitioning(cd_demo_sk#46, 5), ENSURE_REQUIREMENTS, [id=#417]
                        +- *(17) Project [cd_demo_sk#46, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_gender#47, 1, false, true) AS cd_gender#305, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_marital_status#48, 1, false, true) AS cd_marital_status#306, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_education_status#49, 20, false, true) AS cd_education_status#307, cd_purchase_estimate#50, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_credit_rating#51, 10, false, true) AS cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54]
                           +- *(17) Filter isnotnull(cd_demo_sk#46)
                              +- *(17) ColumnarToRow
                                 +- FileScan parquet default.customer_demographics[cd_demo_sk#46,cd_gender#47,cd_marital_status#48,cd_education_status#49,cd_purchase_estimate#50,cd_credit_rating#51,cd_dep_count#52,cd_dep_employed_count#53,cd_dep_college_count#54] Batched: true, DataFilters: [isnotnull(cd_demo_sk#46)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(cd_demo_sk)], ReadSchema: struct<cd_demo_sk:int,cd_gender:string,cd_marital_status:string,cd_education_status:string,cd_pur...
   
   ````


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763872493


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38876/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764204457


   ```
   == Optimized Logical Plan ==
   GlobalLimit 100, Statistics(sizeInBytes=14.8 KiB, rowCount=100)
   +- LocalLimit 100, Statistics(sizeInBytes=254.6 MiB, rowCount=1.92E+6)
      +- Sort [cd_gender#305 ASC NULLS FIRST, cd_marital_status#306 ASC NULLS FIRST, cd_education_status#307 ASC NULLS FIRST, cd_purchase_estimate#50 ASC NULLS FIRST, cd_credit_rating#308 ASC NULLS FIRST, cd_dep_count#52 ASC NULLS FIRST, cd_dep_employed_count#53 ASC NULLS FIRST, cd_dep_college_count#54 ASC NULLS FIRST], true, Statistics(sizeInBytes=254.6 MiB, rowCount=1.92E+6)
         +- Aggregate [cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], [cd_gender#305, cd_marital_status#306, cd_education_status#307, count(1) AS cnt1#0L, cd_purchase_estimate#50, count(1) AS cnt2#1L, cd_credit_rating#308, count(1) AS cnt3#2L, cd_dep_count#52, count(1) AS cnt4#3L, cd_dep_employed_count#53, count(1) AS cnt5#4L, cd_dep_college_count#54, count(1) AS cnt6#5L], Statistics(sizeInBytes=254.6 MiB, rowCount=1.92E+6)
            +- Project [cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], Statistics(sizeInBytes=184.7 MiB, rowCount=2.13E+6)
               +- Join Inner, (cd_demo_sk#46 = c_current_cdemo_sk#17), Statistics(sizeInBytes=200.9 MiB, rowCount=2.13E+6)
                  :- Project [c_current_cdemo_sk#17], Statistics(sizeInBytes=23.4 MiB, rowCount=2.05E+6)
                  :  +- Join Inner, (c_current_addr_sk#19 = ca_address_sk#33), Statistics(sizeInBytes=39.0 MiB, rowCount=2.05E+6)
                  :     :- Project [c_current_cdemo_sk#17, c_current_addr_sk#19], Statistics(sizeInBytes=29.5 MiB, rowCount=1.93E+6)
                  :     :  +- Join LeftSemi, (customer_sk#8 = c_customer_sk#15), Statistics(sizeInBytes=36.8 MiB, rowCount=1.93E+6)
                  :     :     :- Join LeftSemi, (customer_sk#6 = c_customer_sk#15), Statistics(sizeInBytes=36.8 MiB, rowCount=1.93E+6)
                  :     :     :  :- Project [c_customer_sk#15, c_current_cdemo_sk#17, c_current_addr_sk#19], Statistics(sizeInBytes=36.8 MiB, rowCount=1.93E+6)
                  :     :     :  :  +- Filter ((isnotnull(c_customer_sk#15) AND isnotnull(c_current_addr_sk#19)) AND isnotnull(c_current_cdemo_sk#17)), Statistics(sizeInBytes=438.1 MiB, rowCount=1.93E+6)
                  :     :     :  :     +- Relation[c_customer_sk#15,c_customer_id#16,c_current_cdemo_sk#17,c_current_hdemo_sk#18,c_current_addr_sk#19,c_first_shipto_date_sk#20,c_first_sales_date_sk#21,c_salutation#22,c_first_name#23,c_last_name#24,c_preferred_cust_flag#25,c_birth_day#26,c_birth_month#27,c_birth_year#28,c_birth_country#29,c_login#30,c_email_address#31,c_last_review_date#32] parquet, Statistics(sizeInBytes=453.9 MiB, rowCount=2.00E+6)
                  :     :     :  +- Union false, false, Statistics(sizeInBytes=137.8 MiB, rowCount=1.20E+7)
                  :     :     :     :- Project [ws_bill_customer_sk#59 AS customer_sk#6], Statistics(sizeInBytes=45.8 MiB, rowCount=4.00E+6)
                  :     :     :     :  +- Join Inner, (ws_sold_date_sk#55 = d_date_sk#89), Statistics(sizeInBytes=76.3 MiB, rowCount=4.00E+6)
                  :     :     :     :     :- Project [ws_sold_date_sk#55, ws_bill_customer_sk#59], Statistics(sizeInBytes=1098.1 MiB, rowCount=7.20E+7)
                  :     :     :     :     :  +- Filter (isnotnull(ws_sold_date_sk#55) AND isnotnull(ws_bill_customer_sk#59)), Statistics(sizeInBytes=13.7 GiB, rowCount=7.20E+7)
                  :     :     :     :     :     +- Relation[ws_sold_date_sk#55,ws_sold_time_sk#56,ws_ship_date_sk#57,ws_item_sk#58,ws_bill_customer_sk#59,ws_bill_cdemo_sk#60,ws_bill_hdemo_sk#61,ws_bill_addr_sk#62,ws_ship_customer_sk#63,ws_ship_cdemo_sk#64,ws_ship_hdemo_sk#65,ws_ship_addr_sk#66,ws_web_page_sk#67,ws_web_site_sk#68,ws_ship_mode_sk#69,ws_warehouse_sk#70,ws_promo_sk#71,ws_order_number#72,ws_quantity#73,ws_wholesale_cost#74,ws_list_price#75,ws_sales_price#76,ws_ext_discount_amt#77,ws_ext_sales_price#78,... 10 more fields] parquet, Statistics(sizeInBytes=13.7 GiB, rowCount=7.20E+7)
                  :     :     :     :     +- Project [d_date_sk#89], Statistics(sizeInBytes=1188.0 B, rowCount=99)
                  :     :     :     :        +- Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89)), Statistics(sizeInBytes=24.4 KiB, rowCount=99)
                  :     :     :     :           +- Relation[d_date_sk#89,d_date_id#90,d_date#91,d_month_seq#92,d_week_seq#93,d_quarter_seq#94,d_year#95,d_dow#96,d_moy#97,d_dom#98,d_qoy#99,d_fy_year#100,d_fy_quarter_seq#101,d_fy_week_seq#102,d_day_name#103,d_quarter_name#104,d_holiday#105,d_weekend#106,d_following_holiday#107,d_first_dom#108,d_last_dom#109,d_same_day_ly#110,d_same_day_lq#111,d_current_day#112,... 4 more fields] parquet, Statistics(sizeInBytes=17.6 MiB, rowCount=7.30E+4)
                  :     :     :     +- Project [cs_ship_customer_sk#124 AS customer_sk#7], Statistics(sizeInBytes=92.0 MiB, rowCount=8.04E+6)
                  :     :     :        +- Join Inner, (cs_sold_date_sk#117 = d_date_sk#89), Statistics(sizeInBytes=153.4 MiB, rowCount=8.04E+6)
                  :     :     :           :- Project [cs_sold_date_sk#117, cs_ship_customer_sk#124], Statistics(sizeInBytes=2.1 GiB, rowCount=1.43E+8)
                  :     :     :           :  +- Filter (isnotnull(cs_sold_date_sk#117) AND isnotnull(cs_ship_customer_sk#124)), Statistics(sizeInBytes=27.1 GiB, rowCount=1.43E+8)
                  :     :     :           :     +- Relation[cs_sold_date_sk#117,cs_sold_time_sk#118,cs_ship_date_sk#119,cs_bill_customer_sk#120,cs_bill_cdemo_sk#121,cs_bill_hdemo_sk#122,cs_bill_addr_sk#123,cs_ship_customer_sk#124,cs_ship_cdemo_sk#125,cs_ship_hdemo_sk#126,cs_ship_addr_sk#127,cs_call_center_sk#128,cs_catalog_page_sk#129,cs_ship_mode_sk#130,cs_warehouse_sk#131,cs_item_sk#132,cs_promo_sk#133,cs_order_number#134,cs_quantity#135,cs_wholesale_cost#136,cs_list_price#137,cs_sales_price#138,cs_ext_discount_amt#139,cs_ext_sales_price#140,... 10 more fields] parquet, Statistics(sizeInBytes=27.4 GiB, rowCount=1.44E+8)
                  :     :     :           +- Project [d_date_sk#89], Statistics(sizeInBytes=1188.0 B, rowCount=99)
                  :     :     :              +- Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89)), Statistics(sizeInBytes=24.4 KiB, rowCount=99)
                  :     :     :                 +- Relation[d_date_sk#89,d_date_id#90,d_date#91,d_month_seq#92,d_week_seq#93,d_quarter_seq#94,d_year#95,d_dow#96,d_moy#97,d_dom#98,d_qoy#99,d_fy_year#100,d_fy_quarter_seq#101,d_fy_week_seq#102,d_day_name#103,d_quarter_name#104,d_holiday#105,d_weekend#106,d_following_holiday#107,d_first_dom#108,d_last_dom#109,d_same_day_ly#110,d_same_day_lq#111,d_current_day#112,... 4 more fields] parquet, Statistics(sizeInBytes=17.6 MiB, rowCount=7.30E+4)
                  :     :     +- Project [ss_customer_sk#154 AS customer_sk#8], Statistics(sizeInBytes=183.1 MiB, rowCount=1.60E+7)
                  :     :        +- Join Inner, (ss_sold_date_sk#151 = d_date_sk#89), Statistics(sizeInBytes=305.2 MiB, rowCount=1.60E+7)
                  :     :           :- Project [ss_sold_date_sk#151, ss_customer_sk#154], Statistics(sizeInBytes=3.9 GiB, rowCount=2.63E+8)
                  :     :           :  +- Filter (isnotnull(ss_sold_date_sk#151) AND isnotnull(ss_customer_sk#154)), Statistics(sizeInBytes=36.2 GiB, rowCount=2.63E+8)
                  :     :           :     +- Relation[ss_sold_date_sk#151,ss_sold_time_sk#152,ss_item_sk#153,ss_customer_sk#154,ss_cdemo_sk#155,ss_hdemo_sk#156,ss_addr_sk#157,ss_store_sk#158,ss_promo_sk#159,ss_ticket_number#160,ss_quantity#161,ss_wholesale_cost#162,ss_list_price#163,ss_sales_price#164,ss_ext_discount_amt#165,ss_ext_sales_price#166,ss_ext_wholesale_cost#167,ss_ext_list_price#168,ss_ext_tax#169,ss_coupon_amt#170,ss_net_paid#171,ss_net_paid_inc_tax#172,ss_net_profit#173] parquet, Statistics(sizeInBytes=39.7 GiB, rowCount=2.88E+8)
                  :     :           +- Project [d_date_sk#89], Statistics(sizeInBytes=1188.0 B, rowCount=99)
                  :     :              +- Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89)), Statistics(sizeInBytes=24.4 KiB, rowCount=99)
                  :     :                 +- Relation[d_date_sk#89,d_date_id#90,d_date#91,d_month_seq#92,d_week_seq#93,d_quarter_seq#94,d_year#95,d_dow#96,d_moy#97,d_dom#98,d_qoy#99,d_fy_year#100,d_fy_quarter_seq#101,d_fy_week_seq#102,d_day_name#103,d_quarter_name#104,d_holiday#105,d_weekend#106,d_following_holiday#107,d_first_dom#108,d_last_dom#109,d_same_day_ly#110,d_same_day_lq#111,d_current_day#112,... 4 more fields] parquet, Statistics(sizeInBytes=17.6 MiB, rowCount=7.30E+4)
                  :     +- Project [ca_address_sk#33], Statistics(sizeInBytes=11.4 MiB, rowCount=1.00E+6)
                  :        +- Filter (staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, varcharTypeReadSideCheck, ca_county#40, 30, false, true) IN (Walker County,Richland County,Gaines County,Douglas County,Dona Ana County) AND isnotnull(ca_address_sk#33)), Statistics(sizeInBytes=233.7 MiB, rowCount=1.00E+6)
                  :           +- Relation[ca_address_sk#33,ca_address_id#34,ca_street_number#35,ca_street_name#36,ca_street_type#37,ca_suite_number#38,ca_city#39,ca_county#40,ca_state#41,ca_zip#42,ca_country#43,ca_gmt_offset#44,ca_location_type#45] parquet, Statistics(sizeInBytes=233.7 MiB, rowCount=1.00E+6)
                  +- Project [cd_demo_sk#46, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_gender#47, 1, false, true) AS cd_gender#305, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_marital_status#48, 1, false, true) AS cd_marital_status#306, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_education_status#49, 20, false, true) AS cd_education_status#307, cd_purchase_estimate#50, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_credit_rating#51, 10, false, true) AS cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], Statistics(sizeInBytes=174.0 MiB, rowCount=1.92E+6)
                     +- Filter isnotnull(cd_demo_sk#46), Statistics(sizeInBytes=174.0 MiB, rowCount=1.92E+6)
                        +- Relation[cd_demo_sk#46,cd_gender#47,cd_marital_status#48,cd_education_status#49,cd_purchase_estimate#50,cd_credit_rating#51,cd_dep_count#52,cd_dep_employed_count#53,cd_dep_college_count#54] parquet, Statistics(sizeInBytes=174.0 MiB, rowCount=1.92E+6)
   
   == Physical Plan ==
   TakeOrderedAndProject(limit=100, orderBy=[cd_gender#305 ASC NULLS FIRST,cd_marital_status#306 ASC NULLS FIRST,cd_education_status#307 ASC NULLS FIRST,cd_purchase_estimate#50 ASC NULLS FIRST,cd_credit_rating#308 ASC NULLS FIRST,cd_dep_count#52 ASC NULLS FIRST,cd_dep_employed_count#53 ASC NULLS FIRST,cd_dep_college_count#54 ASC NULLS FIRST], output=[cd_gender#305,cd_marital_status#306,cd_education_status#307,cnt1#0L,cd_purchase_estimate#50,cnt2#1L,cd_credit_rating#308,cnt3#2L,cd_dep_count#52,cnt4#3L,cd_dep_employed_count#53,cnt5#4L,cd_dep_college_count#54,cnt6#5L])
   +- *(20) HashAggregate(keys=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], functions=[count(1)], output=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cnt1#0L, cd_purchase_estimate#50, cnt2#1L, cd_credit_rating#308, cnt3#2L, cd_dep_count#52, cnt4#3L, cd_dep_employed_count#53, cnt5#4L, cd_dep_college_count#54, cnt6#5L])
      +- Exchange hashpartitioning(cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54, 5), ENSURE_REQUIREMENTS, [id=#537]
         +- *(19) HashAggregate(keys=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54], functions=[partial_count(1)], output=[cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54, count#357L])
            +- *(19) Project [cd_gender#305, cd_marital_status#306, cd_education_status#307, cd_purchase_estimate#50, cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54]
               +- *(19) SortMergeJoin [c_current_cdemo_sk#17], [cd_demo_sk#46], Inner
                  :- *(16) Sort [c_current_cdemo_sk#17 ASC NULLS FIRST], false, 0
                  :  +- Exchange hashpartitioning(c_current_cdemo_sk#17, 5), ENSURE_REQUIREMENTS, [id=#528]
                  :     +- *(15) Project [c_current_cdemo_sk#17]
                  :        +- *(15) SortMergeJoin [c_current_addr_sk#19], [ca_address_sk#33], Inner
                  :           :- *(12) Sort [c_current_addr_sk#19 ASC NULLS FIRST], false, 0
                  :           :  +- Exchange hashpartitioning(c_current_addr_sk#19, 5), ENSURE_REQUIREMENTS, [id=#520]
                  :           :     +- *(11) Project [c_current_cdemo_sk#17, c_current_addr_sk#19]
                  :           :        +- SortMergeJoin [c_customer_sk#15], [customer_sk#8], LeftSemi
                  :           :           :- SortMergeJoin [c_customer_sk#15], [customer_sk#6], LeftSemi
                  :           :           :  :- *(2) Sort [c_customer_sk#15 ASC NULLS FIRST], false, 0
                  :           :           :  :  +- Exchange hashpartitioning(c_customer_sk#15, 5), ENSURE_REQUIREMENTS, [id=#332]
                  :           :           :  :     +- *(1) Filter ((isnotnull(c_customer_sk#15) AND isnotnull(c_current_addr_sk#19)) AND isnotnull(c_current_cdemo_sk#17))
                  :           :           :  :        +- *(1) ColumnarToRow
                  :           :           :  :           +- FileScan parquet default.customer[c_customer_sk#15,c_current_cdemo_sk#17,c_current_addr_sk#19] Batched: true, DataFilters: [isnotnull(c_customer_sk#15), isnotnull(c_current_addr_sk#19), isnotnull(c_current_cdemo_sk#17)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(c_customer_sk), IsNotNull(c_current_addr_sk), IsNotNull(c_current_cdemo_sk)], ReadSchema: struct<c_customer_sk:int,c_current_cdemo_sk:int,c_current_addr_sk:int>
                  :           :           :  +- *(7) Sort [customer_sk#6 ASC NULLS FIRST], false, 0
                  :           :           :     +- Exchange hashpartitioning(customer_sk#6, 5), ENSURE_REQUIREMENTS, [id=#455]
                  :           :           :        +- Union
                  :           :           :           :- *(4) Project [ws_bill_customer_sk#59 AS customer_sk#6]
                  :           :           :           :  +- *(4) BroadcastHashJoin [ws_sold_date_sk#55], [d_date_sk#89], Inner, BuildRight, false
                  :           :           :           :     :- *(4) Filter (isnotnull(ws_sold_date_sk#55) AND isnotnull(ws_bill_customer_sk#59))
                  :           :           :           :     :  +- *(4) ColumnarToRow
                  :           :           :           :     :     +- FileScan parquet default.web_sales[ws_sold_date_sk#55,ws_bill_customer_sk#59] Batched: true, DataFilters: [isnotnull(ws_sold_date_sk#55), isnotnull(ws_bill_customer_sk#59)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(ws_sold_date_sk), IsNotNull(ws_bill_customer_sk)], ReadSchema: struct<ws_sold_date_sk:int,ws_bill_customer_sk:int>
                  :           :           :           :     +- BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [id=#344]
                  :           :           :           :        +- *(3) Project [d_date_sk#89]
                  :           :           :           :           +- *(3) Filter (((((isnotnull(d_year#95) AND isnotnull(d_moy#97)) AND (d_year#95 = 2002)) AND (d_moy#97 >= 4)) AND (d_moy#97 <= 7)) AND isnotnull(d_date_sk#89))
                  :           :           :           :              +- *(3) ColumnarToRow
                  :           :           :           :                 +- FileScan parquet default.date_dim[d_date_sk#89,d_year#95,d_moy#97] Batched: true, DataFilters: [isnotnull(d_year#95), isnotnull(d_moy#97), (d_year#95 = 2002), (d_moy#97 >= 4), (d_moy#97 <= 7),..., Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(d_year), IsNotNull(d_moy), EqualTo(d_year,2002), GreaterThanOrEqual(d_moy,4), LessThan..., ReadSchema: struct<d_date_sk:int,d_year:int,d_moy:int>
                  :           :           :           +- *(6) Project [cs_ship_customer_sk#124 AS customer_sk#7]
                  :           :           :              +- *(6) BroadcastHashJoin [cs_sold_date_sk#117], [d_date_sk#89], Inner, BuildRight, false
                  :           :           :                 :- *(6) Filter (isnotnull(cs_sold_date_sk#117) AND isnotnull(cs_ship_customer_sk#124))
                  :           :           :                 :  +- *(6) ColumnarToRow
                  :           :           :                 :     +- FileScan parquet default.catalog_sales[cs_sold_date_sk#117,cs_ship_customer_sk#124] Batched: true, DataFilters: [isnotnull(cs_sold_date_sk#117), isnotnull(cs_ship_customer_sk#124)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(cs_sold_date_sk), IsNotNull(cs_ship_customer_sk)], ReadSchema: struct<cs_sold_date_sk:int,cs_ship_customer_sk:int>
                  :           :           :                 +- ReusedExchange [d_date_sk#89], BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [id=#344]
                  :           :           +- *(10) Sort [customer_sk#8 ASC NULLS FIRST], false, 0
                  :           :              +- Exchange hashpartitioning(customer_sk#8, 5), ENSURE_REQUIREMENTS, [id=#474]
                  :           :                 +- *(9) Project [ss_customer_sk#154 AS customer_sk#8]
                  :           :                    +- *(9) BroadcastHashJoin [ss_sold_date_sk#151], [d_date_sk#89], Inner, BuildRight, false
                  :           :                       :- *(9) Filter (isnotnull(ss_sold_date_sk#151) AND isnotnull(ss_customer_sk#154))
                  :           :                       :  +- *(9) ColumnarToRow
                  :           :                       :     +- FileScan parquet default.store_sales[ss_sold_date_sk#151,ss_customer_sk#154] Batched: true, DataFilters: [isnotnull(ss_sold_date_sk#151), isnotnull(ss_customer_sk#154)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(ss_sold_date_sk), IsNotNull(ss_customer_sk)], ReadSchema: struct<ss_sold_date_sk:int,ss_customer_sk:int>
                  :           :                       +- ReusedExchange [d_date_sk#89], BroadcastExchange HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)),false), [id=#344]
                  :           +- *(14) Sort [ca_address_sk#33 ASC NULLS FIRST], false, 0
                  :              +- Exchange hashpartitioning(ca_address_sk#33, 5), ENSURE_REQUIREMENTS, [id=#399]
                  :                 +- *(13) Project [ca_address_sk#33]
                  :                    +- *(13) Filter (staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, varcharTypeReadSideCheck, ca_county#40, 30, false, true) IN (Walker County,Richland County,Gaines County,Douglas County,Dona Ana County) AND isnotnull(ca_address_sk#33))
                  :                       +- *(13) ColumnarToRow
                  :                          +- FileScan parquet default.customer_address[ca_address_sk#33,ca_county#40] Batched: true, DataFilters: [staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, varch..., Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(ca_address_sk)], ReadSchema: struct<ca_address_sk:int,ca_county:string>
                  +- *(18) Sort [cd_demo_sk#46 ASC NULLS FIRST], false, 0
                     +- Exchange hashpartitioning(cd_demo_sk#46, 5), ENSURE_REQUIREMENTS, [id=#417]
                        +- *(17) Project [cd_demo_sk#46, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_gender#47, 1, false, true) AS cd_gender#305, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_marital_status#48, 1, false, true) AS cd_marital_status#306, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_education_status#49, 20, false, true) AS cd_education_status#307, cd_purchase_estimate#50, staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, charTypeReadSideCheck, cd_credit_rating#51, 10, false, true) AS cd_credit_rating#308, cd_dep_count#52, cd_dep_employed_count#53, cd_dep_college_count#54]
                           +- *(17) Filter isnotnull(cd_demo_sk#46)
                              +- *(17) ColumnarToRow
                                 +- FileScan parquet default.customer_demographics[cd_demo_sk#46,cd_gender#47,cd_marital_status#48,cd_education_status#49,cd_purchase_estimate#50,cd_credit_rating#51,cd_dep_count#52,cd_dep_employed_count#53,cd_dep_college_count#54] Batched: true, DataFilters: [isnotnull(cd_demo_sk#46)], Format: Parquet, Location: InMemoryFileIndex[file:/Users/kentyao/spark/spark-warehouse/org.apache.spark.sql.TPCDSModifiedPla..., PartitionFilters: [], PushedFilters: [IsNotNull(cd_demo_sk)], ReadSchema: struct<cd_demo_sk:int,cd_gender:string,cd_marital_status:string,cd_education_status:string,cd_pur...
   
   ````


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-761235955


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134121/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763836658


   **[Test build #134290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134290/testReport)** for PR 31012 at commit [`7502623`](https://github.com/apache/spark/commit/750262351920e1bdb82ef91a6b3c9624a8bbcba0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763898650






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767480669


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134486/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758057252


   **[Test build #133928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133928/testReport)** for PR 31012 at commit [`7078573`](https://github.com/apache/spark/commit/70785738a12b2b713fe11b63ba79a5680e3aa6ab).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-755159181


   **[Test build #133722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133722/testReport)** for PR 31012 at commit [`021d3bb`](https://github.com/apache/spark/commit/021d3bb27fda67bc2962fcf84ad27c48c3a84143).
    * This patch **fails Spark unit tests**.
    * This patch **does not merge cleanly**.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767700136


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39092/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764529029


   **[Test build #134330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134330/testReport)** for PR 31012 at commit [`4635070`](https://github.com/apache/spark/commit/4635070dedfc0453737bec7ce9b158c7bc620796).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r564611013



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q27.sf100/explain.txt
##########
@@ -128,15 +128,15 @@ Input [9]: [ss_item_sk#1, ss_cdemo_sk#2, ss_store_sk#3, ss_quantity#4, ss_list_p
 Output [4]: [cd_demo_sk#13, cd_gender#14, cd_marital_status#15, cd_education_status#16]
 Batched: true
 Location [not included in comparison]/{warehouse_dir}/customer_demographics]
-PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary), IsNotNull(cd_demo_sk)]
+PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary             ), IsNotNull(cd_demo_sk)]

Review comment:
       `cd_education_status` is char type, which means the data of it in the storage are always padded as fixed-length strings. While before it's string type and doesn't have this issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758067330


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133928/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767605270


   I have updated the PR desc and the LOC is reduced from about 50K in the very first push to 500 with a series of PRs. The plans look OK to me now.
   I'd like you guys to review this again. Thanks very much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-755177119






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764576764


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38916/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767751054


   **[Test build #134506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134506/testReport)** for PR 31012 at commit [`1aa22f0`](https://github.com/apache/spark/commit/1aa22f055db370e77e506403666000e8e1e19f9c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-762896112


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134222/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758595351


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38551/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-757985408


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38515/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-761085200


   **[Test build #134121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134121/testReport)** for PR 31012 at commit [`9d5ed31`](https://github.com/apache/spark/commit/9d5ed315352bd2887766f59f6a27ab76eac355b8).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758573166


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38551/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560053593



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/explain.txt
##########
@@ -200,87 +207,115 @@ Left keys [1]: [c_customer_sk#1]
 Right keys [1]: [customer_sk#18]
 Join condition: None
 
-(35) Project [codegen id : 12]
+(35) Project [codegen id : 11]
 Output [2]: [c_current_cdemo_sk#2, c_current_addr_sk#3]
 Input [3]: [c_customer_sk#1, c_current_cdemo_sk#2, c_current_addr_sk#3]
 
-(36) Scan parquet default.customer_address
-Output [2]: [ca_address_sk#20, ca_county#21]
+(36) Exchange
+Input [2]: [c_current_cdemo_sk#2, c_current_addr_sk#3]
+Arguments: hashpartitioning(c_current_addr_sk#3, 5), ENSURE_REQUIREMENTS, [id=#20]
+
+(37) Sort [codegen id : 12]
+Input [2]: [c_current_cdemo_sk#2, c_current_addr_sk#3]
+Arguments: [c_current_addr_sk#3 ASC NULLS FIRST], false, 0
+
+(38) Scan parquet default.customer_address
+Output [2]: [ca_address_sk#21, ca_county#22]
 Batched: true
 Location [not included in comparison]/{warehouse_dir}/customer_address]
-PushedFilters: [In(ca_county, [Walker County,Richland County,Gaines County,Douglas County,Dona Ana County]), IsNotNull(ca_address_sk)]
+PushedFilters: [IsNotNull(ca_address_sk)]
 ReadSchema: struct<ca_address_sk:int,ca_county:string>
 
-(37) ColumnarToRow [codegen id : 11]
-Input [2]: [ca_address_sk#20, ca_county#21]
+(39) ColumnarToRow [codegen id : 13]
+Input [2]: [ca_address_sk#21, ca_county#22]
 
-(38) Filter [codegen id : 11]
-Input [2]: [ca_address_sk#20, ca_county#21]
-Condition : (ca_county#21 IN (Walker County,Richland County,Gaines County,Douglas County,Dona Ana County) AND isnotnull(ca_address_sk#20))
+(40) Filter [codegen id : 13]
+Input [2]: [ca_address_sk#21, ca_county#22]
+Condition : (staticinvoke(class org.apache.spark.sql.catalyst.util.CharVarcharCodegenUtils, StringType, varcharTypeReadSideCheck, ca_county#22, 30, false, true) IN (Walker County,Richland County,Gaines County,Douglas County,Dona Ana County) AND isnotnull(ca_address_sk#21))

Review comment:
       not looks pretty




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763898650






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758532572


   **[Test build #133964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133964/testReport)** for PR 31012 at commit [`1145e67`](https://github.com/apache/spark/commit/1145e677dcb48515668cf51d349e6f256c5e2ac5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-768168458


   thanks, merging to master/3.1! (since it's mostly test-only)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-755105355


   **[Test build #133722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133722/testReport)** for PR 31012 at commit [`021d3bb`](https://github.com/apache/spark/commit/021d3bb27fda67bc2962fcf84ad27c48c3a84143).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-757959424


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38515/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r599533051



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` CHAR(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` VARCHAR(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` CHAR(20),
+        |`s_manager` VARCHAR(40),
+        |`s_market_id` INT,
+        |`s_geography_class` VARCHAR(100),
+        |`s_market_desc` VARCHAR(100),
+        |`s_market_manager` VARCHAR(40),
+        |`s_division_id` INT,
+        |`s_division_name` VARCHAR(50),
+        |`s_company_id` INT,
+        |`s_company_name` VARCHAR(50),
+        |`s_street_number` VARCHAR(10),
+        |`s_street_name` VARCHAR(60),
+        |`s_street_type` CHAR(15),
+        |`s_suite_number` CHAR(10),
+        |`s_city` VARCHAR(60),
+        |`s_county` VARCHAR(30),
+        |`s_state` CHAR(2),
+        |`s_zip` CHAR(10),
+        |`s_country` VARCHAR(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` CHAR(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` VARCHAR(50),
+        |`cc_class` VARCHAR(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` CHAR(20),
+        |`cc_manager` VARCHAR(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` CHAR(50),
+        |`cc_mkt_desc` VARCHAR(100),
+        |`cc_market_manager` VARCHAR(40),
+        |`cc_division` INT,
+        |`cc_division_name` VARCHAR(50),
+        |`cc_company` INT,
+        |`cc_company_name` CHAR(50),
+        |`cc_street_number` CHAR(10),
+        |`cc_street_name` VARCHAR(60),
+        |`cc_street_type` CHAR(15),
+        |`cc_suite_number` CHAR(10),
+        |`cc_city` VARCHAR(60),
+        |`cc_county` VARCHAR(30),
+        |`cc_state` CHAR(2),
+        |`cc_zip` CHAR(10),
+        |`cc_country` VARCHAR(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` CHAR(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` VARCHAR(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` VARCHAR(100),
+        |`cp_type` VARCHAR(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` CHAR(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` VARCHAR(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` VARCHAR(50),
+        |`web_manager` VARCHAR(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` VARCHAR(50),
+        |`web_mkt_desc` VARCHAR(100),
+        |`web_market_manager` VARCHAR(40),
+        |`web_company_id` INT,
+        |`web_company_name` CHAR(50),
+        |`web_street_number` CHAR(10),
+        |`web_street_name` VARCHAR(60),
+        |`web_street_type` CHAR(15),
+        |`web_suite_number` CHAR(10),
+        |`web_city` VARCHAR(60),
+        |`web_county` VARCHAR(30),
+        |`web_state` CHAR(2),
+        |`web_zip` CHAR(10),
+        |`web_country` VARCHAR(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` CHAR(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` CHAR(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` VARCHAR(100),
+        |`wp_type` CHAR(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` CHAR(16),
+        |`w_warehouse_name` VARCHAR(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` CHAR(10),
+        |`w_street_name` VARCHAR(20),
+        |`w_street_type` CHAR(15),
+        |`w_suite_number` CHAR(10),
+        |`w_city` VARCHAR(60),
+        |`w_county` VARCHAR(30),
+        |`w_state` CHAR(2),
+        |`w_zip` CHAR(10),
+        |`w_country` VARCHAR(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` CHAR(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` CHAR(10),
+        |`c_first_name` CHAR(20),
+        |`c_last_name` CHAR(30),
+        |`c_preferred_cust_flag` CHAR(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` VARCHAR(20),
+        |`c_login` CHAR(13),
+        |`c_email_address` CHAR(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` CHAR(16),
+        |`ca_street_number` CHAR(10),
+        |`ca_street_name` VARCHAR(60),
+        |`ca_street_type` CHAR(15),
+        |`ca_suite_number` CHAR(10),
+        |`ca_city` VARCHAR(60),
+        |`ca_county` VARCHAR(30),
+        |`ca_state` CHAR(2),
+        |`ca_zip` CHAR(10),
+        |`ca_country` VARCHAR(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` CHAR(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` CHAR(1),
+        |`cd_marital_status` CHAR(1),
+        |`cd_education_status` CHAR(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` CHAR(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` CHAR(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` CHAR(9),
+        |`d_quarter_name` CHAR(1),

Review comment:
       https://github.com/apache/spark/pull/31943




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-755177119






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560704741



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/simplified.txt
##########
@@ -1,81 +1,100 @@
 TakeOrderedAndProject [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,cnt1,cnt2,cnt3,cnt4,cnt5,cnt6]
-  WholeStageCodegen (14)
+  WholeStageCodegen (20)
     HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,count] [count(1),cnt1,cnt2,cnt3,cnt4,cnt5,cnt6,count]
       InputAdapter
         Exchange [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] #1
-          WholeStageCodegen (13)
+          WholeStageCodegen (19)
             HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] [count,count]
               Project [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
-                BroadcastHashJoin [c_current_cdemo_sk,cd_demo_sk]
+                SortMergeJoin [c_current_cdemo_sk,cd_demo_sk]

Review comment:
       Oh..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754341569


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38199/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-757923004


   **[Test build #133928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133928/testReport)** for PR 31012 at commit [`7078573`](https://github.com/apache/spark/commit/70785738a12b2b713fe11b63ba79a5680e3aa6ab).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758596313


   **[Test build #133964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133964/testReport)** for PR 31012 at commit [`1145e67`](https://github.com/apache/spark/commit/1145e677dcb48515668cf51d349e6f256c5e2ac5).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560050954



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/simplified.txt
##########
@@ -1,81 +1,100 @@
 TakeOrderedAndProject [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,cnt1,cnt2,cnt3,cnt4,cnt5,cnt6]
-  WholeStageCodegen (14)
+  WholeStageCodegen (20)
     HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,count] [count(1),cnt1,cnt2,cnt3,cnt4,cnt5,cnt6,count]
       InputAdapter
         Exchange [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] #1
-          WholeStageCodegen (13)
+          WholeStageCodegen (19)
             HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] [count,count]
               Project [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
-                BroadcastHashJoin [c_current_cdemo_sk,cd_demo_sk]
+                SortMergeJoin [c_current_cdemo_sk,cd_demo_sk]

Review comment:
       unexpected change @cloud-fan 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560618157



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` char(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` varchar(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` char(20),
+        |`s_manager` varchar(40),
+        |`s_market_id` INT,
+        |`s_geography_class` varchar(100),
+        |`s_market_desc` varchar(100),
+        |`s_market_manager` varchar(40),
+        |`s_division_id` INT,
+        |`s_division_name` varchar(50),
+        |`s_company_id` INT,
+        |`s_company_name` varchar(50),
+        |`s_street_number` varchar(10),
+        |`s_street_name` varchar(60),
+        |`s_street_type` char(15),
+        |`s_suite_number` char(10),
+        |`s_city` varchar(60),
+        |`s_county` varchar(30),
+        |`s_state` char(2),
+        |`s_zip` char(10),
+        |`s_country` varchar(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` char(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` varchar(50),
+        |`cc_class` varchar(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` char(20),
+        |`cc_manager` varchar(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` char(50),
+        |`cc_mkt_desc` varchar(100),
+        |`cc_market_manager` varchar(40),
+        |`cc_division` INT,
+        |`cc_division_name` varchar(50),
+        |`cc_company` INT,
+        |`cc_company_name` char(50),
+        |`cc_street_number` char(10),
+        |`cc_street_name` varchar(60),
+        |`cc_street_type` char(15),
+        |`cc_suite_number` char(10),
+        |`cc_city` varchar(60),
+        |`cc_county` varchar(30),
+        |`cc_state` char(2),
+        |`cc_zip` char(10),
+        |`cc_country` varchar(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` char(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` varchar(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` varchar(100),
+        |`cp_type` varchar(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` char(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` varchar(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` varchar(50),
+        |`web_manager` varchar(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` varchar(50),
+        |`web_mkt_desc` varchar(100),
+        |`web_market_manager` varchar(40),
+        |`web_company_id` INT,
+        |`web_company_name` char(50),
+        |`web_street_number` char(10),
+        |`web_street_name` varchar(60),
+        |`web_street_type` char(15),
+        |`web_suite_number` char(10),
+        |`web_city` varchar(60),
+        |`web_county` varchar(30),
+        |`web_state` char(2),
+        |`web_zip` char(10),
+        |`web_country` varchar(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` char(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` char(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` varchar(100),
+        |`wp_type` char(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` char(16),
+        |`w_warehouse_name` varchar(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` char(10),
+        |`w_street_name` varchar(20),
+        |`w_street_type` char(15),
+        |`w_suite_number` char(10),
+        |`w_city` varchar(60),
+        |`w_county` varchar(30),
+        |`w_state` char(2),
+        |`w_zip` char(10),
+        |`w_country` varchar(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` char(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` char(10),
+        |`c_first_name` char(20),
+        |`c_last_name` char(30),
+        |`c_preferred_cust_flag` char(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` varchar(20),
+        |`c_login` char(13),
+        |`c_email_address` char(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` char(16),
+        |`ca_street_number` char(10),
+        |`ca_street_name` varchar(60),
+        |`ca_street_type` char(15),
+        |`ca_suite_number` char(10),
+        |`ca_city` varchar(60),
+        |`ca_county` varchar(30),
+        |`ca_state` char(2),
+        |`ca_zip` char(10),
+        |`ca_country` varchar(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` char(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` char(1),
+        |`cd_marital_status` char(1),
+        |`cd_education_status` char(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` char(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` char(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` char(9),
+        |`d_quarter_name` char(1),
+        |`d_holiday` char(1),
+        |`d_weekend` char(1),
+        |`d_following_holiday` char(1),
+        |`d_first_dom` INT,
+        |`d_last_dom` INT,
+        |`d_same_day_ly` INT,
+        |`d_same_day_lq` INT,
+        |`d_current_day` char(1),
+        |`d_current_week` char(1),
+        |`d_current_month` char(1),
+        |`d_current_quarter` char(1),
+        |`d_current_year` char(1)
       """.stripMargin,
     "household_demographics" ->
       """
-        |`hd_demo_sk` INT, `hd_income_band_sk` INT, `hd_buy_potential` STRING, `hd_dep_count` INT,
+        |`hd_demo_sk` INT,
+        |`hd_income_band_sk` INT,
+        |`hd_buy_potential` char(15),
+        |`hd_dep_count` INT,
         |`hd_vehicle_count` INT
       """.stripMargin,
     "item" ->
       """
-        |`i_item_sk` INT, `i_item_id` STRING, `i_rec_start_date` DATE,
-        |`i_rec_end_date` DATE, `i_item_desc` STRING, `i_current_price` DECIMAL(7,2),
-        |`i_wholesale_cost` DECIMAL(7,2), `i_brand_id` INT, `i_brand` STRING, `i_class_id` INT,
-        |`i_class` STRING, `i_category_id` INT, `i_category` STRING, `i_manufact_id` INT,
-        |`i_manufact` STRING, `i_size` STRING, `i_formulation` STRING, `i_color` STRING,
-        |`i_units` STRING, `i_container` STRING, `i_manager_id` INT, `i_product_name` STRING
+        |`i_item_sk` INT,
+        |`i_item_id` char(16),
+        |`i_rec_start_date` DATE,
+        |`i_rec_end_date` DATE,
+        |`i_item_desc` varchar(200),
+        |`i_current_price` DECIMAL(7,2),
+        |`i_wholesale_cost` DECIMAL(7,2),
+        |`i_brand_id` INT,
+        |`i_brand` char(50),
+        |`i_class_id` INT,
+        |`i_class` char(50),
+        |`i_category_id` INT,
+        |`i_category` char(50),
+        |`i_manufact_id` INT,
+        |`i_manufact` char(50),
+        |`i_size` char(20),
+        |`i_formulation` char(20),
+        |`i_color` char(20),
+        |`i_units` char(10),
+        |`i_container` char(10),
+        |`i_manager_id` INT,
+        |`i_product_name` char(50)
       """.stripMargin,
     "income_band" ->
       """
-        |`ib_income_band_sk` INT, `ib_lower_bound` INT, `ib_upper_bound` INT
+        |`ib_income_band_sk` INT,
+        |`ib_lower_bound` INT,
+        |`ib_upper_bound` INT
       """.stripMargin,
     "promotion" ->
       """
-        |`p_promo_sk` INT, `p_promo_id` STRING, `p_start_date_sk` INT, `p_end_date_sk` INT,
-        |`p_item_sk` INT, `p_cost` DECIMAL(15,2), `p_response_target` INT, `p_promo_name` STRING,
-        |`p_channel_dmail` STRING, `p_channel_email` STRING, `p_channel_catalog` STRING,
-        |`p_channel_tv` STRING, `p_channel_radio` STRING, `p_channel_press` STRING,
-        |`p_channel_event` STRING, `p_channel_demo` STRING, `p_channel_details` STRING,
-        |`p_purpose` STRING, `p_discount_active` STRING
+        |`p_promo_sk` INT,
+        |`p_promo_id` char(16),
+        |`p_start_date_sk` INT,
+        |`p_end_date_sk` INT,
+        |`p_item_sk` INT,
+        |`p_cost` DECIMAL(15,2),
+        |`p_response_target` INT,
+        |`p_promo_name` char(50),
+        |`p_channel_dmail` char(1),
+        |`p_channel_email` char(1),
+        |`p_channel_catalog` char(1),
+        |`p_channel_tv` char(1),
+        |`p_channel_radio` char(1),
+        |`p_channel_press` char(1),
+        |`p_channel_event` char(1),
+        |`p_channel_demo` char(1),
+        |`p_channel_details` varchar(100),
+        |`p_purpose` char(15),
+        |`p_discount_active` char(1)
       """.stripMargin,
     "reason" ->
       """
-        |`r_reason_sk` INT, `r_reason_id` STRING, `r_reason_desc` STRING
+        |`r_reason_sk` INT,
+        |`r_reason_id` char(16),
+        |`r_reason_desc` char(100)
       """.stripMargin,
     "ship_mode" ->
       """
-        |`sm_ship_mode_sk` INT, `sm_ship_mode_id` STRING, `sm_type` STRING, `sm_code` STRING,
-        |`sm_carrier` STRING, `sm_contract` STRING
+        |`sm_ship_mode_sk` INT,
+        |`sm_ship_mode_id` char(16),
+        |`sm_type` char(30),
+        |`sm_code` char(10),
+        |`sm_carrier` char(20),
+        |`sm_contract` char(20)
       """.stripMargin,
     "time_dim" ->
       """
-        |`t_time_sk` INT, `t_time_id` STRING, `t_time` INT, `t_hour` INT, `t_minute` INT,
-        |`t_second` INT, `t_am_pm` STRING, `t_shift` STRING, `t_sub_shift` STRING,
-        |`t_meal_time` STRING
+        |`t_time_sk` INT,
+        |`t_time_id` char(16),
+        |`t_time` INT,
+        |`t_hour` INT,
+        |`t_minute` INT,
+        |`t_second` INT,
+        |`t_am_pm` char(2),
+        |`t_shift` char(20),
+        |`t_sub_shift` char(20),
+        |`t_meal_time` char(20)

Review comment:
       nit: `char` -> `CHAR`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763836658


   **[Test build #134290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134290/testReport)** for PR 31012 at commit [`7502623`](https://github.com/apache/spark/commit/750262351920e1bdb82ef91a6b3c9624a8bbcba0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r560628135



##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/simplified.txt
##########
@@ -1,81 +1,100 @@
 TakeOrderedAndProject [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,cnt1,cnt2,cnt3,cnt4,cnt5,cnt6]
-  WholeStageCodegen (14)
+  WholeStageCodegen (20)
     HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count,count] [count(1),cnt1,cnt2,cnt3,cnt4,cnt5,cnt6,count]
       InputAdapter
         Exchange [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] #1
-          WholeStageCodegen (13)
+          WholeStageCodegen (19)
             HashAggregate [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count] [count,count]
               Project [cd_gender,cd_marital_status,cd_education_status,cd_purchase_estimate,cd_credit_rating,cd_dep_count,cd_dep_employed_count,cd_dep_college_count]
-                BroadcastHashJoin [c_current_cdemo_sk,cd_demo_sk]
+                SortMergeJoin [c_current_cdemo_sk,cd_demo_sk]

Review comment:
       I gonna take a look at this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767579479


   **[Test build #134506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134506/testReport)** for PR 31012 at commit [`1aa22f0`](https://github.com/apache/spark/commit/1aa22f055db370e77e506403666000e8e1e19f9c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767773607


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134506/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758067330


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133928/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-762896112


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134222/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-754319648


   **[Test build #133610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133610/testReport)** for PR 31012 at commit [`4affca9`](https://github.com/apache/spark/commit/4affca9252f4298fe96fa873ff10234ba0e79bc3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763898648






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [WIP][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-755145932


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38310/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763271630


   Could you check the other DDL definition for ssb (`SSBQuerySuite`) and tpc-h (`TPCHQuerySuite`)? We need the same change there, too?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758532572


   **[Test build #133964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133964/testReport)** for PR 31012 at commit [`1145e67`](https://github.com/apache/spark/commit/1145e677dcb48515668cf51d349e6f256c5e2ac5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767678060


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39092/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-763266612


   IIUC our TPCDS queries refer to v1.4 and v2.7. These DDL stmts are the same with v2.9 ones?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r599448533



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` CHAR(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` VARCHAR(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` CHAR(20),
+        |`s_manager` VARCHAR(40),
+        |`s_market_id` INT,
+        |`s_geography_class` VARCHAR(100),
+        |`s_market_desc` VARCHAR(100),
+        |`s_market_manager` VARCHAR(40),
+        |`s_division_id` INT,
+        |`s_division_name` VARCHAR(50),
+        |`s_company_id` INT,
+        |`s_company_name` VARCHAR(50),
+        |`s_street_number` VARCHAR(10),
+        |`s_street_name` VARCHAR(60),
+        |`s_street_type` CHAR(15),
+        |`s_suite_number` CHAR(10),
+        |`s_city` VARCHAR(60),
+        |`s_county` VARCHAR(30),
+        |`s_state` CHAR(2),
+        |`s_zip` CHAR(10),
+        |`s_country` VARCHAR(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` CHAR(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` VARCHAR(50),
+        |`cc_class` VARCHAR(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` CHAR(20),
+        |`cc_manager` VARCHAR(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` CHAR(50),
+        |`cc_mkt_desc` VARCHAR(100),
+        |`cc_market_manager` VARCHAR(40),
+        |`cc_division` INT,
+        |`cc_division_name` VARCHAR(50),
+        |`cc_company` INT,
+        |`cc_company_name` CHAR(50),
+        |`cc_street_number` CHAR(10),
+        |`cc_street_name` VARCHAR(60),
+        |`cc_street_type` CHAR(15),
+        |`cc_suite_number` CHAR(10),
+        |`cc_city` VARCHAR(60),
+        |`cc_county` VARCHAR(30),
+        |`cc_state` CHAR(2),
+        |`cc_zip` CHAR(10),
+        |`cc_country` VARCHAR(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` CHAR(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` VARCHAR(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` VARCHAR(100),
+        |`cp_type` VARCHAR(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` CHAR(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` VARCHAR(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` VARCHAR(50),
+        |`web_manager` VARCHAR(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` VARCHAR(50),
+        |`web_mkt_desc` VARCHAR(100),
+        |`web_market_manager` VARCHAR(40),
+        |`web_company_id` INT,
+        |`web_company_name` CHAR(50),
+        |`web_street_number` CHAR(10),
+        |`web_street_name` VARCHAR(60),
+        |`web_street_type` CHAR(15),
+        |`web_suite_number` CHAR(10),
+        |`web_city` VARCHAR(60),
+        |`web_county` VARCHAR(30),
+        |`web_state` CHAR(2),
+        |`web_zip` CHAR(10),
+        |`web_country` VARCHAR(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` CHAR(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` CHAR(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` VARCHAR(100),
+        |`wp_type` CHAR(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` CHAR(16),
+        |`w_warehouse_name` VARCHAR(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` CHAR(10),
+        |`w_street_name` VARCHAR(20),
+        |`w_street_type` CHAR(15),
+        |`w_suite_number` CHAR(10),
+        |`w_city` VARCHAR(60),
+        |`w_county` VARCHAR(30),
+        |`w_state` CHAR(2),
+        |`w_zip` CHAR(10),
+        |`w_country` VARCHAR(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` CHAR(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` CHAR(10),
+        |`c_first_name` CHAR(20),
+        |`c_last_name` CHAR(30),
+        |`c_preferred_cust_flag` CHAR(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` VARCHAR(20),
+        |`c_login` CHAR(13),
+        |`c_email_address` CHAR(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` CHAR(16),
+        |`ca_street_number` CHAR(10),
+        |`ca_street_name` VARCHAR(60),
+        |`ca_street_type` CHAR(15),
+        |`ca_suite_number` CHAR(10),
+        |`ca_city` VARCHAR(60),
+        |`ca_county` VARCHAR(30),
+        |`ca_state` CHAR(2),
+        |`ca_zip` CHAR(10),
+        |`ca_country` VARCHAR(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` CHAR(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` CHAR(1),
+        |`cd_marital_status` CHAR(1),
+        |`cd_education_status` CHAR(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` CHAR(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` CHAR(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` CHAR(9),
+        |`d_quarter_name` CHAR(1),

Review comment:
       I'll fix this in myPR #31886.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-767615626


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39092/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-764598629


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38916/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31012:
URL: https://github.com/apache/spark/pull/31012#discussion_r599455933



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -51,223 +51,499 @@ trait TPCDSBase extends SharedSparkSession {
   private val tableColumns = Map(
     "store_sales" ->
       """
-        |`ss_sold_date_sk` INT, `ss_sold_time_sk` INT, `ss_item_sk` INT, `ss_customer_sk` INT,
-        |`ss_cdemo_sk` INT, `ss_hdemo_sk` INT, `ss_addr_sk` INT, `ss_store_sk` INT,
-        |`ss_promo_sk` INT, `ss_ticket_number` INT, `ss_quantity` INT,
-        |`ss_wholesale_cost` DECIMAL(7,2), `ss_list_price` DECIMAL(7,2),
-        |`ss_sales_price` DECIMAL(7,2), `ss_ext_discount_amt` DECIMAL(7,2),
-        |`ss_ext_sales_price` DECIMAL(7,2), `ss_ext_wholesale_cost` DECIMAL(7,2),
-        |`ss_ext_list_price` DECIMAL(7,2), `ss_ext_tax` DECIMAL(7,2),
-        |`ss_coupon_amt` DECIMAL(7,2), `ss_net_paid` DECIMAL(7,2),
-        |`ss_net_paid_inc_tax` DECIMAL(7,2), `ss_net_profit` DECIMAL(7,2)
+        |`ss_sold_date_sk` INT,
+        |`ss_sold_time_sk` INT,
+        |`ss_item_sk` INT,
+        |`ss_customer_sk` INT,
+        |`ss_cdemo_sk` INT,
+        |`ss_hdemo_sk` INT,
+        |`ss_addr_sk` INT,
+        |`ss_store_sk` INT,
+        |`ss_promo_sk` INT,
+        |`ss_ticket_number` INT,
+        |`ss_quantity` INT,
+        |`ss_wholesale_cost` DECIMAL(7,2),
+        |`ss_list_price` DECIMAL(7,2),
+        |`ss_sales_price` DECIMAL(7,2),
+        |`ss_ext_discount_amt` DECIMAL(7,2),
+        |`ss_ext_sales_price` DECIMAL(7,2),
+        |`ss_ext_wholesale_cost` DECIMAL(7,2),
+        |`ss_ext_list_price` DECIMAL(7,2),
+        |`ss_ext_tax` DECIMAL(7,2),
+        |`ss_coupon_amt` DECIMAL(7,2),
+        |`ss_net_paid` DECIMAL(7,2),
+        |`ss_net_paid_inc_tax` DECIMAL(7,2),
+        |`ss_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "store_returns" ->
       """
-        |`sr_returned_date_sk` BIGINT, `sr_return_time_sk` BIGINT, `sr_item_sk` BIGINT,
-        |`sr_customer_sk` BIGINT, `sr_cdemo_sk` BIGINT, `sr_hdemo_sk` BIGINT, `sr_addr_sk` BIGINT,
-        |`sr_store_sk` BIGINT, `sr_reason_sk` BIGINT, `sr_ticket_number` BIGINT,
-        |`sr_return_quantity` INT, `sr_return_amt` DECIMAL(7,2), `sr_return_tax` DECIMAL(7,2),
-        |`sr_return_amt_inc_tax` DECIMAL(7,2), `sr_fee` DECIMAL(7,2),
-        |`sr_return_ship_cost` DECIMAL(7,2), `sr_refunded_cash` DECIMAL(7,2),
-        |`sr_reversed_charge` DECIMAL(7,2), `sr_store_credit` DECIMAL(7,2),
+        |`sr_returned_date_sk` BIGINT,
+        |`sr_return_time_sk` BIGINT,
+        |`sr_item_sk` BIGINT,
+        |`sr_customer_sk` BIGINT,
+        |`sr_cdemo_sk` BIGINT,
+        |`sr_hdemo_sk` BIGINT,
+        |`sr_addr_sk` BIGINT,
+        |`sr_store_sk` BIGINT,
+        |`sr_reason_sk` BIGINT,
+        |`sr_ticket_number` BIGINT,
+        |`sr_return_quantity` INT,
+        |`sr_return_amt` DECIMAL(7,2),
+        |`sr_return_tax` DECIMAL(7,2),
+        |`sr_return_amt_inc_tax` DECIMAL(7,2),
+        |`sr_fee` DECIMAL(7,2),
+        |`sr_return_ship_cost` DECIMAL(7,2),
+        |`sr_refunded_cash` DECIMAL(7,2),
+        |`sr_reversed_charge` DECIMAL(7,2),
+        |`sr_store_credit` DECIMAL(7,2),
         |`sr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "catalog_sales" ->
       """
-        |`cs_sold_date_sk` INT, `cs_sold_time_sk` INT, `cs_ship_date_sk` INT,
-        |`cs_bill_customer_sk` INT, `cs_bill_cdemo_sk` INT, `cs_bill_hdemo_sk` INT,
-        |`cs_bill_addr_sk` INT, `cs_ship_customer_sk` INT, `cs_ship_cdemo_sk` INT,
-        |`cs_ship_hdemo_sk` INT, `cs_ship_addr_sk` INT, `cs_call_center_sk` INT,
-        |`cs_catalog_page_sk` INT, `cs_ship_mode_sk` INT, `cs_warehouse_sk` INT,
-        |`cs_item_sk` INT, `cs_promo_sk` INT, `cs_order_number` INT, `cs_quantity` INT,
-        |`cs_wholesale_cost` DECIMAL(7,2), `cs_list_price` DECIMAL(7,2),
-        |`cs_sales_price` DECIMAL(7,2), `cs_ext_discount_amt` DECIMAL(7,2),
-        |`cs_ext_sales_price` DECIMAL(7,2), `cs_ext_wholesale_cost` DECIMAL(7,2),
-        |`cs_ext_list_price` DECIMAL(7,2), `cs_ext_tax` DECIMAL(7,2),
-        |`cs_coupon_amt` DECIMAL(7,2), `cs_ext_ship_cost` DECIMAL(7,2),
-        |`cs_net_paid` DECIMAL(7,2), `cs_net_paid_inc_tax` DECIMAL(7,2),
-        |`cs_net_paid_inc_ship` DECIMAL(7,2), `cs_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`cs_sold_date_sk` INT,
+        |`cs_sold_time_sk` INT,
+        |`cs_ship_date_sk` INT,
+        |`cs_bill_customer_sk` INT,
+        |`cs_bill_cdemo_sk` INT,
+        |`cs_bill_hdemo_sk` INT,
+        |`cs_bill_addr_sk` INT,
+        |`cs_ship_customer_sk` INT,
+        |`cs_ship_cdemo_sk` INT,
+        |`cs_ship_hdemo_sk` INT,
+        |`cs_ship_addr_sk` INT,
+        |`cs_call_center_sk` INT,
+        |`cs_catalog_page_sk` INT,
+        |`cs_ship_mode_sk` INT,
+        |`cs_warehouse_sk` INT,
+        |`cs_item_sk` INT,
+        |`cs_promo_sk` INT,
+        |`cs_order_number` INT,
+        |`cs_quantity` INT,
+        |`cs_wholesale_cost` DECIMAL(7,2),
+        |`cs_list_price` DECIMAL(7,2),
+        |`cs_sales_price` DECIMAL(7,2),
+        |`cs_ext_discount_amt` DECIMAL(7,2),
+        |`cs_ext_sales_price` DECIMAL(7,2),
+        |`cs_ext_wholesale_cost` DECIMAL(7,2),
+        |`cs_ext_list_price` DECIMAL(7,2),
+        |`cs_ext_tax` DECIMAL(7,2),
+        |`cs_coupon_amt` DECIMAL(7,2),
+        |`cs_ext_ship_cost` DECIMAL(7,2),
+        |`cs_net_paid` DECIMAL(7,2),
+        |`cs_net_paid_inc_tax` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship` DECIMAL(7,2),
+        |`cs_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`cs_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "catalog_returns" ->
       """
-        |`cr_returned_date_sk` INT, `cr_returned_time_sk` INT, `cr_item_sk` INT,
-        |`cr_refunded_customer_sk` INT, `cr_refunded_cdemo_sk` INT, `cr_refunded_hdemo_sk` INT,
-        |`cr_refunded_addr_sk` INT, `cr_returning_customer_sk` INT, `cr_returning_cdemo_sk` INT,
-        |`cr_returning_hdemo_sk` INT, `cr_returning_addr_sk` INT, `cr_call_center_sk` INT,
-        |`cr_catalog_page_sk` INT, `cr_ship_mode_sk` INT, `cr_warehouse_sk` INT,
-        |`cr_reason_sk` INT,`cr_order_number` INT, `cr_return_quantity` INT,
-        |`cr_return_amount` DECIMAL(7,2), `cr_return_tax` DECIMAL(7,2),
-        |`cr_return_amt_inc_tax` DECIMAL(7,2), `cr_fee` DECIMAL(7,2),
-        |`cr_return_ship_cost` DECIMAL(7,2), `cr_refunded_cash` DECIMAL(7,2),
-        |`cr_reversed_charge` DECIMAL(7,2), `cr_store_credit` DECIMAL(7,2),
+        |`cr_returned_date_sk` INT,
+        |`cr_returned_time_sk` INT,
+        |`cr_item_sk` INT,
+        |`cr_refunded_customer_sk` INT,
+        |`cr_refunded_cdemo_sk` INT,
+        |`cr_refunded_hdemo_sk` INT,
+        |`cr_refunded_addr_sk` INT,
+        |`cr_returning_customer_sk` INT,
+        |`cr_returning_cdemo_sk` INT,
+        |`cr_returning_hdemo_sk` INT,
+        |`cr_returning_addr_sk` INT,
+        |`cr_call_center_sk` INT,
+        |`cr_catalog_page_sk` INT,
+        |`cr_ship_mode_sk` INT,
+        |`cr_warehouse_sk` INT,
+        |`cr_reason_sk` INT,`cr_order_number` INT,
+        |`cr_return_quantity` INT,
+        |`cr_return_amount` DECIMAL(7,2),
+        |`cr_return_tax` DECIMAL(7,2),
+        |`cr_return_amt_inc_tax` DECIMAL(7,2),
+        |`cr_fee` DECIMAL(7,2),
+        |`cr_return_ship_cost` DECIMAL(7,2),
+        |`cr_refunded_cash` DECIMAL(7,2),
+        |`cr_reversed_charge` DECIMAL(7,2),
+        |`cr_store_credit` DECIMAL(7,2),
         |`cr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "web_sales" ->
       """
-        |`ws_sold_date_sk` INT, `ws_sold_time_sk` INT, `ws_ship_date_sk` INT, `ws_item_sk` INT,
-        |`ws_bill_customer_sk` INT, `ws_bill_cdemo_sk` INT, `ws_bill_hdemo_sk` INT,
-        |`ws_bill_addr_sk` INT, `ws_ship_customer_sk` INT, `ws_ship_cdemo_sk` INT,
-        |`ws_ship_hdemo_sk` INT, `ws_ship_addr_sk` INT, `ws_web_page_sk` INT,
-        |`ws_web_site_sk` INT, `ws_ship_mode_sk` INT, `ws_warehouse_sk` INT, `ws_promo_sk` INT,
-        |`ws_order_number` INT, `ws_quantity` INT, `ws_wholesale_cost` DECIMAL(7,2),
-        |`ws_list_price` DECIMAL(7,2), `ws_sales_price` DECIMAL(7,2),
-        |`ws_ext_discount_amt` DECIMAL(7,2), `ws_ext_sales_price` DECIMAL(7,2),
-        |`ws_ext_wholesale_cost` DECIMAL(7,2), `ws_ext_list_price` DECIMAL(7,2),
-        |`ws_ext_tax` DECIMAL(7,2), `ws_coupon_amt` DECIMAL(7,2), `ws_ext_ship_cost` DECIMAL(7,2),
-        |`ws_net_paid` DECIMAL(7,2), `ws_net_paid_inc_tax` DECIMAL(7,2),
-        |`ws_net_paid_inc_ship` DECIMAL(7,2), `ws_net_paid_inc_ship_tax` DECIMAL(7,2),
+        |`ws_sold_date_sk` INT,
+        |`ws_sold_time_sk` INT,
+        |`ws_ship_date_sk` INT,
+        |`ws_item_sk` INT,
+        |`ws_bill_customer_sk` INT,
+        |`ws_bill_cdemo_sk` INT,
+        |`ws_bill_hdemo_sk` INT,
+        |`ws_bill_addr_sk` INT,
+        |`ws_ship_customer_sk` INT,
+        |`ws_ship_cdemo_sk` INT,
+        |`ws_ship_hdemo_sk` INT,
+        |`ws_ship_addr_sk` INT,
+        |`ws_web_page_sk` INT,
+        |`ws_web_site_sk` INT,
+        |`ws_ship_mode_sk` INT,
+        |`ws_warehouse_sk` INT,
+        |`ws_promo_sk` INT,
+        |`ws_order_number` INT,
+        |`ws_quantity` INT,
+        |`ws_wholesale_cost` DECIMAL(7,2),
+        |`ws_list_price` DECIMAL(7,2),
+        |`ws_sales_price` DECIMAL(7,2),
+        |`ws_ext_discount_amt` DECIMAL(7,2),
+        |`ws_ext_sales_price` DECIMAL(7,2),
+        |`ws_ext_wholesale_cost` DECIMAL(7,2),
+        |`ws_ext_list_price` DECIMAL(7,2),
+        |`ws_ext_tax` DECIMAL(7,2),
+        |`ws_coupon_amt` DECIMAL(7,2),
+        |`ws_ext_ship_cost` DECIMAL(7,2),
+        |`ws_net_paid` DECIMAL(7,2),
+        |`ws_net_paid_inc_tax` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship` DECIMAL(7,2),
+        |`ws_net_paid_inc_ship_tax` DECIMAL(7,2),
         |`ws_net_profit` DECIMAL(7,2)
       """.stripMargin,
     "web_returns" ->
       """
-        |`wr_returned_date_sk` BIGINT, `wr_returned_time_sk` BIGINT, `wr_item_sk` BIGINT,
-        |`wr_refunded_customer_sk` BIGINT, `wr_refunded_cdemo_sk` BIGINT,
-        |`wr_refunded_hdemo_sk` BIGINT, `wr_refunded_addr_sk` BIGINT,
-        |`wr_returning_customer_sk` BIGINT, `wr_returning_cdemo_sk` BIGINT,
-        |`wr_returning_hdemo_sk` BIGINT, `wr_returning_addr_sk` BIGINT, `wr_web_page_sk` BIGINT,
-        |`wr_reason_sk` BIGINT, `wr_order_number` BIGINT, `wr_return_quantity` INT,
-        |`wr_return_amt` DECIMAL(7,2), `wr_return_tax` DECIMAL(7,2),
-        |`wr_return_amt_inc_tax` DECIMAL(7,2), `wr_fee` DECIMAL(7,2),
-        |`wr_return_ship_cost` DECIMAL(7,2), `wr_refunded_cash` DECIMAL(7,2),
-        |`wr_reversed_charge` DECIMAL(7,2), `wr_account_credit` DECIMAL(7,2),
+        |`wr_returned_date_sk` BIGINT,
+        |`wr_returned_time_sk` BIGINT,
+        |`wr_item_sk` BIGINT,
+        |`wr_refunded_customer_sk` BIGINT,
+        |`wr_refunded_cdemo_sk` BIGINT,
+        |`wr_refunded_hdemo_sk` BIGINT,
+        |`wr_refunded_addr_sk` BIGINT,
+        |`wr_returning_customer_sk` BIGINT,
+        |`wr_returning_cdemo_sk` BIGINT,
+        |`wr_returning_hdemo_sk` BIGINT,
+        |`wr_returning_addr_sk` BIGINT,
+        |`wr_web_page_sk` BIGINT,
+        |`wr_reason_sk` BIGINT,
+        |`wr_order_number` BIGINT,
+        |`wr_return_quantity` INT,
+        |`wr_return_amt` DECIMAL(7,2),
+        |`wr_return_tax` DECIMAL(7,2),
+        |`wr_return_amt_inc_tax` DECIMAL(7,2),
+        |`wr_fee` DECIMAL(7,2),
+        |`wr_return_ship_cost` DECIMAL(7,2),
+        |`wr_refunded_cash` DECIMAL(7,2),
+        |`wr_reversed_charge` DECIMAL(7,2),
+        |`wr_account_credit` DECIMAL(7,2),
         |`wr_net_loss` DECIMAL(7,2)
       """.stripMargin,
     "inventory" ->
       """
-        |`inv_date_sk` INT, `inv_item_sk` INT, `inv_warehouse_sk` INT,
+        |`inv_date_sk` INT,
+        |`inv_item_sk` INT,
+        |`inv_warehouse_sk` INT,
         |`inv_quantity_on_hand` INT
       """.stripMargin,
     "store" ->
       """
-        |`s_store_sk` INT, `s_store_id` STRING, `s_rec_start_date` DATE,
-        |`s_rec_end_date` DATE, `s_closed_date_sk` INT, `s_store_name` STRING,
-        |`s_number_employees` INT, `s_floor_space` INT, `s_hours` STRING, `s_manager` STRING,
-        |`s_market_id` INT, `s_geography_class` STRING, `s_market_desc` STRING,
-        |`s_market_manager` STRING, `s_division_id` INT, `s_division_name` STRING,
-        |`s_company_id` INT, `s_company_name` STRING, `s_street_number` STRING,
-        |`s_street_name` STRING, `s_street_type` STRING, `s_suite_number` STRING, `s_city` STRING,
-        |`s_county` STRING, `s_state` STRING, `s_zip` STRING, `s_country` STRING,
-        |`s_gmt_offset` DECIMAL(5,2), `s_tax_percentage` DECIMAL(5,2)
+        |`s_store_sk` INT,
+        |`s_store_id` CHAR(16),
+        |`s_rec_start_date` DATE,
+        |`s_rec_end_date` DATE,
+        |`s_closed_date_sk` INT,
+        |`s_store_name` VARCHAR(50),
+        |`s_number_employees` INT,
+        |`s_floor_space` INT,
+        |`s_hours` CHAR(20),
+        |`s_manager` VARCHAR(40),
+        |`s_market_id` INT,
+        |`s_geography_class` VARCHAR(100),
+        |`s_market_desc` VARCHAR(100),
+        |`s_market_manager` VARCHAR(40),
+        |`s_division_id` INT,
+        |`s_division_name` VARCHAR(50),
+        |`s_company_id` INT,
+        |`s_company_name` VARCHAR(50),
+        |`s_street_number` VARCHAR(10),
+        |`s_street_name` VARCHAR(60),
+        |`s_street_type` CHAR(15),
+        |`s_suite_number` CHAR(10),
+        |`s_city` VARCHAR(60),
+        |`s_county` VARCHAR(30),
+        |`s_state` CHAR(2),
+        |`s_zip` CHAR(10),
+        |`s_country` VARCHAR(20),
+        |`s_gmt_offset` DECIMAL(5,2),
+        |`s_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "call_center" ->
       """
-        |`cc_call_center_sk` INT, `cc_call_center_id` STRING, `cc_rec_start_date` DATE,
-        |`cc_rec_end_date` DATE, `cc_closed_date_sk` INT, `cc_open_date_sk` INT, `cc_name` STRING,
-        |`cc_class` STRING, `cc_employees` INT, `cc_sq_ft` INT, `cc_hours` STRING,
-        |`cc_manager` STRING, `cc_mkt_id` INT, `cc_mkt_class` STRING, `cc_mkt_desc` STRING,
-        |`cc_market_manager` STRING, `cc_division` INT, `cc_division_name` STRING,
-        |`cc_company` INT, `cc_company_name` STRING, `cc_street_number` STRING,
-        |`cc_street_name` STRING, `cc_street_type` STRING, `cc_suite_number` STRING,
-        |`cc_city` STRING, `cc_county` STRING, `cc_state` STRING, `cc_zip` STRING,
-        |`cc_country` STRING, `cc_gmt_offset` DECIMAL(5,2), `cc_tax_percentage` DECIMAL(5,2)
+        |`cc_call_center_sk` INT,
+        |`cc_call_center_id` CHAR(16),
+        |`cc_rec_start_date` DATE,
+        |`cc_rec_end_date` DATE,
+        |`cc_closed_date_sk` INT,
+        |`cc_open_date_sk` INT,
+        |`cc_name` VARCHAR(50),
+        |`cc_class` VARCHAR(50),
+        |`cc_employees` INT,
+        |`cc_sq_ft` INT,
+        |`cc_hours` CHAR(20),
+        |`cc_manager` VARCHAR(40),
+        |`cc_mkt_id` INT,
+        |`cc_mkt_class` CHAR(50),
+        |`cc_mkt_desc` VARCHAR(100),
+        |`cc_market_manager` VARCHAR(40),
+        |`cc_division` INT,
+        |`cc_division_name` VARCHAR(50),
+        |`cc_company` INT,
+        |`cc_company_name` CHAR(50),
+        |`cc_street_number` CHAR(10),
+        |`cc_street_name` VARCHAR(60),
+        |`cc_street_type` CHAR(15),
+        |`cc_suite_number` CHAR(10),
+        |`cc_city` VARCHAR(60),
+        |`cc_county` VARCHAR(30),
+        |`cc_state` CHAR(2),
+        |`cc_zip` CHAR(10),
+        |`cc_country` VARCHAR(20),
+        |`cc_gmt_offset` DECIMAL(5,2),
+        |`cc_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "catalog_page" ->
       """
-        |`cp_catalog_page_sk` INT, `cp_catalog_page_id` STRING, `cp_start_date_sk` INT,
-        |`cp_end_date_sk` INT, `cp_department` STRING, `cp_catalog_number` INT,
-        |`cp_catalog_page_number` INT, `cp_description` STRING, `cp_type` STRING
+        |`cp_catalog_page_sk` INT,
+        |`cp_catalog_page_id` CHAR(16),
+        |`cp_start_date_sk` INT,
+        |`cp_end_date_sk` INT,
+        |`cp_department` VARCHAR(50),
+        |`cp_catalog_number` INT,
+        |`cp_catalog_page_number` INT,
+        |`cp_description` VARCHAR(100),
+        |`cp_type` VARCHAR(100)
       """.stripMargin,
     "web_site" ->
       """
-        |`web_site_sk` INT, `web_site_id` STRING, `web_rec_start_date` DATE,
-        |`web_rec_end_date` DATE, `web_name` STRING, `web_open_date_sk` INT,
-        |`web_close_date_sk` INT, `web_class` STRING, `web_manager` STRING, `web_mkt_id` INT,
-        |`web_mkt_class` STRING, `web_mkt_desc` STRING, `web_market_manager` STRING,
-        |`web_company_id` INT, `web_company_name` STRING, `web_street_number` STRING,
-        |`web_street_name` STRING, `web_street_type` STRING, `web_suite_number` STRING,
-        |`web_city` STRING, `web_county` STRING, `web_state` STRING, `web_zip` STRING,
-        |`web_country` STRING, `web_gmt_offset` DECIMAL(5,2), `web_tax_percentage` DECIMAL(5,2)
+        |`web_site_sk` INT,
+        |`web_site_id` CHAR(16),
+        |`web_rec_start_date` DATE,
+        |`web_rec_end_date` DATE,
+        |`web_name` VARCHAR(50),
+        |`web_open_date_sk` INT,
+        |`web_close_date_sk` INT,
+        |`web_class` VARCHAR(50),
+        |`web_manager` VARCHAR(40),
+        |`web_mkt_id` INT,
+        |`web_mkt_class` VARCHAR(50),
+        |`web_mkt_desc` VARCHAR(100),
+        |`web_market_manager` VARCHAR(40),
+        |`web_company_id` INT,
+        |`web_company_name` CHAR(50),
+        |`web_street_number` CHAR(10),
+        |`web_street_name` VARCHAR(60),
+        |`web_street_type` CHAR(15),
+        |`web_suite_number` CHAR(10),
+        |`web_city` VARCHAR(60),
+        |`web_county` VARCHAR(30),
+        |`web_state` CHAR(2),
+        |`web_zip` CHAR(10),
+        |`web_country` VARCHAR(20),
+        |`web_gmt_offset` DECIMAL(5,2),
+        |`web_tax_percentage` DECIMAL(5,2)
       """.stripMargin,
     "web_page" ->
       """
-        |`wp_web_page_sk` INT, `wp_web_page_id` STRING,
-        |`wp_rec_start_date` DATE, `wp_rec_end_date` DATE, `wp_creation_date_sk` INT,
-        |`wp_access_date_sk` INT, `wp_autogen_flag` STRING, `wp_customer_sk` INT,
-        |`wp_url` STRING, `wp_type` STRING, `wp_char_count` INT, `wp_link_count` INT,
-        |`wp_image_count` INT, `wp_max_ad_count` INT
+        |`wp_web_page_sk` INT,
+        |`wp_web_page_id` CHAR(16),
+        |`wp_rec_start_date` DATE,
+        |`wp_rec_end_date` DATE,
+        |`wp_creation_date_sk` INT,
+        |`wp_access_date_sk` INT,
+        |`wp_autogen_flag` CHAR(1),
+        |`wp_customer_sk` INT,
+        |`wp_url` VARCHAR(100),
+        |`wp_type` CHAR(50),
+        |`wp_char_count` INT,
+        |`wp_link_count` INT,
+        |`wp_image_count` INT,
+        |`wp_max_ad_count` INT
       """.stripMargin,
     "warehouse" ->
       """
-        |`w_warehouse_sk` INT, `w_warehouse_id` STRING, `w_warehouse_name` STRING,
-        |`w_warehouse_sq_ft` INT, `w_street_number` STRING, `w_street_name` STRING,
-        |`w_street_type` STRING, `w_suite_number` STRING, `w_city` STRING, `w_county` STRING,
-        |`w_state` STRING, `w_zip` STRING, `w_country` STRING, `w_gmt_offset` DECIMAL(5,2)
+        |`w_warehouse_sk` INT,
+        |`w_warehouse_id` CHAR(16),
+        |`w_warehouse_name` VARCHAR(20),
+        |`w_warehouse_sq_ft` INT,
+        |`w_street_number` CHAR(10),
+        |`w_street_name` VARCHAR(20),
+        |`w_street_type` CHAR(15),
+        |`w_suite_number` CHAR(10),
+        |`w_city` VARCHAR(60),
+        |`w_county` VARCHAR(30),
+        |`w_state` CHAR(2),
+        |`w_zip` CHAR(10),
+        |`w_country` VARCHAR(20),
+        |`w_gmt_offset` DECIMAL(5,2)
       """.stripMargin,
     "customer" ->
       """
-        |`c_customer_sk` INT, `c_customer_id` STRING, `c_current_cdemo_sk` INT,
-        |`c_current_hdemo_sk` INT, `c_current_addr_sk` INT, `c_first_shipto_date_sk` INT,
-        |`c_first_sales_date_sk` INT, `c_salutation` STRING, `c_first_name` STRING,
-        |`c_last_name` STRING, `c_preferred_cust_flag` STRING, `c_birth_day` INT,
-        |`c_birth_month` INT, `c_birth_year` INT, `c_birth_country` STRING, `c_login` STRING,
-        |`c_email_address` STRING, `c_last_review_date` INT
+        |`c_customer_sk` INT,
+        |`c_customer_id` CHAR(16),
+        |`c_current_cdemo_sk` INT,
+        |`c_current_hdemo_sk` INT,
+        |`c_current_addr_sk` INT,
+        |`c_first_shipto_date_sk` INT,
+        |`c_first_sales_date_sk` INT,
+        |`c_salutation` CHAR(10),
+        |`c_first_name` CHAR(20),
+        |`c_last_name` CHAR(30),
+        |`c_preferred_cust_flag` CHAR(1),
+        |`c_birth_day` INT,
+        |`c_birth_month` INT,
+        |`c_birth_year` INT,
+        |`c_birth_country` VARCHAR(20),
+        |`c_login` CHAR(13),
+        |`c_email_address` CHAR(50),
+        |`c_last_review_date` INT
       """.stripMargin,
     "customer_address" ->
       """
-        |`ca_address_sk` INT, `ca_address_id` STRING, `ca_street_number` STRING,
-        |`ca_street_name` STRING, `ca_street_type` STRING, `ca_suite_number` STRING,
-        |`ca_city` STRING, `ca_county` STRING, `ca_state` STRING, `ca_zip` STRING,
-        |`ca_country` STRING, `ca_gmt_offset` DECIMAL(5,2), `ca_location_type` STRING
+        |`ca_address_sk` INT,
+        |`ca_address_id` CHAR(16),
+        |`ca_street_number` CHAR(10),
+        |`ca_street_name` VARCHAR(60),
+        |`ca_street_type` CHAR(15),
+        |`ca_suite_number` CHAR(10),
+        |`ca_city` VARCHAR(60),
+        |`ca_county` VARCHAR(30),
+        |`ca_state` CHAR(2),
+        |`ca_zip` CHAR(10),
+        |`ca_country` VARCHAR(20),
+        |`ca_gmt_offset` DECIMAL(5,2),
+        |`ca_location_type` CHAR(20)
       """.stripMargin,
     "customer_demographics" ->
       """
-        |`cd_demo_sk` INT, `cd_gender` STRING, `cd_marital_status` STRING,
-        |`cd_education_status` STRING, `cd_purchase_estimate` INT, `cd_credit_rating` STRING,
-        |`cd_dep_count` INT, `cd_dep_employed_count` INT, `cd_dep_college_count` INT
+        |`cd_demo_sk` INT,
+        |`cd_gender` CHAR(1),
+        |`cd_marital_status` CHAR(1),
+        |`cd_education_status` CHAR(20),
+        |`cd_purchase_estimate` INT,
+        |`cd_credit_rating` CHAR(10),
+        |`cd_dep_count` INT,
+        |`cd_dep_employed_count` INT,
+        |`cd_dep_college_count` INT
       """.stripMargin,
     "date_dim" ->
       """
-        |`d_date_sk` INT, `d_date_id` STRING, `d_date` DATE,
-        |`d_month_seq` INT, `d_week_seq` INT, `d_quarter_seq` INT, `d_year` INT, `d_dow` INT,
-        |`d_moy` INT, `d_dom` INT, `d_qoy` INT, `d_fy_year` INT, `d_fy_quarter_seq` INT,
-        |`d_fy_week_seq` INT, `d_day_name` STRING, `d_quarter_name` STRING, `d_holiday` STRING,
-        |`d_weekend` STRING, `d_following_holiday` STRING, `d_first_dom` INT, `d_last_dom` INT,
-        |`d_same_day_ly` INT, `d_same_day_lq` INT, `d_current_day` STRING,
-        |`d_current_week` STRING, `d_current_month` STRING, `d_current_quarter` STRING,
-        |`d_current_year` STRING
+        |`d_date_sk` INT,
+        |`d_date_id` CHAR(16),
+        |`d_date` DATE,
+        |`d_month_seq` INT,
+        |`d_week_seq` INT,
+        |`d_quarter_seq` INT,
+        |`d_year` INT,
+        |`d_dow` INT,
+        |`d_moy` INT,
+        |`d_dom` INT,
+        |`d_qoy` INT,
+        |`d_fy_year` INT,
+        |`d_fy_quarter_seq` INT,
+        |`d_fy_week_seq` INT,
+        |`d_day_name` CHAR(9),
+        |`d_quarter_name` CHAR(1),

Review comment:
       Can we do that separately becuase #31886 is about adding a new GitHub Action job?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31012: [SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31012:
URL: https://github.com/apache/spark/pull/31012#issuecomment-758596464


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133964/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org