You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by huafengw <gi...@git.apache.org> on 2017/07/20 07:07:02 UTC

[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

GitHub user huafengw opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/196

    [GEARPUMP-322] Fix multiple SLF4J bindings on classpath

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huafengw/incubator-gearpump fix322

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #196
    
----
commit 0b972a4c0492257fb7263035483db653d2018d89
Author: huafengw <fv...@gmail.com>
Date:   2017-07-20T07:06:28Z

    [GEARPUMP-322] Fix multiple SLF4J bindings on classpath

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/196#discussion_r128453676
  
    --- Diff: project/BuildExperiments.scala ---
    @@ -46,7 +46,8 @@ object BuildExperiments extends sbt.Build {
               "org.apache.hadoop" % "hadoop-mapreduce-client-core" % hadoopVersion,
               "org.apache.hadoop" % "hadoop-yarn-server-resourcemanager" % hadoopVersion % "provided",
               "org.apache.hadoop" % "hadoop-yarn-server-nodemanager" % hadoopVersion % "provided"
    -        )
    +        ).map(_.exclude("org.slf4j", "slf4j-api"))
    --- End diff --
    
    From gearpump-core


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #196: [GEARPUMP-322] Fix multiple SLF4J bindings on...

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/196
  
    # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/196?src=pr&el=h1) Report
    > Merging [#196](https://codecov.io/gh/apache/incubator-gearpump/pull/196?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/e3c63ef2b51af6a6c4d97c91479b7c1f6082c0fe?src=pr&el=desc) will **decrease** coverage by `0.27%`.
    > The diff coverage is `n/a`.
    
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #196      +/-   ##
    ==========================================
    - Coverage   71.83%   71.55%   -0.28%     
    ==========================================
      Files         189      189              
      Lines        6106     6106              
      Branches      537      537              
    ==========================================
    - Hits         4386     4369      -17     
    - Misses       1720     1737      +17
    ```
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/196#discussion_r128451485
  
    --- Diff: project/BuildExperiments.scala ---
    @@ -46,7 +46,8 @@ object BuildExperiments extends sbt.Build {
               "org.apache.hadoop" % "hadoop-mapreduce-client-core" % hadoopVersion,
               "org.apache.hadoop" % "hadoop-yarn-server-resourcemanager" % hadoopVersion % "provided",
               "org.apache.hadoop" % "hadoop-yarn-server-nodemanager" % hadoopVersion % "provided"
    -        )
    +        ).map(_.exclude("org.slf4j", "slf4j-api"))
    --- End diff --
    
    Then where will the yarn load `slf4j` libraries ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #196: [GEARPUMP-322] Fix multiple SLF4J bindings on...

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/196
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/196


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---