You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/06/23 00:09:00 UTC

[Impala-ASF-CR] Bump up the GBN to 14842939

Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17628


Change subject: Bump up the GBN to 14842939
......................................................................

Bump up the GBN to 14842939

This patch bumps up the GBN to 14842939. This build
includes HIVE-23995 and HIVE-24175 and some of the tests
were modified to take into account of that.

Testing done:
1. Core tests.

Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
---
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
D testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test
M tests/custom_cluster/test_event_processing.py
M tests/metadata/test_metadata_query_statements.py
5 files changed, 66 insertions(+), 86 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17628/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9012/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 19:51:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 1:

Found another test where we refer to HIVE-24175
https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/create-database.test#L172


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 17:11:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17628/2/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/17628/2/tests/common/environ.py@358
PS2, Line 358: i
flake8: F821 undefined name 'impala_url'



-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 19:19:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7258/


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jun 2021 01:18:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 13:29:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17628/3/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/17628/3/tests/common/environ.py@358
PS3, Line 358: i
> flake8: F821 undefined name 'impala_url'
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 19:28:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................

Bump up the GBN to 14842939

This patch bumps up the GBN to 14842939. This build
includes HIVE-23995 and HIVE-24175 and some of the tests
were modified to take into account of that.

Testing done:
1. Ran core tests.

Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
---
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/create-database.test
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
D testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test
M tests/common/environ.py
M tests/custom_cluster/test_event_processing.py
M tests/metadata/test_metadata_query_statements.py
7 files changed, 204 insertions(+), 105 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17628/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/8985/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 19:39:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17628/5/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/17628/5/tests/custom_cluster/test_event_processing.py@352
PS5, Line 352:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/17628/5/tests/custom_cluster/test_event_processing.py@352
PS5, Line 352:  
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 19:29:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................

Bump up the GBN to 14842939

This patch bumps up the GBN to 14842939. This build
includes HIVE-23995 and HIVE-24175 and some of the tests
were modified to take into account of that.

Also, fixes a minor bug in environ.py

Testing done:
1. Core tests.

Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Reviewed-on: http://gerrit.cloudera.org:8080/17628
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/create-database.test
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
D testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test
M tests/common/environ.py
M tests/custom_cluster/test_event_processing.py
M tests/metadata/test_metadata_query_statements.py
7 files changed, 97 insertions(+), 105 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Csaba Ringhofer: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17628/3/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/17628/3/tests/common/environ.py@358
PS3, Line 358: i
flake8: F821 undefined name 'impala_url'



-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jun 2021 17:17:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7266/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jun 2021 17:16:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7269/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 19:28:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7258/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 19:19:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Jun 2021 02:15:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................

Bump up the GBN to 14842939

This patch bumps up the GBN to 14842939. This build
includes HIVE-23995 and HIVE-24175 and some of the tests
were modified to take into account of that.

Testing done:
1. Core tests.

Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
---
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/create-database.test
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
D testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test
M tests/common/environ.py
M tests/custom_cluster/test_event_processing.py
M tests/metadata/test_metadata_query_statements.py
7 files changed, 96 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17628/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 2:

> Found another test where we refer to HIVE-24175
 > https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/create-database.test#L172

Thanks, PS2 includes fix for create-database.test


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 19:18:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9001/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jun 2021 17:37:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7249/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 00:09:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................

Bump up the GBN to 14842939

This patch bumps up the GBN to 14842939. This build
includes HIVE-23995 and HIVE-24175 and some of the tests
were modified to take into account of that.

Testing done:
1. Core tests.

Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
---
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/create-database.test
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
D testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test
M tests/common/environ.py
M tests/custom_cluster/test_event_processing.py
M tests/metadata/test_metadata_query_statements.py
7 files changed, 96 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17628/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7249/


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 06:10:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9013/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 22:47:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8977/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 00:31:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up the GBN to 14842939

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17628 )

Change subject: Bump up the GBN to 14842939
......................................................................

Bump up the GBN to 14842939

This patch bumps up the GBN to 14842939. This build
includes HIVE-23995 and HIVE-24175 and some of the tests
were modified to take into account of that.

Also, fixes a minor bug in environ.py

Testing done:
1. Core tests.

Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
---
M bin/impala-config.sh
M testdata/workloads/functional-query/queries/QueryTest/create-database.test
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
D testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test
M tests/common/environ.py
M tests/custom_cluster/test_event_processing.py
M tests/metadata/test_metadata_query_statements.py
7 files changed, 97 insertions(+), 105 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17628/6
-- 
To view, visit http://gerrit.cloudera.org:8080/17628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78f167c1c0d8e90808e387aba0e86b697067ed8f
Gerrit-Change-Number: 17628
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>