You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martijn Dashorst <ma...@gmail.com> on 2008/04/03 23:31:52 UTC
Make output markup container id default for development mode
We have this nice feature that puts the markup container's id in
comments into the generated markup. This is really handy for debugging
purposes. Should we enable this feature by the default during
development?
Martijn
--
Buy Wicket in Action: http://manning.com/dashorst
Apache Wicket 1.3.2 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
Re: Make output markup container id default for development mode
Posted by Charlie Dobbie <cf...@gmail.com>.
+1, non-binding. Great idea!
Charlie.
On Fri, Apr 4, 2008 at 9:08 AM, Nino Saturnino Martinez Vazquez Wael <
nino.martinez@jayway.dk> wrote:
> I agree that it's a great idea..
>
> And I've had a discussion about, using external web designers for design.
> If we just provide them the whole page as rendered, this will make it even
> easier for us to paste back.
>
> regards Nino
>
>
> Igor Vaynberg wrote:
>
> > this has nothing to do with outputting markup ids. it outputs wicket
> > component class name next to a component
> >
> > eg
> > <div wicket:id="panel">
> > <!-- com.myco.ThisOrThatPanel -->
> > markup that comes form ThisOrThatPanel
> > </div>
> >
> > -igor
> >
> >
> > On Fri, Apr 4, 2008 at 12:37 AM, Peter Ertl <pe...@gmx.net> wrote:
> >
> >
> > > I wouldn't do this (at least by default) as you might forget to call
> > > setOutputMarkupId(true) on some components that interacts with custom
> > > javascript. However your code will still work because _everything_ has
> > > an
> > > dom id now. Once you deploy you will realize that you missed something
> > > important.
> > >
> > > How about MarkupSettings#setOutputAllMarkupIds(boolean) ?
> > >
> > > Am 03.04.2008 um 23:35 schrieb Igor Vaynberg:
> > >
> > >
> > >
> > >
> > >
> > >
> > > > fine by me
> > > >
> > > > -igor
> > > >
> > > >
> > > > On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst
> > > > <ma...@gmail.com> wrote:
> > > >
> > > >
> > > >
> > > > > We have this nice feature that puts the markup container's id in
> > > > > comments into the generated markup. This is really handy for
> > > > > debugging
> > > > > purposes. Should we enable this feature by the default during
> > > > > development?
> > > > >
> > > > > Martijn
> > > > >
> > > > > --
> > > > > Buy Wicket in Action: http://manning.com/dashorst
> > > > > Apache Wicket 1.3.2 is released
> > > > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> >
>
> --
> -Wicket for love
>
> Nino Martinez Wael
> Java Specialist @ Jayway DK
> http://www.jayway.dk
> +45 2936 7684
>
>
Re: Make output markup container id default for development mode
Posted by Nino Saturnino Martinez Vazquez Wael <ni...@jayway.dk>.
I agree that it's a great idea..
And I've had a discussion about, using external web designers for
design. If we just provide them the whole page as rendered, this will
make it even easier for us to paste back.
regards Nino
Igor Vaynberg wrote:
> this has nothing to do with outputting markup ids. it outputs wicket
> component class name next to a component
>
> eg
> <div wicket:id="panel">
> <!-- com.myco.ThisOrThatPanel -->
> markup that comes form ThisOrThatPanel
> </div>
>
> -igor
>
>
> On Fri, Apr 4, 2008 at 12:37 AM, Peter Ertl <pe...@gmx.net> wrote:
>
>> I wouldn't do this (at least by default) as you might forget to call
>> setOutputMarkupId(true) on some components that interacts with custom
>> javascript. However your code will still work because _everything_ has an
>> dom id now. Once you deploy you will realize that you missed something
>> important.
>>
>> How about MarkupSettings#setOutputAllMarkupIds(boolean) ?
>>
>> Am 03.04.2008 um 23:35 schrieb Igor Vaynberg:
>>
>>
>>
>>
>>
>>> fine by me
>>>
>>> -igor
>>>
>>>
>>> On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst
>>> <ma...@gmail.com> wrote:
>>>
>>>
>>>> We have this nice feature that puts the markup container's id in
>>>> comments into the generated markup. This is really handy for debugging
>>>> purposes. Should we enable this feature by the default during
>>>> development?
>>>>
>>>> Martijn
>>>>
>>>> --
>>>> Buy Wicket in Action: http://manning.com/dashorst
>>>> Apache Wicket 1.3.2 is released
>>>> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
>>>>
>>>>
>>>>
>>
>
>
>
--
-Wicket for love
Nino Martinez Wael
Java Specialist @ Jayway DK
http://www.jayway.dk
+45 2936 7684
Re: Make output markup container id default for development mode
Posted by Ryan Gravener <ry...@ryangravener.com>.
It is very useful.
+1 nb
On Fri, Apr 4, 2008 at 5:56 PM, Gwyn Evans <gw...@gmail.com> wrote:
> I assume it actually outputs it as
>
>
> <div wicket:id="panel"><!-- com.myco.ThisOrThatPanel -->markup that
> comes form ThisOrThatPanel
> </div>
> ?
>
> /Gwyn
>
>
>
> On Fri, Apr 4, 2008 at 9:02 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> > this has nothing to do with outputting markup ids. it outputs wicket
> > component class name next to a component
> >
> > eg
> > <div wicket:id="panel">
> > <!-- com.myco.ThisOrThatPanel -->
> > markup that comes form ThisOrThatPanel
> > </div>
> >
> > -igor
> >
> >
> >
> >
> > On Fri, Apr 4, 2008 at 12:37 AM, Peter Ertl <pe...@gmx.net> wrote:
> > > I wouldn't do this (at least by default) as you might forget to call
> > > setOutputMarkupId(true) on some components that interacts with custom
> > > javascript. However your code will still work because _everything_ has an
> > > dom id now. Once you deploy you will realize that you missed something
> > > important.
> > >
> > > How about MarkupSettings#setOutputAllMarkupIds(boolean) ?
> > >
> > > Am 03.04.2008 um 23:35 schrieb Igor Vaynberg:
> > >
> > >
> > >
> > >
> > > > fine by me
> > > >
> > > > -igor
> > > >
> > > >
> > > > On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst
> > > > <ma...@gmail.com> wrote:
> > > >
> > > > > We have this nice feature that puts the markup container's id in
> > > > > comments into the generated markup. This is really handy for debugging
> > > > > purposes. Should we enable this feature by the default during
> > > > > development?
> > > > >
> > > > > Martijn
> > > > >
> > > > > --
> > > > > Buy Wicket in Action: http://manning.com/dashorst
> > > > > Apache Wicket 1.3.2 is released
> > > > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
> > > > >
> > > > >
> > > >
> > >
> > >
> >
>
--
Ryan Gravener
http://ryangravener.com
Re: Make output markup container id default for development mode
Posted by Gwyn Evans <gw...@gmail.com>.
I assume it actually outputs it as
<div wicket:id="panel"><!-- com.myco.ThisOrThatPanel -->markup that
comes form ThisOrThatPanel
</div>
?
/Gwyn
On Fri, Apr 4, 2008 at 9:02 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> this has nothing to do with outputting markup ids. it outputs wicket
> component class name next to a component
>
> eg
> <div wicket:id="panel">
> <!-- com.myco.ThisOrThatPanel -->
> markup that comes form ThisOrThatPanel
> </div>
>
> -igor
>
>
>
>
> On Fri, Apr 4, 2008 at 12:37 AM, Peter Ertl <pe...@gmx.net> wrote:
> > I wouldn't do this (at least by default) as you might forget to call
> > setOutputMarkupId(true) on some components that interacts with custom
> > javascript. However your code will still work because _everything_ has an
> > dom id now. Once you deploy you will realize that you missed something
> > important.
> >
> > How about MarkupSettings#setOutputAllMarkupIds(boolean) ?
> >
> > Am 03.04.2008 um 23:35 schrieb Igor Vaynberg:
> >
> >
> >
> >
> > > fine by me
> > >
> > > -igor
> > >
> > >
> > > On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst
> > > <ma...@gmail.com> wrote:
> > >
> > > > We have this nice feature that puts the markup container's id in
> > > > comments into the generated markup. This is really handy for debugging
> > > > purposes. Should we enable this feature by the default during
> > > > development?
> > > >
> > > > Martijn
> > > >
> > > > --
> > > > Buy Wicket in Action: http://manning.com/dashorst
> > > > Apache Wicket 1.3.2 is released
> > > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
> > > >
> > > >
> > >
> >
> >
>
Re: Make output markup container id default for development mode
Posted by Igor Vaynberg <ig...@gmail.com>.
this has nothing to do with outputting markup ids. it outputs wicket
component class name next to a component
eg
<div wicket:id="panel">
<!-- com.myco.ThisOrThatPanel -->
markup that comes form ThisOrThatPanel
</div>
-igor
On Fri, Apr 4, 2008 at 12:37 AM, Peter Ertl <pe...@gmx.net> wrote:
> I wouldn't do this (at least by default) as you might forget to call
> setOutputMarkupId(true) on some components that interacts with custom
> javascript. However your code will still work because _everything_ has an
> dom id now. Once you deploy you will realize that you missed something
> important.
>
> How about MarkupSettings#setOutputAllMarkupIds(boolean) ?
>
> Am 03.04.2008 um 23:35 schrieb Igor Vaynberg:
>
>
>
>
> > fine by me
> >
> > -igor
> >
> >
> > On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst
> > <ma...@gmail.com> wrote:
> >
> > > We have this nice feature that puts the markup container's id in
> > > comments into the generated markup. This is really handy for debugging
> > > purposes. Should we enable this feature by the default during
> > > development?
> > >
> > > Martijn
> > >
> > > --
> > > Buy Wicket in Action: http://manning.com/dashorst
> > > Apache Wicket 1.3.2 is released
> > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
> > >
> > >
> >
>
>
Re: Make output markup container id default for development mode
Posted by Peter Ertl <pe...@gmx.net>.
I wouldn't do this (at least by default) as you might forget to call
setOutputMarkupId(true) on some components that interacts with custom
javascript. However your code will still work because _everything_ has
an dom id now. Once you deploy you will realize that you missed
something important.
How about MarkupSettings#setOutputAllMarkupIds(boolean) ?
Am 03.04.2008 um 23:35 schrieb Igor Vaynberg:
> fine by me
>
> -igor
>
>
> On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst
> <ma...@gmail.com> wrote:
>> We have this nice feature that puts the markup container's id in
>> comments into the generated markup. This is really handy for
>> debugging
>> purposes. Should we enable this feature by the default during
>> development?
>>
>> Martijn
>>
>> --
>> Buy Wicket in Action: http://manning.com/dashorst
>> Apache Wicket 1.3.2 is released
>> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
>>
Re: Make output markup container id default for development mode
Posted by Igor Vaynberg <ig...@gmail.com>.
fine by me
-igor
On Thu, Apr 3, 2008 at 2:31 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> We have this nice feature that puts the markup container's id in
> comments into the generated markup. This is really handy for debugging
> purposes. Should we enable this feature by the default during
> development?
>
> Martijn
>
> --
> Buy Wicket in Action: http://manning.com/dashorst
> Apache Wicket 1.3.2 is released
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
>
Re: Make output markup container id default for development mode
Posted by Matej Knopp <ma...@gmail.com>.
I think so. It doesn't do anything harmful imho, just adds some html comments.
+1.
-Matej
On Thu, Apr 3, 2008 at 11:31 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> We have this nice feature that puts the markup container's id in
> comments into the generated markup. This is really handy for debugging
> purposes. Should we enable this feature by the default during
> development?
>
> Martijn
>
> --
> Buy Wicket in Action: http://manning.com/dashorst
> Apache Wicket 1.3.2 is released
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2
>
--
Resizable and reorderable grid components.
http://www.inmethod.com