You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "juliuszsompolski (via GitHub)" <gi...@apache.org> on 2023/08/07 22:50:07 UTC
[GitHub] [spark] juliuszsompolski commented on pull request #42355: [SPARK-44709][CONNECT] Run ExecuteGrpcResponseSender in reattachable execute in new thread to fix flow control
juliuszsompolski commented on PR #42355:
URL: https://github.com/apache/spark/pull/42355#issuecomment-1668673016
@hvanhovell
> Is the ExecuteGrpcResponseSender thread safe? For example is detach() safe?
detach() is synchronized on the executeObserver it's attached to, like the other places in the sender... Modified the code a bit to make it more clear.
> Is it possible for events to produced in a weird order?
No. Execution pushes responses to executeObserver in order, there is a bunch of assertions that assure order of events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org