You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/15 09:19:45 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

masayuki2009 opened a new pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158


   ## Summary
   
   - This PR reverts apache/incubator-nuttx#4118 
   - Because there are critical boot issues.
   
   ## Impact
   
   - None
   
   ## Testing
   
   - N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880540205


   @masayuki2009 could you share more detailed error info?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880797170


   Fix here: ~~https://github.com/apache/incubator-nuttx/pull/4158~~ https://github.com/apache/incubator-nuttx/pull/4161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-881075898


   The issue was fixed by
   https://github.com/apache/incubator-nuttx/pull/4161
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880797170


   Fix here: https://github.com/apache/incubator-nuttx/pull/4158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880884635


   Converted to Draft to avoid people to merger unintentionally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880593515


   The root cause is https://github.com/apache/incubator-nuttx/pull/4048 forget to intiailize the idle task's tl_task. I will provide a patch to fix it tonight.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880543536


   > @masayuki2009 could you share more detailed error info?
   
   @xiaoxiang781216 
   https://github.com/apache/incubator-nuttx/pull/4118#issuecomment-880097209
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] yamt commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880599565


   @xiaoxiang781216 i feel it makes more sense to revert this for now until your fix gets ready. but it's up to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158#issuecomment-880550911


   Sorry, I miss the message in that PR. From the panic log, it's enough to just revert "Revert "fs: Move umask to task_info_s". I will investigate the second patch in the real hardware.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 closed pull request #4158: Revert "fs: Support the root file system attributes(mode, uid, gid and time) "

Posted by GitBox <gi...@apache.org>.
masayuki2009 closed pull request #4158:
URL: https://github.com/apache/incubator-nuttx/pull/4158


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org