You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/09 10:08:18 UTC
[jira] [Commented] (IGNITE-5339) JDBC thin driver: validate
compliance
[ https://issues.apache.org/jira/browse/IGNITE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044251#comment-16044251 ]
ASF GitHub Bot commented on IGNITE-5339:
----------------------------------------
GitHub user tledkov-gridgain opened a pull request:
https://github.com/apache/ignite/pull/2112
IGNITE-5339: JDBC thin driver: validate compliance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-5339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2112
----
commit 313fdc4eb9e3e101a829269b5d1c3ac58c619d9e
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-05-30T15:06:29Z
IGNITE-5339: Added draft tests for majority of methods in jdbc Connection interface
commit 6fc4715336140fe9e76935b51c29746d7e436a88
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-01T09:57:14Z
Merge branch 'master' of https://github.com/apache/ignite into ignite-5339
commit 600c2884004a80e2988f5f8a2477c63fc23cdcc1
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-01T11:32:26Z
IGNITE-5339 Some more Connection methods covered
commit 558d1f288e38f0fb5cb16c62ffc48eb34a12d44b
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-01T12:29:04Z
IGNITE-5339: work in progress
commit cadf9595a1ea7717459a125fa4e9071e34b050db
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-01T13:44:12Z
IGNITE-5339 Work in progress
commit 154cbde6d051aa511f50af8160154d75d7b2856a
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-02T11:30:58Z
IGNITE-5339 WIP
commit b6b971c8510892349e575c923bd51e53b04dafe6
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-02T11:31:29Z
Merge branch 'master' of https://github.com/apache/ignite into ignite-5339
commit 5acfeebfff5db2cf56454088f7f0c60739aa6161
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-02T11:49:50Z
Merge branch 'master' of https://github.com/apache/ignite into ignite-5339
commit 4ae23d4cee9852eefff4237772693ba83bfd4984
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-02T14:26:44Z
IGNITE-5339 WIP
commit e08c85673e9e52018c6feb98b248b46ec81b3de9
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-02T16:52:21Z
IGNITE-5339: added some statement method tests
commit ca0dc56a2a4d6130135e5a1bb7cf7fd19fcd36cd
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-02T16:53:28Z
Merge branch 'master' of https://github.com/apache/ignite into ignite-5339
commit 67c419d81720d3a5fbbb85cec7925c9b590e6cb5
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-05T10:44:07Z
Merge branch 'master' of https://github.com/apache/ignite into ignite-5339
commit eaf03ba107c7fa1335ee5406d8f822b7462e78b7
Author: skalashnikov <sk...@gridgain.com>
Date: 2017-06-05T12:20:53Z
IGNITE-5339 work in progress
commit a2860d561d9fbfde53b26eae4f8fc403b1cccff3
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-06T11:56:39Z
Merge branch 'master' into ignite-5339
# Conflicts:
# modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java
commit d3b104c6ddaf9f29a2533305231d5cd14329d447
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-06T11:57:40Z
IGNITE-5339: argument check fix
commit d250d102ac7832b967fe28a72863425169c93e05
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-06T12:19:52Z
IGNITE-5339: fix result set type, concurrency, holdability support
commit d90279ecde286ac1f082939091da90b09ef8aeb8
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-06T12:25:59Z
IGNITE-5339: fix result set type, concurrency, holdability support
commit 984f3c05c7d0d5f3a6b1eccb6562003b48855178
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-06T14:11:07Z
IGNITE-5339: some fixes
commit 66f2c2453ae77764d32d33cea37c6dfb42dd444a
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-06T14:35:25Z
IGNITE-5339: failed with tickets
commit 3181cab663e971944ee54cd6bf2e22cf2e38b81e
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T10:46:49Z
IGNITE-5339: save the progress on Statement
commit efa60bf231017c74e9f3af47886ab18f35615d1b
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T10:47:30Z
IGNITE-5339: cleanup
commit 5e14627b136b49c0a50e49a3402b6f4f503041c2
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T12:13:59Z
IGNITE-5339: save the progress on Statement
commit 33f01e439ee33c6dbacad2ac83f8c50c7eee51d6
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T12:28:13Z
IGNITE-5339: save the progress on Statement
commit c89f64f598cc908fad9e66d80ed18b93f1bcaf50
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T12:43:09Z
Merge remote-tracking branch 'community/ignite-5339' into ignite-5339
# Conflicts:
# modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcStatementSelfTest.java
# modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java
commit 1a08f5f8a41d6d77b160c582ff72d8165f5d4429
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T12:45:23Z
IGNITE-5339: save the progress on Statement
commit dbec6240af197034acfa839832284b285678e80d
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T12:45:38Z
IGNITE-5339: save the progress on Statement
commit 18f095a9f257440ac76ccce7badf0666d339b97f
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T12:55:25Z
Merge branch '_master' into ignite-5339
commit 64691e3903b447580626b86dc5bc9ee43bafdfaf
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T14:16:23Z
IGNITE-5339: rename, save the progress on Statement
commit 46d4b61d7f75b2a555f549304265cc898aaec293
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-07T15:28:50Z
IGNITE-5339: save the progress on PreparedStatement
commit 0c1ac261f8e0cf9ae8325fd93ab5b70c1eb7b0bb
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2017-06-08T10:29:17Z
IGNITE-5339: renamed and save the progress on PreparedStatement
----
> JDBC thin driver: validate compliance
> -------------------------------------
>
> Key: IGNITE-5339
> URL: https://issues.apache.org/jira/browse/IGNITE-5339
> Project: Ignite
> Issue Type: Task
> Components: sql
> Reporter: Vladimir Ozerov
> Assignee: Taras Ledkov
> Labels: important
> Fix For: 2.1
>
>
> We need to make sure that all methods of our new driver are compliant with JDBC spec, namely:
> 1) Semantics of normal execution is correct
> 2) Exceptions are thrown when excepted
> I propose the following flow:
> 1) Walk through interface classes (Connection -> Statement, PreparedStatement -> ResultSet)
> 2) For every method identify a set of tests to verify semantics (if any).
> 3) Write those tests, even if they fail.
> 4) Once all tests are ready, decide how to proceed with their fixes.
> NB: we should write tests even for methods which throw "not-implemented exception", so that we better understand the scope of remaining work.
> Link to [JDBC specification|http://download.oracle.com/otn-pub/jcp/jdbc-4_1-mrel-spec/jdbc4.1-fr-spec.pdf?AuthParam=1496141650_c2ec45f13eb8c532632bbfaede64f351]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)