[GitHub] [nifi] Lehel44 commented on a diff in pull request #5888: NIFI-7230: Created toInstant() and formatInstant() EL functions

[GitBox <gi...@apache.org>]

Lehel44 commented on code in PR #5888:
URL: https://github.com/apache/nifi/pull/5888#discussion_r866806989


##########
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/compile/ExpressionCompiler.java:
##########
@@ -559,6 +572,18 @@ private DateEvaluator toDateEvaluator(final Evaluator<?> evaluator, final String
         return new DateCastEvaluator(evaluator);
     }
 
+    private InstantEvaluator toInstantEvaluator(final Evaluator<?> evaluator) {
+        return toInstantEvaluator(evaluator, null);
+    }
+
+    private InstantEvaluator toInstantEvaluator(final Evaluator<?> evaluator, final String location) {

Review Comment:
   I followed the toDateEvaluator pattern and that doesn't use the location.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org