You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/30 17:39:51 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #26764: Update snowflake hook to not use extra prefix unless necessary.

eladkal commented on code in PR #26764:
URL: https://github.com/apache/airflow/pull/26764#discussion_r984815182


##########
airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -41,6 +42,18 @@ def _try_to_boolean(value: Any):
     return value
 
 
+def _maybe_add_prefix(val):
+    """
+    From Airflow 2.3 onward, there is no longer a need to add the `extra__<conn type>__`

Review Comment:
   Next provider release cycle is going to set min Airflow version 2.3 for all providers:
   https://github.com/apache/airflow#release-process-for-providers
   
   Since the next cycle is on October any way maybe we should hold this PR till we adjust the min Airflow version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org