You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/08/15 09:26:41 UTC

[GitHub] [echarts] susiwen8 opened a new pull request #15535: Feat(line): event on whole line

susiwen8 opened a new pull request #15535:
URL: https://github.com/apache/echarts/pull/15535


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   `series` should response to event. Add extra check for `seriesIndex`
   
   
   
   ### Fixed issues
   
   Close #13637 #13843
   
   
   ## Details
   
   ### Before: What was the problem?
   
   ![Kapture 2021-08-15 at 17 25 34](https://user-images.githubusercontent.com/20318608/129473870-d0c779a4-965e-4f3e-a1fb-b4f1560fd491.gif)
   
   
   
   
   ### After: How is it fixed in this PR?
   
   ![Kapture 2021-08-15 at 17 23 51](https://user-images.githubusercontent.com/20318608/129473815-d9021902-66ad-487e-a451-340806ab5860.gif)
   
   
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15535: Feat(line): event on whole line

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15535:
URL: https://github.com/apache/echarts/pull/15535#issuecomment-899022224


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on pull request #15535: Feat(line): event on whole line

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #15535:
URL: https://github.com/apache/echarts/pull/15535#issuecomment-913267182


   This is an underlying change that will affect all series. Could you please do a double-check what's the behavior of the other series after this change @susiwen8 @Ovilia? For example: are there other series that will also have elements only having `seriesIndex` and will trigger events. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15535: Feat(line): event on whole line

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15535:
URL: https://github.com/apache/echarts/pull/15535#issuecomment-911233086


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia merged pull request #15535: Feat(line): event on whole line

Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #15535:
URL: https://github.com/apache/echarts/pull/15535


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org