You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/06/20 06:41:29 UTC

[GitHub] sureshanaparti commented on a change in pull request #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

sureshanaparti commented on a change in pull request #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state
URL: https://github.com/apache/cloudstack/pull/2149#discussion_r122890786
 
 

 ##########
 File path: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
 ##########
 @@ -530,6 +534,13 @@ public boolean deleteSnapshot(long snapshotId) {
             return false;
         }
 
+        List<VolumeDetailVO> volumeCheck;
 
 Review comment:
   Can you update the variable name to more meaningful. eg: volumesFromSnapshot
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services