You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/28 05:45:12 UTC
[GitHub] [incubator-doris] pengxiangyu opened a new pull request, #9283: Fix bug for nullptr on replayEraseTable
pengxiangyu opened a new pull request, #9283:
URL: https://github.com/apache/incubator-doris/pull/9283
# Proposed changes
Issue Number: close #9265
## Problem Summary:
Add null checker
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] pengxiangyu closed pull request #9283: Fix bug for nullptr on replayEraseTable
Posted by GitBox <gi...@apache.org>.
pengxiangyu closed pull request #9283: Fix bug for nullptr on replayEraseTable
URL: https://github.com/apache/doris/pull/9283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9283: Fix bug for nullptr on replayEraseTable
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9283:
URL: https://github.com/apache/incubator-doris/pull/9283#discussion_r861492798
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java:
##########
@@ -223,6 +223,13 @@ public synchronized void replayEraseTable(long tableId) {
RecycleTableInfo tableInfo = idToTable.remove(tableId);
idToRecycleTime.remove(tableId);
+ // tableInfo == null means tableId is not in image. replayEraseTable is used to drop this table.
+ // If it is not exist, table is already dropped, this replay operation is duplicate, so nothing to do.
+ if (tableInfo == null) {
+ LOG.warn("replayEraseTable, idToTable has no tableId: {}, ignore it", tableId);
Review Comment:
If the table is dropped, then there should be drop table log and be replayed. Then erase table log will not occur. Any other things wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org