You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/20 23:23:51 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #29495: [SPARK-32640][SQL] Downgrade Janino to fix a correctness bug

HeartSaVioR commented on pull request #29495:
URL: https://github.com/apache/spark/pull/29495#issuecomment-677954308


   Nice finding and thanks for fixing the bug. Late LGTM. I agree that downgrading the version is good resolution in current situation.
   
   Downgrading this to 3.0.x re-brings the question though, as 3.0.x is deprecated and author won't care about it. Is migrating Janino to 3.1.x our eventual goal, or we'd like to stick with deprecated version line and deal with the version by ourselves once we hit some other issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org