You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ChengXiangLi <gi...@git.apache.org> on 2015/08/31 08:00:14 UTC
[GitHub] flink pull request: [FLINK-2596] Failing Test: RandomSamplerTest
GitHub user ChengXiangLi opened a pull request:
https://github.com/apache/flink/pull/1080
[FLINK-2596] Failing Test: RandomSamplerTest
Remove the non-transitive comparator which cause this issue, default Double comparator works just fine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChengXiangLi/flink FLINK-2596
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1080
----
commit 87d53380e8f83841011f787801042b7ca9560bd8
Author: chengxiang li <ch...@intel.com>
Date: 2015-08-31T06:02:27Z
[FLINK-2596] Remove non-tranitive comparator in random sampler test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2596] Failing Test: RandomSamplerTest
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1080#issuecomment-136276551
Looks good to merge. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2596] Failing Test: RandomSamplerTest
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1080#issuecomment-136335673
Thanks, will merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2596] Failing Test: RandomSamplerTest
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1080#issuecomment-136663351
This has been merged, but I think apache and github is out of sync again. Feel free to manually close this.
Thank you for the contribution!
https://git-wip-us.apache.org/repos/asf/flink/repo?p=flink.git;a=commit;h=f4a48c23a30c170a5a2c08c27e1f01f7827eefd2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2596] Failing Test: RandomSamplerTest
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1080
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---