You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2015/10/26 17:46:30 UTC
[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/982
Rename xapi plugins for s3 and swift to make them work after renaming the calls
Make renaming introduced in a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 work for S3 and Swift xapi plugins.
This PR is to address comments in PR #970
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack fix-s3-swift
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/982.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #982
----
commit d51b4a3b02db042bc94bb3956a1df0bca27ffb19
Author: Remi Bergsma <gi...@remi.nl>
Date: 2015-10-26T16:40:53Z
Rename xapi plugins for s3 and swift to make them work after renaming the calls
Renaming introduced in a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0
This PR is to address comments in PR #970
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...
Posted by xenserverarmy <gi...@git.apache.org>.
Github user xenserverarmy commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-151967711
@remibergsma How did the tests work out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152441549
@remibergsma ... Will start testing now!
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9014 Rename xapi plugins for s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152304547
@DaanHoogland @wilderrodrigues You can do this to test this PR:
```
./kvm_local_deploy.py -r xenserver65
/data/shared/helper_scripts/cloudstack/check-pr.sh -m /data/shared/marvin/mct-zone1-xen1.cfg -p 982
```
Once the deploy is done:
``
ssh xen1
ls -la /etc/xapi.d/plugins/ | grep xenserver
``
Before this PR, the result was:
```
-rwxr-xr-x 1 root root 12714 Oct 29 20:20 s3xen
-rwxr-xr-x 1 root root 3241 Oct 29 20:19 swiftxen
```
Now it is:
```
-rwxr-xr-x 1 root root 12714 Oct 29 20:20 s3xenserver
-rwxr-xr-x 1 root root 3241 Oct 29 20:19 swiftxenserver
```
Can you also verify this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152497680
manually tested by upgrading an existing xenserver setup and force reconnecting the host
Before
```
[root@rjn-xen65-host plugins]# ls -la /etc/xapi.d/plugins/ | grep xen
-rwxr-xr-x 1 root root 12708 Sep 29 10:44 s3xen
-rwxr-xr-x 1 root root 3235 Sep 29 10:44 swiftxen
```
After
```
[root@rjn-xen65-host plugins]# ls -la /etc/xapi.d/plugins/ | grep xen
-rwxr-xr-x 1 root root 12708 Sep 29 10:44 s3xen
-rwxr-xr-x 1 root root 12714 Oct 30 10:42 s3xenserver
-rwxr-xr-x 1 root root 3235 Sep 29 10:44 swiftxen
-rwxr-xr-x 1 root root 3241 Oct 30 10:42 swiftxenserver
```
I am guessing having the both the scripts after upgrade wont be an issue. I didnt see any issues after the change(manually tested launch new vm etc.)
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9014 Rename xapi plugins for s...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152553309
@karuturi Added Jira issue CLOUDSTACK-9014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152303070
@xenserverarmy Sure, it works. It's very easy, the files end up in `/etc/xapi.d/plugins`. Are you able to verify yourself?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/982#issuecomment-152451246
Just tested it! LGTM :+1:
```
[root@xen1 ~]# ls -la /etc/xapi.d/plugins/ | grep xenserver
-rwxr-xr-x 1 root root 12714 Oct 30 07:52 s3xenserver
-rwxr-xr-x 1 root root 3241 Oct 30 07:52 swiftxenserver
[root@xen1 ~]# uname -a
Linux xen1 3.10.0+2 #1 SMP Tue Dec 9 12:45:36 EST 2014 x86_64 x86_64 x86_64 GNU/Linux
[root@xen1 ~]#
```
I will also run some basic tests to make sure all is fine!
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---